public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Pawel Moll <Pawel.Moll@arm.com>
Cc: Alexander Shiyan <shc_work@mail.ru>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
	Brian Norris <computersforpeace@gmail.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v2 4/4] mtd: nand: gpio: Add support for multichip devices
Date: Tue, 30 Jul 2013 16:56:35 +0100	[thread overview]
Message-ID: <20130730155635.GE29859@e106331-lin.cambridge.arm.com> (raw)
In-Reply-To: <1375183165.2272.1.camel@hornet>

On Tue, Jul 30, 2013 at 12:19:25PM +0100, Pawel Moll wrote:
> On Tue, 2013-07-30 at 15:05 +0400, Alexander Shiyan wrote:
> > +- gpio-ale : specifies the ALE gpio pin.
> > +- gpio-cle : specifies the CLE gpio pin.
> > +- gpio-nwp : specifies the NWP gpio pin (Optional).
> > +- gpios-nce : specifies the NCE gpio pin or several NCE GPIOs for multichip NAND.
> > +- gpios-rdy : specifies the RDY gpio pin or several RDY GPIOs for multichip NAND.
> 
> Let me quote Documentation/devicetree/bindings/gpio/gpio.txt:
> 
> 	GPIO properties should be named "[<name>-]gpios"
> 
> So I believe it should rather be: "ale-gpios", "cle-gpios", "nwp-gpios",
> "nce-gpios", "rdy-gpios"...
> 
> Pawel
> 

+1

Mark.

  reply	other threads:[~2013-07-30 15:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-30 11:05 [PATCH v2 1/4] mtd: nand: gpio: Determine bus width automatically Alexander Shiyan
2013-07-30 11:05 ` [PATCH v2 4/4] mtd: nand: gpio: Add support for multichip devices Alexander Shiyan
2013-07-30 11:19   ` Pawel Moll
2013-07-30 15:56     ` Mark Rutland [this message]
2013-07-30 15:56 ` [PATCH v2 1/4] mtd: nand: gpio: Determine bus width automatically Mark Rutland
2013-07-30 16:34 ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130730155635.GE29859@e106331-lin.cambridge.arm.com \
    --to=mark.rutland@arm.com \
    --cc=Pawel.Moll@arm.com \
    --cc=artem.bityutskiy@linux.intel.com \
    --cc=computersforpeace@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=ian.campbell@citrix.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=rob.herring@calxeda.com \
    --cc=shc_work@mail.ru \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox