From: Mark Rutland <mark.rutland@arm.com>
To: Ian Molton <ian.molton@codethink.co.uk>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"laurent.pinchart@ideasonboard.com"
<laurent.pinchart@ideasonboard.com>,
"hans.verkuil@cisco.com" <hans.verkuil@cisco.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"lars@metafoo.de" <lars@metafoo.de>,
"shubhrajyoti@ti.com" <shubhrajyoti@ti.com>,
"william.towle@codethink.co.uk" <william.towle@codethink.co.uk>
Subject: Re: [PATCH 2/2] media: adv7604: Add ability to read default input port from DT
Date: Wed, 13 Aug 2014 17:24:40 +0100 [thread overview]
Message-ID: <20140813162439.GG32644@leverpostej> (raw)
In-Reply-To: <20140813131435.e0da6946bcd69e04a2305ef9@codethink.co.uk>
On Wed, Aug 13, 2014 at 01:14:35PM +0100, Ian Molton wrote:
> On Mon, 11 Aug 2014 13:19:02 +0100
> Mark Rutland <mark.rutland@arm.com> wrote:
>
> > > - - pclk-sample: Pixel clock polarity. Defaults to output on the falling edge.
> > > + - pclk-sample: Pixel clock polarity. Defaults to output on the falling edge.
> >
> > Unrelated whitespace change?
>
> Is there a sensible way to get miniscule whitespace changes in?
Just mention it in the commit message.
> > > If none of hsync-active, vsync-active and pclk-sample is specified the
> > > endpoint will use embedded BT.656 synchronization.
> > >
> > > + - default-input: Select which input is selected after reset.
> >
> > Valid values are?
>
> Chip dependent. 0 for 7611, 0-1 for 7612, I expect there are other chips in the family with differing numbers of inputs.
Ok. Can this be mentioned in the documentation?
Cheers,
Mark.
> > > + if (!of_property_read_u32(endpoint, "default_input", &v))
> >
> > This doesn't match the binding ('_' vs '-').
>
> Good catch!
>
> --
> Ian Molton <ian.molton@codethink.co.uk>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2014-08-13 16:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-11 12:05 [PATCH 0/1 v1] adv7604: Add adv7612 support Ian Molton
2014-08-11 12:05 ` [PATCH 1/2] media: adv7604: Add support for ADV7612 dual HDMI input decoder Ian Molton
2014-08-18 22:25 ` Laurent Pinchart
[not found] ` <1407758719-12474-1-git-send-email-ian.molton-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
2014-08-11 12:05 ` [PATCH 2/2] media: adv7604: Add ability to read default input port from DT Ian Molton
2014-08-11 12:19 ` Mark Rutland
2014-08-13 12:14 ` Ian Molton
2014-08-13 16:24 ` Mark Rutland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140813162439.GG32644@leverpostej \
--to=mark.rutland@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=hans.verkuil@cisco.com \
--cc=ian.molton@codethink.co.uk \
--cc=lars@metafoo.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shubhrajyoti@ti.com \
--cc=william.towle@codethink.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox