Devicetree
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: at919260/at91sam9g20: fix SRAM device tree node
@ 2015-03-02  6:03 Wenyou Yang
       [not found] ` <1425276209-4899-1-git-send-email-wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Wenyou Yang @ 2015-03-02  6:03 UTC (permalink / raw)
  To: nicolas.ferre
  Cc: mark.rutland, devicetree, linux, pawel.moll, ijc+devicetree,
	linux-kernel, wenyou.yang, robh+dt, galak, linux,
	linux-arm-kernel

Fix PM does not work on the at91sam9g20ek board
--->8---
at91_pm_sram_init: failed to find sram device!
---<8---

Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
---
 arch/arm/boot/dts/at91sam9260.dtsi |    9 +++++++--
 arch/arm/boot/dts/at91sam9g20.dtsi |    9 +++++----
 2 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/arch/arm/boot/dts/at91sam9260.dtsi b/arch/arm/boot/dts/at91sam9260.dtsi
index fff0ee6..d1eb27c 100644
--- a/arch/arm/boot/dts/at91sam9260.dtsi
+++ b/arch/arm/boot/dts/at91sam9260.dtsi
@@ -69,9 +69,14 @@
 		};
 	};
 
-	sram0: sram@002ff000 {
+	sram0: sram@00200000 {
 		compatible = "mmio-sram";
-		reg = <0x002ff000 0x2000>;
+		reg = <0x00200000 0x1000>;
+	};
+
+	sram1: sram@00300000 {
+		compatible = "mmio-sram";
+		reg = <0x00300000 0x1000>;
 	};
 
 	ahb {
diff --git a/arch/arm/boot/dts/at91sam9g20.dtsi b/arch/arm/boot/dts/at91sam9g20.dtsi
index f593016..eb9a62d 100644
--- a/arch/arm/boot/dts/at91sam9g20.dtsi
+++ b/arch/arm/boot/dts/at91sam9g20.dtsi
@@ -16,13 +16,14 @@
 		reg = <0x20000000 0x08000000>;
 	};
 
-	sram0: sram@002ff000 {
-		status = "disabled";
+	sram0: sram@00200000 {
+		compatible = "mmio-sram";
+		reg = <0x00200000 0x4000>;
 	};
 
-	sram1: sram@002fc000 {
+	sram1: sram@00300000 {
 		compatible = "mmio-sram";
-		reg = <0x002fc000 0x8000>;
+		reg = <0x00300000 0x4000>;
 	};
 
 	ahb {
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: at919260/at91sam9g20: fix SRAM device tree node
       [not found] ` <1425276209-4899-1-git-send-email-wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
@ 2015-03-02  9:53   ` Alexandre Belloni
       [not found]     ` <20150302095359.GJ4094-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Alexandre Belloni @ 2015-03-02  9:53 UTC (permalink / raw)
  To: Wenyou Yang
  Cc: nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w, mark.rutland-5wv7dgnIgG8,
	devicetree-u79uwXL29TY76Z2rM5mHXA, linux-lFZ/pmaqli7XmaaqVzeoHQ,
	pawel.moll-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A, galak-sgV2jX0FEOL9JmXXK+q4OQ,
	linux-PelNFVqkFnVyf+4FbqDuWQ,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r

Hi Wenyou,

I'd prefer fixing the sram lookup in pm.c. I'll propose something
however, I can't test on my side.

On 02/03/2015 at 14:03:29 +0800, Wenyou Yang wrote :
> Fix PM does not work on the at91sam9g20ek board
> --->8---
> at91_pm_sram_init: failed to find sram device!
> ---<8---
> 
> Signed-off-by: Wenyou Yang <wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
> ---
>  arch/arm/boot/dts/at91sam9260.dtsi |    9 +++++++--
>  arch/arm/boot/dts/at91sam9g20.dtsi |    9 +++++----
>  2 files changed, 12 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/at91sam9260.dtsi b/arch/arm/boot/dts/at91sam9260.dtsi
> index fff0ee6..d1eb27c 100644
> --- a/arch/arm/boot/dts/at91sam9260.dtsi
> +++ b/arch/arm/boot/dts/at91sam9260.dtsi
> @@ -69,9 +69,14 @@
>  		};
>  	};
>  
> -	sram0: sram@002ff000 {
> +	sram0: sram@00200000 {
>  		compatible = "mmio-sram";
> -		reg = <0x002ff000 0x2000>;
> +		reg = <0x00200000 0x1000>;
> +	};
> +
> +	sram1: sram@00300000 {
> +		compatible = "mmio-sram";
> +		reg = <0x00300000 0x1000>;
>  	};
>  
>  	ahb {
> diff --git a/arch/arm/boot/dts/at91sam9g20.dtsi b/arch/arm/boot/dts/at91sam9g20.dtsi
> index f593016..eb9a62d 100644
> --- a/arch/arm/boot/dts/at91sam9g20.dtsi
> +++ b/arch/arm/boot/dts/at91sam9g20.dtsi
> @@ -16,13 +16,14 @@
>  		reg = <0x20000000 0x08000000>;
>  	};
>  
> -	sram0: sram@002ff000 {
> -		status = "disabled";
> +	sram0: sram@00200000 {
> +		compatible = "mmio-sram";
> +		reg = <0x00200000 0x4000>;
>  	};
>  
> -	sram1: sram@002fc000 {
> +	sram1: sram@00300000 {
>  		compatible = "mmio-sram";
> -		reg = <0x002fc000 0x8000>;
> +		reg = <0x00300000 0x4000>;
>  	};
>  
>  	ahb {
> -- 
> 1.7.9.5
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread
* RE: [PATCH] ARM: dts: at919260/at91sam9g20: fix SRAM device tree node
       [not found]     ` <20150302095359.GJ4094-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org>
@ 2015-03-02  9:59       ` Yang, Wenyou
  0 siblings, 0 replies; 3+ messages in thread
From: Yang, Wenyou @ 2015-03-02  9:59 UTC (permalink / raw)
  To: Alexandre Belloni
  Cc: Ferre, Nicolas, mark.rutland-5wv7dgnIgG8@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
	pawel.moll-5wv7dgnIgG8@public.gmane.org,
	ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	linux-PelNFVqkFnVyf+4FbqDuWQ@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org

Hi Alexandre,

> -----Original Message-----
> From: Alexandre Belloni [mailto:alexandre.belloni@free-electrons.com]
> Sent: 2015年3月2日 17:54
> To: Yang, Wenyou
> Cc: Ferre, Nicolas; mark.rutland@arm.com; devicetree@vger.kernel.org;
> linux@arm.linux.org.uk; pawel.moll@arm.com; ijc+devicetree@hellion.org.uk; linux-
> kernel@vger.kernel.org; robh+dt@kernel.org; galak@codeaurora.org;
> linux@maxim.org.za; linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH] ARM: dts: at919260/at91sam9g20: fix SRAM device tree
> node
> 
> Hi Wenyou,
> 
> I'd prefer fixing the sram lookup in pm.c. I'll propose something however, I can't
> test on my side.
I can help test it if you give me your patches to me.

> 
> On 02/03/2015 at 14:03:29 +0800, Wenyou Yang wrote :
> > Fix PM does not work on the at91sam9g20ek board
> > --->8---
> > at91_pm_sram_init: failed to find sram device!
> > ---<8---
> >
> > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> > ---
> >  arch/arm/boot/dts/at91sam9260.dtsi |    9 +++++++--
> >  arch/arm/boot/dts/at91sam9g20.dtsi |    9 +++++----
> >  2 files changed, 12 insertions(+), 6 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/at91sam9260.dtsi
> > b/arch/arm/boot/dts/at91sam9260.dtsi
> > index fff0ee6..d1eb27c 100644
> > --- a/arch/arm/boot/dts/at91sam9260.dtsi
> > +++ b/arch/arm/boot/dts/at91sam9260.dtsi
> > @@ -69,9 +69,14 @@
> >  		};
> >  	};
> >
> > -	sram0: sram@002ff000 {
> > +	sram0: sram@00200000 {
> >  		compatible = "mmio-sram";
> > -		reg = <0x002ff000 0x2000>;
> > +		reg = <0x00200000 0x1000>;
> > +	};
> > +
> > +	sram1: sram@00300000 {
> > +		compatible = "mmio-sram";
> > +		reg = <0x00300000 0x1000>;
> >  	};
> >
> >  	ahb {
> > diff --git a/arch/arm/boot/dts/at91sam9g20.dtsi
> > b/arch/arm/boot/dts/at91sam9g20.dtsi
> > index f593016..eb9a62d 100644
> > --- a/arch/arm/boot/dts/at91sam9g20.dtsi
> > +++ b/arch/arm/boot/dts/at91sam9g20.dtsi
> > @@ -16,13 +16,14 @@
> >  		reg = <0x20000000 0x08000000>;
> >  	};
> >
> > -	sram0: sram@002ff000 {
> > -		status = "disabled";
> > +	sram0: sram@00200000 {
> > +		compatible = "mmio-sram";
> > +		reg = <0x00200000 0x4000>;
> >  	};
> >
> > -	sram1: sram@002fc000 {
> > +	sram1: sram@00300000 {
> >  		compatible = "mmio-sram";
> > -		reg = <0x002fc000 0x8000>;
> > +		reg = <0x00300000 0x4000>;
> >  	};
> >
> >  	ahb {
> > --
> > 1.7.9.5
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 
> --
> Alexandre Belloni, Free Electrons
> Embedded Linux, Kernel and Android engineering http://free-electrons.com

Best Regards,
Wenyou Yang

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-02  9:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-02  6:03 [PATCH] ARM: dts: at919260/at91sam9g20: fix SRAM device tree node Wenyou Yang
     [not found] ` <1425276209-4899-1-git-send-email-wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2015-03-02  9:53   ` Alexandre Belloni
     [not found]     ` <20150302095359.GJ4094-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org>
2015-03-02  9:59       ` Yang, Wenyou

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox