* [PATCH 6/6] ARM: dts: set up trigger type for edt-ft5x06 interrupts [not found] <5044530af510d6686e78f8dfa912d89ef824f899.1442079408.git.dmitry.torokhov@gmail.com> @ 2015-09-12 17:45 ` Dmitry Torokhov 2015-09-14 21:24 ` Felipe Balbi [not found] ` <2adcbfd1d5b237598d37edcbeec4a8dbd443f36f.1442079408.git.dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 0 siblings, 2 replies; 4+ messages in thread From: Dmitry Torokhov @ 2015-09-12 17:45 UTC (permalink / raw) To: linux-input Cc: linux-kernel, Franklin S Cooper Jr, Maxime Ripard, Lothar Waßmann, Tony Lindgren, Rob Herring, Pawel Moll, Shawn Guo, Sascha Hauer, devicetree, linux-arm-kernel Now that the driver respects IRQ trigger settings from device tree, let's fix them up in individual DTSes (note that the driver is still compatible with older DTSes). Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- arch/arm/boot/dts/am437x-sk-evm.dts | 2 +- arch/arm/boot/dts/imx28-tx28.dts | 3 ++- arch/arm/boot/dts/imx53-tx53-x03x.dts | 3 ++- arch/arm/boot/dts/imx6qdl-tx6.dtsi | 3 ++- 4 files changed, 7 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/am437x-sk-evm.dts b/arch/arm/boot/dts/am437x-sk-evm.dts index c17097d..d83fdcd 100644 --- a/arch/arm/boot/dts/am437x-sk-evm.dts +++ b/arch/arm/boot/dts/am437x-sk-evm.dts @@ -471,7 +471,7 @@ reg = <0x38>; interrupt-parent = <&gpio0>; - interrupts = <31 0>; + interrupts = <31 IRQ_TYPE_EDGE_FALLING>; reset-gpios = <&gpio1 28 GPIO_ACTIVE_LOW>; diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts index a5b27c8..4ea8934 100644 --- a/arch/arm/boot/dts/imx28-tx28.dts +++ b/arch/arm/boot/dts/imx28-tx28.dts @@ -13,6 +13,7 @@ /dts-v1/; #include "imx28.dtsi" #include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/interrupt-controller/irq.h> / { model = "Ka-Ro electronics TX28 module"; @@ -324,7 +325,7 @@ pinctrl-names = "default"; pinctrl-0 = <&tx28_edt_ft5x06_pins>; interrupt-parent = <&gpio2>; - interrupts = <5 0>; + interrupts = <5 IRQ_TYPE_EDGE_FALLING>; reset-gpios = <&gpio2 6 GPIO_ACTIVE_LOW>; wake-gpios = <&gpio4 9 GPIO_ACTIVE_HIGH>; }; diff --git a/arch/arm/boot/dts/imx53-tx53-x03x.dts b/arch/arm/boot/dts/imx53-tx53-x03x.dts index 3b73e81..13e842b 100644 --- a/arch/arm/boot/dts/imx53-tx53-x03x.dts +++ b/arch/arm/boot/dts/imx53-tx53-x03x.dts @@ -12,6 +12,7 @@ /dts-v1/; #include "imx53-tx53.dtsi" #include <dt-bindings/input/input.h> +#include <dt-bindings/interrupt-controller/irq.h> #include <dt-bindings/pwm/pwm.h> / { @@ -216,7 +217,7 @@ pinctrl-names = "default"; pinctrl-0 = <&pinctrl_edt_ft5x06_1>; interrupt-parent = <&gpio6>; - interrupts = <15 0>; + interrupts = <15 IRQ_TYPE_EDGE_FALLING>; reset-gpios = <&gpio2 22 GPIO_ACTIVE_LOW>; wake-gpios = <&gpio2 21 GPIO_ACTIVE_HIGH>; }; diff --git a/arch/arm/boot/dts/imx6qdl-tx6.dtsi b/arch/arm/boot/dts/imx6qdl-tx6.dtsi index da08de3..13cb7cc 100644 --- a/arch/arm/boot/dts/imx6qdl-tx6.dtsi +++ b/arch/arm/boot/dts/imx6qdl-tx6.dtsi @@ -11,6 +11,7 @@ #include <dt-bindings/gpio/gpio.h> #include <dt-bindings/input/input.h> +#include <dt-bindings/interrupt-controller/irq.h> #include <dt-bindings/pwm/pwm.h> / { @@ -272,7 +273,7 @@ pinctrl-names = "default"; pinctrl-0 = <&pinctrl_edt_ft5x06>; interrupt-parent = <&gpio6>; - interrupts = <15 0>; + interrupts = <15 IRQ_TYPE_EDGE_FALLING>; reset-gpios = <&gpio2 22 GPIO_ACTIVE_LOW>; wake-gpios = <&gpio2 21 GPIO_ACTIVE_HIGH>; linux,wakeup; -- 2.6.0.rc0.131.gf624c3d ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 6/6] ARM: dts: set up trigger type for edt-ft5x06 interrupts 2015-09-12 17:45 ` [PATCH 6/6] ARM: dts: set up trigger type for edt-ft5x06 interrupts Dmitry Torokhov @ 2015-09-14 21:24 ` Felipe Balbi [not found] ` <20150914212426.GA9968-HgARHv6XitJaoMGHk7MhZQC/G2K4zDHf@public.gmane.org> [not found] ` <2adcbfd1d5b237598d37edcbeec4a8dbd443f36f.1442079408.git.dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 1 sibling, 1 reply; 4+ messages in thread From: Felipe Balbi @ 2015-09-14 21:24 UTC (permalink / raw) To: Dmitry Torokhov Cc: linux-input, linux-kernel, Franklin S Cooper Jr, Maxime Ripard, Lothar Waßmann, Tony Lindgren, Rob Herring, Pawel Moll, Shawn Guo, Sascha Hauer, devicetree, linux-arm-kernel [-- Attachment #1: Type: text/plain, Size: 1108 bytes --] On Sat, Sep 12, 2015 at 10:45:51AM -0700, Dmitry Torokhov wrote: > Now that the driver respects IRQ trigger settings from device tree, let's > fix them up in individual DTSes (note that the driver is still compatible > with older DTSes). > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > --- > arch/arm/boot/dts/am437x-sk-evm.dts | 2 +- > arch/arm/boot/dts/imx28-tx28.dts | 3 ++- > arch/arm/boot/dts/imx53-tx53-x03x.dts | 3 ++- > arch/arm/boot/dts/imx6qdl-tx6.dtsi | 3 ++- > 4 files changed, 7 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/am437x-sk-evm.dts b/arch/arm/boot/dts/am437x-sk-evm.dts > index c17097d..d83fdcd 100644 > --- a/arch/arm/boot/dts/am437x-sk-evm.dts > +++ b/arch/arm/boot/dts/am437x-sk-evm.dts > @@ -471,7 +471,7 @@ > > reg = <0x38>; > interrupt-parent = <&gpio0>; > - interrupts = <31 0>; > + interrupts = <31 IRQ_TYPE_EDGE_FALLING>; for AM437x SK: Acked-by: Felipe Balbi <balbi@ti.com> Seems like there are no changes considering driver was always using IRQF_TRIGGER_FALLING. -- balbi [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <20150914212426.GA9968-HgARHv6XitJaoMGHk7MhZQC/G2K4zDHf@public.gmane.org>]
* Re: [PATCH 6/6] ARM: dts: set up trigger type for edt-ft5x06 interrupts [not found] ` <20150914212426.GA9968-HgARHv6XitJaoMGHk7MhZQC/G2K4zDHf@public.gmane.org> @ 2015-09-15 15:40 ` Tony Lindgren 0 siblings, 0 replies; 4+ messages in thread From: Tony Lindgren @ 2015-09-15 15:40 UTC (permalink / raw) To: Felipe Balbi Cc: Dmitry Torokhov, linux-input-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, Franklin S Cooper Jr, Maxime Ripard, Lothar Waßmann, Rob Herring, Pawel Moll, Shawn Guo, Sascha Hauer, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r * Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org> [150914 14:28]: > On Sat, Sep 12, 2015 at 10:45:51AM -0700, Dmitry Torokhov wrote: > > Now that the driver respects IRQ trigger settings from device tree, let's > > fix them up in individual DTSes (note that the driver is still compatible > > with older DTSes). > > > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > > --- > > arch/arm/boot/dts/am437x-sk-evm.dts | 2 +- > > arch/arm/boot/dts/imx28-tx28.dts | 3 ++- > > arch/arm/boot/dts/imx53-tx53-x03x.dts | 3 ++- > > arch/arm/boot/dts/imx6qdl-tx6.dtsi | 3 ++- > > 4 files changed, 7 insertions(+), 4 deletions(-) > > > > diff --git a/arch/arm/boot/dts/am437x-sk-evm.dts b/arch/arm/boot/dts/am437x-sk-evm.dts > > index c17097d..d83fdcd 100644 > > --- a/arch/arm/boot/dts/am437x-sk-evm.dts > > +++ b/arch/arm/boot/dts/am437x-sk-evm.dts > > @@ -471,7 +471,7 @@ > > > > reg = <0x38>; > > interrupt-parent = <&gpio0>; > > - interrupts = <31 0>; > > + interrupts = <31 IRQ_TYPE_EDGE_FALLING>; > > for AM437x SK: > > Acked-by: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org> > > Seems like there are no changes considering driver was always using > IRQF_TRIGGER_FALLING. Should not cause merge conflicts AFAIK: Acked-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <2adcbfd1d5b237598d37edcbeec4a8dbd443f36f.1442079408.git.dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH 6/6] ARM: dts: set up trigger type for edt-ft5x06 interrupts [not found] ` <2adcbfd1d5b237598d37edcbeec4a8dbd443f36f.1442079408.git.dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2015-09-23 12:16 ` Shawn Guo 0 siblings, 0 replies; 4+ messages in thread From: Shawn Guo @ 2015-09-23 12:16 UTC (permalink / raw) To: Dmitry Torokhov Cc: linux-input-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, Franklin S Cooper Jr, Maxime Ripard, Lothar Waßmann, Tony Lindgren, Rob Herring, Pawel Moll, Sascha Hauer, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On Sat, Sep 12, 2015 at 10:45:51AM -0700, Dmitry Torokhov wrote: > Now that the driver respects IRQ trigger settings from device tree, let's > fix them up in individual DTSes (note that the driver is still compatible > with older DTSes). > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > --- ... > arch/arm/boot/dts/imx28-tx28.dts | 3 ++- > arch/arm/boot/dts/imx53-tx53-x03x.dts | 3 ++- > arch/arm/boot/dts/imx6qdl-tx6.dtsi | 3 ++- Acked-by: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-09-23 12:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <5044530af510d6686e78f8dfa912d89ef824f899.1442079408.git.dmitry.torokhov@gmail.com>
2015-09-12 17:45 ` [PATCH 6/6] ARM: dts: set up trigger type for edt-ft5x06 interrupts Dmitry Torokhov
2015-09-14 21:24 ` Felipe Balbi
[not found] ` <20150914212426.GA9968-HgARHv6XitJaoMGHk7MhZQC/G2K4zDHf@public.gmane.org>
2015-09-15 15:40 ` Tony Lindgren
[not found] ` <2adcbfd1d5b237598d37edcbeec4a8dbd443f36f.1442079408.git.dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-09-23 12:16 ` Shawn Guo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox