From: Rob Herring <robh@kernel.org>
To: Phil Reid <preid@electromag.com.au>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH 2/5] stmmac: Correct documentation on stmmac clocks.
Date: Fri, 4 Dec 2015 10:18:07 -0600 [thread overview]
Message-ID: <20151204161807.GA10180@rob-hp-laptop> (raw)
In-Reply-To: <1449220125-67417-3-git-send-email-preid@electromag.com.au>
On Fri, Dec 04, 2015 at 05:08:42PM +0800, Phil Reid wrote:
> devm_get_clk looks in clock-name property for matching clock.
> the ptp_ref_clk property is ignored.
>
> Signed-off-by: Phil Reid <preid@electromag.com.au>
Acked-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/net/stmmac.txt | 17 ++++++++---------
> 1 file changed, 8 insertions(+), 9 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/stmmac.txt b/Documentation/devicetree/bindings/net/stmmac.txt
> index 0056c4c..060e2d5 100644
> --- a/Documentation/devicetree/bindings/net/stmmac.txt
> +++ b/Documentation/devicetree/bindings/net/stmmac.txt
> @@ -35,15 +35,14 @@ Optional properties:
> - reset-names: Should contain the reset signal name "stmmaceth", if a
> reset phandle is given
> - max-frame-size: See ethernet.txt file in the same directory
> -- clocks: If present, the first clock should be the GMAC main clock and
> - the second clock should be peripheral's register interface clock. Further
> - clocks may be specified in derived bindings.
> -- clock-names: One name for each entry in the clocks property, the
> - first one should be "stmmaceth" and the second one should be "pclk".
> -- clk_ptp_ref: this is the PTP reference clock; in case of the PTP is
> - available this clock is used for programming the Timestamp Addend Register.
> - If not passed then the system clock will be used and this is fine on some
> - platforms.
> +- clocks: If present, the first clock should be the GMAC main clock
> + The optional second clock should be peripheral's register interface clock.
> + The third optional clock should be the ptp reference clock.
> + Further clocks may be specified in derived bindings.
> +- clock-names: One name for each entry in the clocks property.
> + The first one should be "stmmaceth".
> + The optional second one should be "pclk".
> + The optional third one should be "clk_ptp_ref".
> - snps,burst_len: The AXI burst lenth value of the AXI BUS MODE register.
> - tx-fifo-depth: See ethernet.txt file in the same directory
> - rx-fifo-depth: See ethernet.txt file in the same directory
> --
> 1.8.3.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-12-04 16:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 9:08 [PATCH 0/5] stmmac: Fixed Phy & PTP fixes Phil Reid
2015-12-04 9:08 ` [PATCH 1/5] stmmac: create of compatible mdio bus for stmacc driver Phil Reid
2015-12-04 16:16 ` Rob Herring
2015-12-04 9:08 ` [PATCH 2/5] stmmac: Correct documentation on stmmac clocks Phil Reid
2015-12-04 16:18 ` Rob Herring [this message]
2015-12-04 9:08 ` [PATCH 3/5] stmmac: Fix calculations for ptp counters when clock input = 50Mhz Phil Reid
2015-12-04 9:08 ` [PATCH 4/5] stmmac: Add ptp debugfs entry Phil Reid
2015-12-04 9:08 ` [PATCH 5/5] stmmac: socfpga: Provide dt node to config ptp clk source Phil Reid
2015-12-04 16:19 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151204161807.GA10180@rob-hp-laptop \
--to=robh@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=preid@electromag.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox