From: Rob Herring <robh@kernel.org>
To: Phil Reid <preid@electromag.com.au>
Cc: pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linus.walleij@linaro.org, gnurou@gmail.com,
devicetree@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 1/1] gpio: mcp23s08: Add support for mcp23s18.
Date: Fri, 4 Mar 2016 22:24:52 -0600 [thread overview]
Message-ID: <20160305042452.GA13525@rob-hp-laptop> (raw)
In-Reply-To: <1456813541-74321-2-git-send-email-preid@electromag.com.au>
On Tue, Mar 01, 2016 at 02:25:41PM +0800, Phil Reid wrote:
> This patch adds support for the mcp23s18 which is very similar to
> the mcp23s17. A couple of control bits are not the same.
> Notable IOCON_HAEN (s17 only) & IOCON_INTCC. Which can be ignored.
>
> Patch changes the following:
> - Add mcp23s18 types.
> - Always set mirror bit if the dts defines mcp23s18. regardless of type.
> Mirror bit is ignored on 8 bit devices anyway.
> - In mcp23s08_probe use chip.ngpio instead of logic based on type
> to determine number of gpio lins to increment by. This is set
> appropiately by the call to mcp23s08_probe_one.
> - Add mcp23s18 to device tree documentation.
> - Remove statement that irqs don't work for spi. They do.
> Tested with mcp23s18.
>
> Signed-off-by: Phil Reid <preid@electromag.com.au>
> ---
> .../devicetree/bindings/gpio/gpio-mcp23s08.txt | 4 +---
Acked-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2016-03-05 4:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 6:25 [PATCH 0/1] gpio: mcp23s08: Add support for mcp23s18 Phil Reid
2016-03-01 6:25 ` [PATCH 1/1] " Phil Reid
2016-03-05 4:24 ` Rob Herring [this message]
2016-03-09 2:50 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160305042452.GA13525@rob-hp-laptop \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gnurou@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=preid@electromag.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox