From: Rob Herring <robh@kernel.org>
To: Ray Jui <ray.jui@broadcom.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
devicetree@vger.kernel.org
Subject: Re: [PATCH 3/4] dt-bindings: Update iProc GPIO bindings
Date: Thu, 14 Apr 2016 09:38:12 -0500 [thread overview]
Message-ID: <20160414143812.GA20964@rob-hp-laptop> (raw)
In-Reply-To: <1460506523-6249-4-git-send-email-ray.jui@broadcom.com>
On Tue, Apr 12, 2016 at 05:15:22PM -0700, Ray Jui wrote:
> Update the iProc GPIO binding document to introduce a new compatible
> string "brcm,iproc-gpio-only", that allows the generic pinconf function
> to be disabled completely
>
> Signed-off-by: Ray Jui <ray.jui@broadcom.com>
> Reviewed-by: Jon Mason <jon.mason@broadcom.com>
> Reviewed-by: Scott Branden <scott.branden@broadcom.com>
> ---
> Documentation/devicetree/bindings/pinctrl/brcm,iproc-gpio.txt | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/brcm,iproc-gpio.txt b/Documentation/devicetree/bindings/pinctrl/brcm,iproc-gpio.txt
> index ddaa1b0..75a4370 100644
> --- a/Documentation/devicetree/bindings/pinctrl/brcm,iproc-gpio.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/brcm,iproc-gpio.txt
> @@ -3,8 +3,11 @@ Broadcom iProc GPIO/PINCONF Controller
> Required properties:
>
> - compatible:
> - Must be "brcm,cygnus-ccm-gpio", "brcm,cygnus-asiu-gpio",
> - "brcm,cygnus-crmu-gpio" or "brcm,iproc-gpio"
> + For Cygnus, it must be brcm,cygnus-ccm-gpio", "brcm,cygnus-asiu-gpio", or
> +"brcm,cygnus-crmu-gpio"
> + For non-Cygnus iProc SoCs, it must be either "brcm,iproc-gpio-only" (if
> +only GPIO is supported) or "brcm,iproc-gpio" (if both generic pinconf and GPIO
> +are supported)
No. That's not how compatible strings work. Use SoC specific compatible
strings if you need to distinguish this.
Rob
next prev parent reply other threads:[~2016-04-14 14:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 0:15 [PATCH 0/4] Additional iProc GPIO support Ray Jui
2016-04-13 0:15 ` [PATCH 1/4] dt-bindings: Update iProc GPIO bindings Ray Jui
2016-04-13 0:15 ` [PATCH 2/4] pinctrl: iproc: Allow certain PINCONF functions to be disabled Ray Jui
2016-04-15 8:20 ` Linus Walleij
2016-04-18 19:22 ` Ray Jui
[not found] ` <1460506523-6249-1-git-send-email-ray.jui-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2016-04-13 0:15 ` [PATCH 3/4] dt-bindings: Update iProc GPIO bindings Ray Jui
2016-04-14 14:38 ` Rob Herring [this message]
2016-04-18 18:27 ` Ray Jui
2016-04-13 0:15 ` [PATCH 4/4] pinctrl: iproc: Allow PINCONF to be disabled completely Ray Jui
2016-04-15 8:24 ` Linus Walleij
2016-04-18 19:30 ` Ray Jui
2016-04-29 8:43 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160414143812.GA20964@rob-hp-laptop \
--to=robh@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ray.jui@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox