[PATCH] of: Add stub for of_get_next_parent()

[PATCH] of: Add stub for of_get_next_parent()

[Heikki Krogerus]

Fixes a compiler error:

drivers/phy/phy-core.c: In function ‘__of_phy_provider_register’:
drivers/phy/phy-core.c:848:13: error: implicit declaration of function
‘of_get_next_parent’ [-Werror=implicit-function-declaration]
    parent = of_get_next_parent(parent);
                 ^

Fixes: 2f7600bc981c ("phy: core: Allow children node to be overridden")
Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
---
 include/linux/of.h | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/include/linux/of.h b/include/linux/of.h
index c7292e8..00ab231 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -468,6 +468,12 @@ static inline struct device_node *of_get_parent(const struct device_node *node)
 	return NULL;
 }
 
+static inline struct device_node *of_get_next_parent(
+	const struct device_node *node)
+{
+	return NULL;
+}
+
 static inline struct device_node *of_get_next_child(
 	const struct device_node *node, struct device_node *prev)
 {
-- 
2.8.0.rc3

Re: [PATCH] of: Add stub for of_get_next_parent()

[Arnd Bergmann]

On Wednesday 27 April 2016 14:11:40 Heikki Krogerus wrote:
> Fixes a compiler error:
> 
> drivers/phy/phy-core.c: In function ‘__of_phy_provider_register’:
> drivers/phy/phy-core.c:848:13: error: implicit declaration of function
> ‘of_get_next_parent’ [-Werror=implicit-function-declaration]
>     parent = of_get_next_parent(parent);
>                  ^
> 
> Fixes: 2f7600bc981c ("phy: core: Allow children node to be overridden")
> Signed-off-by: Heikki Krogerus <heikki.krogerus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>

Yes, this works. I have submitted an alternative patch to fix the
build error, changing the PHY core to not use any of the OF interfaces
if CONFIG_OF is disabled.

We can also have both.

Acked-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] of: Add stub for of_get_next_parent()

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 1563 bytes --]

On Wed, Apr 27, 2016 at 01:13:33PM +0200, Arnd Bergmann wrote:
> On Wednesday 27 April 2016 14:11:40 Heikki Krogerus wrote:
> > Fixes a compiler error:
> > 
> > drivers/phy/phy-core.c: In function ‘__of_phy_provider_register’:
> > drivers/phy/phy-core.c:848:13: error: implicit declaration of function
> > ‘of_get_next_parent’ [-Werror=implicit-function-declaration]
> >     parent = of_get_next_parent(parent);
> >                  ^
> > 
> > Fixes: 2f7600bc981c ("phy: core: Allow children node to be overridden")
> > Signed-off-by: Heikki Krogerus <heikki.krogerus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> 
> Yes, this works. I have submitted an alternative patch to fix the
> build error, changing the PHY core to not use any of the OF interfaces
> if CONFIG_OF is disabled.
> 
> We can also have both.
> 
> Acked-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>

I'm thinking of simply open-coding this for now, to avoid the use of
of_get_next_parent(). This is part of a set of patches that has gone
through countless revisions over the past two years and the timing
is such that adding yet another dependency will likely make it miss
the next cycle again. I'd really like to avoid that.

If nobody objects I'll volunteer to refactor this after v4.7-rc1.

Alternatively, perhaps Rob can give a very quick Acked-by on the
of_get_next_parent() addition, then I might still have time to take
this through one or two linux-next releases before sending out the
pull requests around the end of the week.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]