Re: [PATCH 1/2] ASoC: pcm5102a: Add support for PCM5102A codec

[Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

On Fri, May 13, 2016 at 09:14:12AM +0000, kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org wrote:
> From: Florian Meier <florian.meier-oZ8rN/sblLk@public.gmane.org>
> 
> Some definitions to support the PCM5102A codec
> by Texas Instruments.
> 
> Signed-off-by: Florian Meier <florian.meier-oZ8rN/sblLk@public.gmane.org>
> 
> Changes to original patch by Florian Meier:
> * rebased (Makefile and Kconfig
> * fixed checkpath errors (spaces, newlines)
> * added dt-binding documentation
> 
> Signed-off-by: Martin Sperl <kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
> ---
>  .../devicetree/bindings/sound/pcm5102a.txt         | 13 ++++
>  sound/soc/codecs/Kconfig                           |  4 ++
>  sound/soc/codecs/Makefile                          |  2 +
>  sound/soc/codecs/pcm5102a.c                        | 69 ++++++++++++++++++++++
>  4 files changed, 88 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/pcm5102a.txt
>  create mode 100644 sound/soc/codecs/pcm5102a.c
> 
> diff --git a/Documentation/devicetree/bindings/sound/pcm5102a.txt b/Documentation/devicetree/bindings/sound/pcm5102a.txt
> new file mode 100644
> index 0000000..c63ab0b6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/pcm5102a.txt
> @@ -0,0 +1,13 @@
> +PCM5102a audio CODECs
> +
> +These devices does not use I2C or SPI.

s/does/do/ or singular device.

What do they use? Describe the interface (or lack of), not 2 possible 
interfaces that it doesn't have.

> +
> +Required properties:
> +
> +  - compatible : set as "ti,pcm5102a"
> +
> +Examples:
> +
> +	pcm5102a: pcm5102a {
> +		compatible = "ti,pcm5102a";
> +	};
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html