From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: "Emmanuel Fusté"
<emmanuel.fuste-QFKgK+z4sOrR7s880joybQ@public.gmane.org>
Cc: kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Jaroslav Kysela <perex-/Fr2/VpizcU@public.gmane.org>,
Takashi Iwai <tiwai-IBi9RG/b67k@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Matthias Reichl <hias-vtPv7MOkFPkAvxtiuMwx3w@public.gmane.org>,
Florian Meier <florian.meier-oZ8rN/sblLk@public.gmane.org>
Subject: Re: [alsa-devel] [PATCH 1/2] ASoC: pcm5102a: Add support for PCM5102A codec
Date: Mon, 23 May 2016 18:08:53 +0100 [thread overview]
Message-ID: <20160523170853.GB8206@sirena.org.uk> (raw)
In-Reply-To: <34ab107e-10dc-fbd3-28d1-203c6411851c-QFKgK+z4sOrR7s880joybQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 792 bytes --]
On Sun, May 22, 2016 at 11:29:55PM +0200, Emmanuel Fusté wrote:
> There is nothing PCM5102A specific here, and it is pretty generic.
> Wouldn't it be better to write instead a simple-i2s-codec for all the
> classics I2S "hifi" DACs which will get the I2S/DAI parameters from DT ?
> PCM510x, PCM5122 in HW mode, ES9023, a bunch of ES90xx implementations
> etc... will use exactly the same code with only format and rate variation.
> And for the rate, it is implementation dependent, even in the case of
> pcm5102a.
If we do that then we have no idea what the hardware actually is and
we're creating more effort on the DT side, the DT has to specify all
the parameters for the device rather than just the name. Given how
trivial the code is it's not clear that this is a win.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-05-23 17:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 9:14 [PATCH 0/2] ASoC: bcm2835: add support for hifiberry-dac kernel-TqfNSX0MhmxHKSADF0wUEw
[not found] ` <1463130853-25096-1-git-send-email-kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
2016-05-13 9:14 ` [PATCH 1/2] ASoC: pcm5102a: Add support for PCM5102A codec kernel-TqfNSX0MhmxHKSADF0wUEw
[not found] ` <1463130853-25096-2-git-send-email-kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
2016-05-16 16:26 ` Rob Herring
2016-05-22 21:29 ` [alsa-devel] " Emmanuel Fusté
[not found] ` <34ab107e-10dc-fbd3-28d1-203c6411851c-QFKgK+z4sOrR7s880joybQ@public.gmane.org>
2016-05-23 17:08 ` Mark Brown [this message]
[not found] ` <20160523170853.GB8206-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-05-23 20:37 ` Emmanuel Fusté
[not found] ` <312f8476-a437-04d9-3d16-38d7c7c233ad-QFKgK+z4sOrR7s880joybQ@public.gmane.org>
2016-05-23 22:29 ` Mark Brown
2016-05-24 14:44 ` Ricard Wanderlof
2016-05-24 22:33 ` Emmanuel Fusté
2016-05-13 9:14 ` [PATCH 2/2] ASoC: Add support for HifiBerry DAC kernel-TqfNSX0MhmxHKSADF0wUEw
[not found] ` <1463130853-25096-3-git-send-email-kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
2016-05-13 10:54 ` Mark Brown
[not found] ` <20160513105409.GB22038-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-05-13 12:20 ` Martin Sperl
[not found] ` <C139252A-23AC-4C37-A5E5-E0D7AF1DCC89-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
2016-05-13 13:21 ` Mark Brown
2016-05-13 16:21 ` Martin Sperl
[not found] ` <20160513132113.GP22038-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-05-20 12:28 ` kernel-TqfNSX0MhmxHKSADF0wUEw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160523170853.GB8206@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=emmanuel.fuste-QFKgK+z4sOrR7s880joybQ@public.gmane.org \
--cc=florian.meier-oZ8rN/sblLk@public.gmane.org \
--cc=hias-vtPv7MOkFPkAvxtiuMwx3w@public.gmane.org \
--cc=kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org \
--cc=linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=perex-/Fr2/VpizcU@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=tiwai-IBi9RG/b67k@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox