[PATCH RFT 4/4] ARM: dts: imx28-tx28: fix dtc warning

public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed

* [PATCH RFT 4/4] ARM: dts: imx28-tx28: fix dtc warning
@ 2016-06-05 13:52 Stefan Wahren
       [not found] ` <1465134747-13536-1-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org>
  0 siblings, 1 reply; 4+ messages in thread
From: Stefan Wahren @ 2016-06-05 13:52 UTC (permalink / raw)
  To: Shawn Guo, Sascha Hauer
  Cc: Mark Rutland, Pawel Moll, Ian Campbell, Rob Herring,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA, Lothar Waßmann,
	Stefan Wahren

This fixes the following dtc warning by removing the unnecessary unit:

Warning (unit_address_vs_reg): Node /matrix-keypad@0 has a unit name,
but no reg property

Signed-off-by: Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org>
---
 arch/arm/boot/dts/imx28-tx28.dts |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
index fd20e99..0ebbc83 100644
--- a/arch/arm/boot/dts/imx28-tx28.dts
+++ b/arch/arm/boot/dts/imx28-tx28.dts
@@ -173,7 +173,7 @@
 		default-brightness-level = <50>;
 	};
 
-	matrix_keypad: matrix-keypad@0 {
+	matrix_keypad: matrix-keypad {
 		compatible = "gpio-matrix-keypad";
 		col-gpios = <
 			&gpio5 0 GPIO_ACTIVE_HIGH
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 4+ messages in thread

[parent not found: <1465134747-13536-1-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org>]

* Re: [PATCH RFT 4/4] ARM: dts: imx28-tx28: fix dtc warning
       [not found] ` <1465134747-13536-1-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org>
@ 2016-06-05 14:05   ` Fabio Estevam
       [not found]     ` <CAOMZO5DFYg2t44wEdUF+UWhTeDEMMWnjjaQDwLztMAW5Q8UnwA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  2016-06-06  6:33   ` Lothar Waßmann
  1 sibling, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2016-06-05 14:05 UTC (permalink / raw)
  To: Stefan Wahren
  Cc: Shawn Guo, Sascha Hauer, Mark Rutland, Pawel Moll, Ian Campbell,
	Rob Herring,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Lothar Waßmann, Marek Vašut

On Sun, Jun 5, 2016 at 10:52 AM, Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org> wrote:
> This fixes the following dtc warning by removing the unnecessary unit:
>
> Warning (unit_address_vs_reg): Node /matrix-keypad@0 has a unit name,
> but no reg property
>
> Signed-off-by: Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org>
> ---
>  arch/arm/boot/dts/imx28-tx28.dts |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
> index fd20e99..0ebbc83 100644
> --- a/arch/arm/boot/dts/imx28-tx28.dts
> +++ b/arch/arm/boot/dts/imx28-tx28.dts
> @@ -173,7 +173,7 @@
>                 default-brightness-level = <50>;
>         };
>
> -       matrix_keypad: matrix-keypad@0 {
> +       matrix_keypad: matrix-keypad {
>                 compatible = "gpio-matrix-keypad";
>                 col-gpios = <
>                         &gpio5 0 GPIO_ACTIVE_HIGH

Looks good. Adding Marek on Cc.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

[parent not found: <CAOMZO5DFYg2t44wEdUF+UWhTeDEMMWnjjaQDwLztMAW5Q8UnwA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]

* Re: [PATCH RFT 4/4] ARM: dts: imx28-tx28: fix dtc warning
       [not found]     ` <CAOMZO5DFYg2t44wEdUF+UWhTeDEMMWnjjaQDwLztMAW5Q8UnwA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2016-06-05 14:21       ` Fabio Estevam
  0 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2016-06-05 14:21 UTC (permalink / raw)
  To: Stefan Wahren
  Cc: Shawn Guo, Sascha Hauer, Mark Rutland, Pawel Moll, Ian Campbell,
	Rob Herring,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Lothar Waßmann, Marek Vašut

On Sun, Jun 5, 2016 at 11:05 AM, Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:

> Looks good. Adding Marek on Cc.

Ops, this is Lothar's board not Marek's :-)
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH RFT 4/4] ARM: dts: imx28-tx28: fix dtc warning
       [not found] ` <1465134747-13536-1-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org>
  2016-06-05 14:05   ` Fabio Estevam
@ 2016-06-06  6:33   ` Lothar Waßmann
  1 sibling, 0 replies; 4+ messages in thread
From: Lothar Waßmann @ 2016-06-06  6:33 UTC (permalink / raw)
  To: Stefan Wahren
  Cc: Shawn Guo, Sascha Hauer, Mark Rutland, Pawel Moll, Ian Campbell,
	Rob Herring, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA

Hi,

On Sun,  5 Jun 2016 13:52:27 +0000 Stefan Wahren wrote:
> This fixes the following dtc warning by removing the unnecessary unit:
> 
> Warning (unit_address_vs_reg): Node /matrix-keypad@0 has a unit name,
> but no reg property
> 
> Signed-off-by: Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org>
> ---
>  arch/arm/boot/dts/imx28-tx28.dts |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
> index fd20e99..0ebbc83 100644
> --- a/arch/arm/boot/dts/imx28-tx28.dts
> +++ b/arch/arm/boot/dts/imx28-tx28.dts
> @@ -173,7 +173,7 @@
>  		default-brightness-level = <50>;
>  	};
>  
> -	matrix_keypad: matrix-keypad@0 {
> +	matrix_keypad: matrix-keypad {
>  		compatible = "gpio-matrix-keypad";
>  		col-gpios = <
>  			&gpio5 0 GPIO_ACTIVE_HIGH
>
Acked-By: Lothar Waßmann <LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>


Lothar Waßmann
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-06-06  6:33 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-05 13:52 [PATCH RFT 4/4] ARM: dts: imx28-tx28: fix dtc warning Stefan Wahren
     [not found] ` <1465134747-13536-1-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org>
2016-06-05 14:05   ` Fabio Estevam
     [not found]     ` <CAOMZO5DFYg2t44wEdUF+UWhTeDEMMWnjjaQDwLztMAW5Q8UnwA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-06-05 14:21       ` Fabio Estevam
2016-06-06  6:33   ` Lothar Waßmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox