From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>
Cc: Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>,
Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH 8/8] arm64: dts: allwinner: add PWM node to A64 dtsi
Date: Wed, 8 Feb 2017 11:17:40 +0100 [thread overview]
Message-ID: <20170208101740.l6az2ck3zm4kaplq@lukather> (raw)
In-Reply-To: <20170208100009.29362-8-icenowy-ymACFijhrKM@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1041 bytes --]
On Wed, Feb 08, 2017 at 06:00:09PM +0800, Icenowy Zheng wrote:
> Allwinner A64 has also a PWM controller on PD22 (not available on
> Pine64, because it's muxed with EMAC, but it's used on Olimex TERES
> laptop kit to adjust the screen backlight).
>
> Add a device node for it.
>
> Signed-off-by: Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>
> ---
> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> index 6e34f5adcf06..078322fb5d58 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> @@ -296,6 +296,14 @@
> };
> };
>
> + pwm: pwm@1c21400 {
> + compatible = "allwinner,sun8i-h3-pwm";
> + reg = <0x01c21400 0x8>;
Same thing here, the size is wrong, and you need a new compatible.
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-02-08 10:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 10:00 [PATCH 1/8] dt-bindings: fix for Allwinner H5 pinctrl's compatible Icenowy Zheng
[not found] ` <20170208100009.29362-1-icenowy-ymACFijhrKM@public.gmane.org>
2017-02-08 10:00 ` [PATCH 2/8] dt: bindings: add binding for Allwinner A64 R_PIO pinctrl Icenowy Zheng
[not found] ` <20170208100009.29362-2-icenowy-ymACFijhrKM@public.gmane.org>
2017-02-13 15:06 ` Chen-Yu Tsai
2017-02-08 10:00 ` [PATCH 3/8] pinctrl: sunxi: Add A64 R_PIO controller support Icenowy Zheng
[not found] ` <20170208100009.29362-3-icenowy-ymACFijhrKM@public.gmane.org>
2017-02-13 14:52 ` Linus Walleij
2017-02-13 15:09 ` Chen-Yu Tsai
2017-02-08 10:00 ` [PATCH 4/8] arm64: allwinner: select A64 R_PIO driver Icenowy Zheng
2017-02-08 10:00 ` [PATCH 5/8] arm64: dts: allwinner: add R_PIO node Icenowy Zheng
[not found] ` <20170208100009.29362-5-icenowy-ymACFijhrKM@public.gmane.org>
2017-02-08 10:14 ` Maxime Ripard
2017-02-08 11:08 ` Icenowy Zheng
[not found] ` <39431486552126-4vD9JDEoAAxxpj1cXAZ9Bg@public.gmane.org>
2017-02-10 8:07 ` Maxime Ripard
2017-02-08 10:00 ` [PATCH 6/8] arm64: dts: allwinner: add device node for R_PWM Icenowy Zheng
[not found] ` <20170208100009.29362-6-icenowy-ymACFijhrKM@public.gmane.org>
2017-02-08 10:17 ` Maxime Ripard
2017-02-08 10:00 ` [PATCH 7/8] arm64: dts: allwinner: add pinmux for A64's r_pwm Icenowy Zheng
2017-02-08 10:00 ` [PATCH 8/8] arm64: dts: allwinner: add PWM node to A64 dtsi Icenowy Zheng
[not found] ` <20170208100009.29362-8-icenowy-ymACFijhrKM@public.gmane.org>
2017-02-08 10:17 ` Maxime Ripard [this message]
2017-02-13 15:04 ` [PATCH 1/8] dt-bindings: fix for Allwinner H5 pinctrl's compatible Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170208101740.l6az2ck3zm4kaplq@lukather \
--to=maxime.ripard-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
--cc=catalin.marinas-5wv7dgnIgG8@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=icenowy-ymACFijhrKM@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=wens-jdAy2FN1RRM@public.gmane.org \
--cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox