[PATCH] ARM: dts: at91: use correct compatible for the gpio mux controller

[PATCH] ARM: dts: at91: use correct compatible for the gpio mux controller

[Peter Rosin]

The compatible string for a gpio based mux controller is "gpio-mux",
and nothing else.

Fixes: 29dd89418007 ("ARM: dts: at91: add envelope detector mux to the Axentia TSE-850")
Signed-off-by: Peter Rosin <peda@axentia.se>
---
 arch/arm/boot/dts/at91-tse850-3.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Hi!

The compatible string for the gpio based mux changed along the way (on
request from Rob) but I failed to update the implementation in the
gpio-mux driver when I made that change. Consequently, I didn't notice
that I didn't update the compatible string here either, since it all
continued to work in my tests...

The compatible string in the gpio-mux driver is being fixed to match
documentation, so this of course needs fixing too. No TSE-850 devices
are affected, except for the one on my desk.

Sorry for the churn.

Cheers,
peda

diff --git a/arch/arm/boot/dts/at91-tse850-3.dts b/arch/arm/boot/dts/at91-tse850-3.dts
index 6a724cfb5389..168665e56a56 100644
--- a/arch/arm/boot/dts/at91-tse850-3.dts
+++ b/arch/arm/boot/dts/at91-tse850-3.dts
@@ -204,7 +204,7 @@
 	};
 
 	mux: mux-controller {
-		compatible = "mux-gpio";
+		compatible = "gpio-mux";
 		#mux-control-cells = <0>;
 
 		mux-gpios = <&pioA 0 GPIO_ACTIVE_HIGH>,
-- 
2.1.4

Re: [PATCH] ARM: dts: at91: use correct compatible for the gpio mux controller

[Alexandre Belloni]

On 13/04/2017 at 23:22:58 +0200, Peter Rosin wrote:
> The compatible string for a gpio based mux controller is "gpio-mux",
> and nothing else.
> 
> Fixes: 29dd89418007 ("ARM: dts: at91: add envelope detector mux to the Axentia TSE-850")
> Signed-off-by: Peter Rosin <peda-koto5C5qi+TLoDKTGw+V6w@public.gmane.org>
> ---
>  arch/arm/boot/dts/at91-tse850-3.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Hi!
> 
> The compatible string for the gpio based mux changed along the way (on
> request from Rob) but I failed to update the implementation in the
> gpio-mux driver when I made that change. Consequently, I didn't notice
> that I didn't update the compatible string here either, since it all
> continued to work in my tests...
> 
> The compatible string in the gpio-mux driver is being fixed to match
> documentation, so this of course needs fixing too. No TSE-850 devices
> are affected, except for the one on my desk.
> 
> Sorry for the churn.
> 

So, I folded that one in the previous one and updated my pull request.
Hopefully this will be OK.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: dts: at91: use correct compatible for the gpio mux controller

[Peter Rosin]

[-- Attachment #1: Type: text/plain, Size: 1441 bytes --]



On April 14, 2017 12:07:05 PM GMT+02:00, Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:
>On 13/04/2017 at 23:22:58 +0200, Peter Rosin wrote:
>> The compatible string for a gpio based mux controller is "gpio-mux",
>> and nothing else.
>> 
>> Fixes: 29dd89418007 ("ARM: dts: at91: add envelope detector mux to
>the Axentia TSE-850")
>> Signed-off-by: Peter Rosin <peda@axentia.se>
>> ---
>>  arch/arm/boot/dts/at91-tse850-3.dts | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> Hi!
>> 
>> The compatible string for the gpio based mux changed along the way
>(on
>> request from Rob) but I failed to update the implementation in the
>> gpio-mux driver when I made that change. Consequently, I didn't
>notice
>> that I didn't update the compatible string here either, since it all
>> continued to work in my tests...
>> 
>> The compatible string in the gpio-mux driver is being fixed to match
>> documentation, so this of course needs fixing too. No TSE-850 devices
>> are affected, except for the one on my desk.
>> 
>> Sorry for the churn.
>> 
>
>So, I folded that one in the previous one and updated my pull request.
>Hopefully this will be OK.
>
>-- 
>Alexandre Belloni, Free Electrons
>Embedded Linux and Kernel engineering
>http://free-electrons.com

From my POV, excellent!

Cheers,
peda

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

[-- Attachment #2: Type: text/html, Size: 1813 bytes --]