Devicetree
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Luis Oliveira <Luis.Oliveira@synopsys.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Jarkko Nikula <jarkko.nikula@linux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	linux-i2c <linux-i2c@vger.kernel.org>,
	devicetree <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Ramiro Oliveira <Ramiro.Oliveira@synopsys.com>,
	Joao Pinto <Joao.Pinto@synopsys.com>,
	CARLOS.PALMINHA@synopsys.com
Subject: Re: [PATCH v11 5/6] i2c: designware: add SLAVE mode functions
Date: Mon, 19 Jun 2017 17:58:58 +0200	[thread overview]
Message-ID: <20170619155858.xjs5nvdkg42b73vg@ninjato> (raw)
In-Reply-To: <6e332d71-1891-21aa-4479-b91a7550f8af@synopsys.com>

[-- Attachment #1: Type: text/plain, Size: 659 bytes --]

Hiya,

> Believe me I've looked for mistakes like this but I've read the code so many
> times I don't think I can see the obvious anymore.

Yes, I know this. And you worked hard on this slave feature,
acknowledged.

Patches 1-4 look good to me from what I glimpsed. I largely trust here
the *much* appreciated review from Jarkko and Andy. Thanks a lot, guys!

I wonder if we haven't reached a state where Luis just could fix the
buildbot error (missing 'select I2C_SLAVE') and the thing pointed out by
Andy and we handle further small fixes incrementally during the v4.13
cycle? AFAICS there is no major show-stopper, or am I wrong?

Thanks guys,

   Wolfram

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2017-06-19 15:58 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-14 10:43 [PATCH v11 0/6] i2c: designware: add I2C SLAVE support Luis Oliveira
     [not found] ` <cover.1497025304.git.lolivei-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2017-06-14 10:43   ` [PATCH v11 1/6] i2c: designware: Cleaning and comment style fixes Luis Oliveira
2017-06-19 16:26     ` Wolfram Sang
2017-06-14 10:43 ` [PATCH v11 2/6] i2c: designware: refactoring of the i2c-designware Luis Oliveira
2017-06-19 16:26   ` Wolfram Sang
2017-06-14 10:43 ` [PATCH v11 3/6] i2c: designware: MASTER mode as separated driver Luis Oliveira
2017-06-19 16:26   ` Wolfram Sang
2017-06-14 10:43 ` [PATCH v11 4/6] i2c: designware: introducing I2C_SLAVE definitions Luis Oliveira
2017-06-19 16:27   ` Wolfram Sang
2017-06-14 10:43 ` [PATCH v11 5/6] i2c: designware: add SLAVE mode functions Luis Oliveira
     [not found]   ` <bef9f237bed23f0ea05499b085103f7eea9058a1.1497025304.git.lolivei-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2017-06-14 12:20     ` Andy Shevchenko
2017-06-14 13:06       ` Luis Oliveira
2017-06-19 15:58         ` Wolfram Sang [this message]
2017-06-19 16:05           ` Andy Shevchenko
2017-06-19 16:10             ` Luis Oliveira
     [not found]             ` <CAHp75VfpgOZ72=5F3aN_tfau3TnyGLsdKt=sdx_ZJ04wtxMtJg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-06-19 16:22               ` Wolfram Sang
2017-06-20  8:03                 ` Jarkko Nikula
2017-06-18  4:53     ` kbuild test robot
2017-06-14 10:43 ` [PATCH v11 6/6] i2c: designware: enable SLAVE in platform module Luis Oliveira
2017-06-14 12:21   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170619155858.xjs5nvdkg42b73vg@ninjato \
    --to=wsa@the-dreams.de \
    --cc=CARLOS.PALMINHA@synopsys.com \
    --cc=Joao.Pinto@synopsys.com \
    --cc=Luis.Oliveira@synopsys.com \
    --cc=Ramiro.Oliveira@synopsys.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox