Devicetree
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Luis Oliveira <Luis.Oliveira@synopsys.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
	jarkko.nikula@linux.intel.com, andriy.shevchenko@linux.intel.com,
	mika.westerberg@linux.intel.com, linux-i2c@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Ramiro.Oliveira@synopsys.com, Joao.Pinto@synopsys.com,
	CARLOS.PALMINHA@synopsys.com
Subject: Re: [PATCH v11 1/6] i2c: designware: Cleaning and comment style fixes.
Date: Mon, 19 Jun 2017 18:26:50 +0200	[thread overview]
Message-ID: <20170619162650.nxshcsevyu5pk5vj@ninjato> (raw)
In-Reply-To: <ad57f66b8deef7065d53bed02e3e992748ff315d.1497025304.git.lolivei@synopsys.com>

[-- Attachment #1: Type: text/plain, Size: 1049 bytes --]

On Wed, Jun 14, 2017 at 11:43:21AM +0100, Luis Oliveira wrote:
> The purpose of this commit is to fix some comments and styling in the
> existing code due to the need of reuse this code. What is being made
> here is:
> 
> - Sorted the headers files
> - Corrected some comments style (capital letters, lowcase i2c)
> - Reverse tree in the variables declaration
> - Add/remove empty lines and tabs where needed
> - Fix of misspelled word "endianness" and "transferred"
> - Replaced the return variable "r" with the more standard "ret"
> 
> The value of this, besides the rules of coding style, is because I
> will use this code after and it will make my future patch a lot bigger and
> complicated to review. The work here won't bring any additional work to
> backported fixes because is just style and reordering.
> 
> Signed-off-by: Luis Oliveira <lolivei@synopsys.com>
> Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Applied to for-next, thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2017-06-19 16:26 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-14 10:43 [PATCH v11 0/6] i2c: designware: add I2C SLAVE support Luis Oliveira
     [not found] ` <cover.1497025304.git.lolivei-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2017-06-14 10:43   ` [PATCH v11 1/6] i2c: designware: Cleaning and comment style fixes Luis Oliveira
2017-06-19 16:26     ` Wolfram Sang [this message]
2017-06-14 10:43 ` [PATCH v11 2/6] i2c: designware: refactoring of the i2c-designware Luis Oliveira
2017-06-19 16:26   ` Wolfram Sang
2017-06-14 10:43 ` [PATCH v11 3/6] i2c: designware: MASTER mode as separated driver Luis Oliveira
2017-06-19 16:26   ` Wolfram Sang
2017-06-14 10:43 ` [PATCH v11 4/6] i2c: designware: introducing I2C_SLAVE definitions Luis Oliveira
2017-06-19 16:27   ` Wolfram Sang
2017-06-14 10:43 ` [PATCH v11 5/6] i2c: designware: add SLAVE mode functions Luis Oliveira
     [not found]   ` <bef9f237bed23f0ea05499b085103f7eea9058a1.1497025304.git.lolivei-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2017-06-14 12:20     ` Andy Shevchenko
2017-06-14 13:06       ` Luis Oliveira
2017-06-19 15:58         ` Wolfram Sang
2017-06-19 16:05           ` Andy Shevchenko
2017-06-19 16:10             ` Luis Oliveira
     [not found]             ` <CAHp75VfpgOZ72=5F3aN_tfau3TnyGLsdKt=sdx_ZJ04wtxMtJg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-06-19 16:22               ` Wolfram Sang
2017-06-20  8:03                 ` Jarkko Nikula
2017-06-18  4:53     ` kbuild test robot
2017-06-14 10:43 ` [PATCH v11 6/6] i2c: designware: enable SLAVE in platform module Luis Oliveira
2017-06-14 12:21   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170619162650.nxshcsevyu5pk5vj@ninjato \
    --to=wsa@the-dreams.de \
    --cc=CARLOS.PALMINHA@synopsys.com \
    --cc=Joao.Pinto@synopsys.com \
    --cc=Luis.Oliveira@synopsys.com \
    --cc=Ramiro.Oliveira@synopsys.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox