From: Rob Herring <robh@kernel.org>
To: Varadarajan Narayanan <varada@codeaurora.org>
Cc: broonie@kernel.org, mark.rutland@arm.com, andy.gross@linaro.org,
david.brown@linaro.org, linux-spi@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
Abhishek Sahu <absahu@codeaurora.org>
Subject: Re: [PATCH v3 15/15] spi: qup: support for qup v1 dma
Date: Fri, 23 Jun 2017 16:49:23 -0500 [thread overview]
Message-ID: <20170623214923.ratchkoay73ytlv3@rob-hp-laptop> (raw)
In-Reply-To: <1497949857-1852-16-git-send-email-varada@codeaurora.org>
On Tue, Jun 20, 2017 at 02:40:57PM +0530, Varadarajan Narayanan wrote:
> Currently the QUP Version v1 does not work with DMA so added
> the support for the same.
>
> 1. It uses ADM DMA which requires TX and RX CRCI
> 2. DMA channel initialization need to be done after setting
> block size for having valid values in maxburst
> 3. QUP mode should be DMOV instead of BAM.
>
> Signed-off-by: Abhishek Sahu <absahu@codeaurora.org>
> Signed-off-by: Varadarajan Narayanan <varada@codeaurora.org>
> ---
> .../devicetree/bindings/spi/qcom,spi-qup.txt | 6 ++++
> drivers/spi/spi-qup.c | 35 +++++++++++++++++-----
> 2 files changed, 34 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-qup.txt b/Documentation/devicetree/bindings/spi/qcom,spi-qup.txt
> index 5c09077..e754181 100644
> --- a/Documentation/devicetree/bindings/spi/qcom,spi-qup.txt
> +++ b/Documentation/devicetree/bindings/spi/qcom,spi-qup.txt
> @@ -38,6 +38,12 @@ Optional properties:
> - dma-names: Names for the dma channels, if present. There must be at
> least one channel named "tx" for transmit and named "rx" for
> receive.
> +- qcom,tx-crci: Identificator for Client Rate Control Interface (CRCI) to be
Identificator is not a word.
This sounds like something that should be a cell in the dmas property.
> + used with TX DMA channel. Required when using DMA for
> + transmission with QUP Version 1 i.e qcom,spi-qup-v1.1.1.
> +- qcom,rx-crci: Identificator for Client Rate Control Interface (CRCI) to be
> + used with RX DMA channel. Required when using DMA for
> + receiving with QUP Version 1 i.e qcom,spi-qup-v1.1.1.
>
> SPI slave nodes must be children of the SPI master node and can contain
> properties described in Documentation/devicetree/bindings/spi/spi-bus.txt
next prev parent reply other threads:[~2017-06-23 21:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 9:10 [PATCH v3 00/15] spi: qup: Fixes and add support for >64k transfers Varadarajan Narayanan
2017-06-20 9:10 ` [PATCH v3 01/15] spi: qup: Enable chip select support Varadarajan Narayanan
2017-06-20 9:10 ` [PATCH v3 02/15] spi: qup: Setup DMA mode correctly Varadarajan Narayanan
2017-06-20 9:10 ` [PATCH v3 03/15] spi: qup: Add completion structures for DMA Varadarajan Narayanan
2017-06-20 9:10 ` [PATCH v3 05/15] spi: qup: Place the QUP in run mode before DMA Varadarajan Narayanan
2017-06-20 9:10 ` [PATCH v3 06/15] spi: qup: Fix error handling in spi_qup_prep_sg Varadarajan Narayanan
2017-06-20 9:10 ` [PATCH v3 07/15] spi: qup: Fix transaction done signaling Varadarajan Narayanan
2017-08-08 11:18 ` Applied "spi: qup: Fix transaction done signaling" to the spi tree Mark Brown
2017-06-20 9:10 ` [PATCH v3 08/15] spi: qup: Do block sized read/write in block mode Varadarajan Narayanan
2017-06-20 9:10 ` [PATCH v3 09/15] spi: qup: refactor spi_qup_io_config into two functions Varadarajan Narayanan
2017-06-20 9:10 ` [PATCH v3 10/15] spi: qup: call io_config in mode specific function Varadarajan Narayanan
2017-06-20 9:10 ` [PATCH v3 11/15] spi: qup: allow block mode to generate multiple transactions Varadarajan Narayanan
2017-06-20 9:10 ` [PATCH v3 12/15] spi: qup: refactor spi_qup_prep_sg Varadarajan Narayanan
[not found] ` <1497949857-1852-1-git-send-email-varada-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-06-20 9:10 ` [PATCH v3 04/15] spi: qup: Add completion timeout Varadarajan Narayanan
2017-06-20 9:10 ` [PATCH v3 13/15] spi: qup: allow multiple DMA transactions per spi xfer Varadarajan Narayanan
2017-06-20 9:10 ` [PATCH v3 14/15] spi: qup: Ensure done detection Varadarajan Narayanan
2017-06-20 9:10 ` [PATCH v3 15/15] spi: qup: support for qup v1 dma Varadarajan Narayanan
2017-06-23 21:49 ` Rob Herring [this message]
2017-06-27 9:36 ` Varadarajan Narayanan
2017-06-28 6:47 ` Andy Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170623214923.ratchkoay73ytlv3@rob-hp-laptop \
--to=robh@kernel.org \
--cc=absahu@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=broonie@kernel.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=varada@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox