From: Rob Herring <robh@kernel.org>
To: Aleksandar Markovic <aleksandar.markovic@rt-rk.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
linux-mips@linux-mips.org, Raghu Gandham <raghu.gandham@mips.com>,
Aleksandar Markovic <aleksandar.markovic@mips.com>,
devicetree@vger.kernel.org, Goran Ferenc <goran.ferenc@mips.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Paul Burton <paul.burton@mips.com>,
Petar Jovanovic <petar.jovanovic@mips.com>,
Miodrag Dinic <miodrag.dinic@mips.com>,
James Hogan <james.hogan@mips.com>,
Douglas Leung <douglas.leung@mips.com>
Subject: Re: [PATCH v5 3/5] Documentation: Add device tree binding for Goldfish FB driver
Date: Thu, 26 Oct 2017 22:10:56 -0500 [thread overview]
Message-ID: <20171027031056.scmky5n5vbbnldmc@rob-hp-laptop> (raw)
In-Reply-To: <1508510055-6167-4-git-send-email-aleksandar.markovic@rt-rk.com>
On Fri, Oct 20, 2017 at 04:33:36PM +0200, Aleksandar Markovic wrote:
> From: Aleksandar Markovic <aleksandar.markovic@mips.com>
>
> Add documentation for DT binding of Goldfish FB driver. The compatible
> string used by OS for binding the driver is "google,goldfish-fb".
>
> Signed-off-by: Miodrag Dinic <miodrag.dinic@mips.com>
> Signed-off-by: Goran Ferenc <goran.ferenc@mips.com>
> Signed-off-by: Aleksandar Markovic <aleksandar.markovic@mips.com>
> ---
> .../devicetree/bindings/display/google,goldfish-fb.txt | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/google,goldfish-fb.txt
>
> diff --git a/Documentation/devicetree/bindings/display/google,goldfish-fb.txt b/Documentation/devicetree/bindings/display/google,goldfish-fb.txt
> new file mode 100644
> index 0000000..9ce0615
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/google,goldfish-fb.txt
> @@ -0,0 +1,18 @@
> +Android Goldfish framebuffer
> +
> +Android Goldfish framebuffer device used by Android emulator.
> +
> +Required properties:
> +
> +- compatible : should contain "google,goldfish-fb"
> +- reg : <registers mapping>
> +- interrupts : <interrupt mapping>
> +
> +Example:
> +
> + goldfish_fb@1f008000 {
Use generic node names:
display-controller@...
With that,
Acked-by: Rob Herring <robh@kernel.org>
> + compatible = "google,goldfish-fb";
> + interrupts = <0x10>;
> + reg = <0x1f008000 0x0 0x100>;
An address of one cell and size of 2 cells is strange...
> + compatible = "google,goldfish-fb";
> + };
> --
> 2.7.4
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2017-10-27 3:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1508510055-6167-1-git-send-email-aleksandar.markovic@rt-rk.com>
2017-10-20 14:33 ` [PATCH v5 1/5] Documentation: Add device tree binding for Goldfish PIC driver Aleksandar Markovic
2017-10-27 3:08 ` Rob Herring
2017-10-20 14:33 ` [PATCH v5 3/5] Documentation: Add device tree binding for Goldfish FB driver Aleksandar Markovic
2017-10-27 3:10 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171027031056.scmky5n5vbbnldmc@rob-hp-laptop \
--to=robh@kernel.org \
--cc=aleksandar.markovic@mips.com \
--cc=aleksandar.markovic@rt-rk.com \
--cc=devicetree@vger.kernel.org \
--cc=douglas.leung@mips.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=goran.ferenc@mips.com \
--cc=james.hogan@mips.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mark.rutland@arm.com \
--cc=miodrag.dinic@mips.com \
--cc=paul.burton@mips.com \
--cc=petar.jovanovic@mips.com \
--cc=raghu.gandham@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox