Devicetree
 help / color / mirror / Atom feed
* [PATCH v5 1/5] Documentation: Add device tree binding for Goldfish PIC driver
       [not found] <1508510055-6167-1-git-send-email-aleksandar.markovic@rt-rk.com>
@ 2017-10-20 14:33 ` Aleksandar Markovic
  2017-10-27  3:08   ` Rob Herring
  2017-10-20 14:33 ` [PATCH v5 3/5] Documentation: Add device tree binding for Goldfish FB driver Aleksandar Markovic
  1 sibling, 1 reply; 4+ messages in thread
From: Aleksandar Markovic @ 2017-10-20 14:33 UTC (permalink / raw)
  To: linux-mips
  Cc: Miodrag Dinic, Goran Ferenc, Aleksandar Markovic, David S. Miller,
	devicetree, Douglas Leung, Greg Kroah-Hartman, James Hogan,
	Jason Cooper, linux-kernel, Marc Zyngier, Mark Rutland,
	Mauro Carvalho Chehab, Paul Burton, Petar Jovanovic,
	Raghu Gandham, Randy Dunlap, Rob Herring, Thomas Gleixner

From: Miodrag Dinic <miodrag.dinic@mips.com>

Add documentation for DT binding of Goldfish PIC driver. The compatible
string used by OS for binding the driver is "google,goldfish-pic".

Signed-off-by: Miodrag Dinic <miodrag.dinic@mips.com>
Signed-off-by: Goran Ferenc <goran.ferenc@mips.com>
Signed-off-by: Aleksandar Markovic <aleksandar.markovic@mips.com>
---
 .../interrupt-controller/google,goldfish-pic.txt   | 30 ++++++++++++++++++++++
 MAINTAINERS                                        |  5 ++++
 2 files changed, 35 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/interrupt-controller/google,goldfish-pic.txt

diff --git a/Documentation/devicetree/bindings/interrupt-controller/google,goldfish-pic.txt b/Documentation/devicetree/bindings/interrupt-controller/google,goldfish-pic.txt
new file mode 100644
index 0000000..295bf97
--- /dev/null
+++ b/Documentation/devicetree/bindings/interrupt-controller/google,goldfish-pic.txt
@@ -0,0 +1,30 @@
+Android Goldfish PIC
+
+Android Goldfish programmable interrupt device used by Android
+emulator.
+
+Required properties:
+
+- compatible : should contain "google,goldfish-pic"
+- reg        : <registers mapping>
+- interrupts : <interrupt mapping>
+
+Example for mips when used in cascade mode:
+
+        cpuintc {
+                #interrupt-cells = <0x1>;
+                #address-cells = <0>;
+                interrupt-controller;
+                compatible = "mti,cpu-interrupt-controller";
+        };
+
+        goldfish_pic@1f000000 {
+                compatible = "google,goldfish-pic";
+                reg = <0x1f000000 0x0 0x1000>;
+
+                interrupt-controller;
+                #interrupt-cells = <0x1>;
+
+                interrupt-parent = <&cpuintc>;
+                interrupts = <0x2>;
+        };
diff --git a/MAINTAINERS b/MAINTAINERS
index 4a3de82..4d5108f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -872,6 +872,11 @@ S:	Supported
 F:	drivers/android/
 F:	drivers/staging/android/
 
+ANDROID GOLDFISH PIC DRIVER
+M:	Miodrag Dinic <miodrag.dinic@mips.com>
+S:	Supported
+F:	Documentation/devicetree/bindings/interrupt-controller/google,goldfish-pic.txt
+
 ANDROID GOLDFISH RTC DRIVER
 M:	Miodrag Dinic <miodrag.dinic@mips.com>
 S:	Supported
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v5 3/5] Documentation: Add device tree binding for Goldfish FB driver
       [not found] <1508510055-6167-1-git-send-email-aleksandar.markovic@rt-rk.com>
  2017-10-20 14:33 ` [PATCH v5 1/5] Documentation: Add device tree binding for Goldfish PIC driver Aleksandar Markovic
@ 2017-10-20 14:33 ` Aleksandar Markovic
  2017-10-27  3:10   ` Rob Herring
  1 sibling, 1 reply; 4+ messages in thread
From: Aleksandar Markovic @ 2017-10-20 14:33 UTC (permalink / raw)
  To: linux-mips
  Cc: Aleksandar Markovic, Miodrag Dinic, Goran Ferenc, David Airlie,
	devicetree, Douglas Leung, dri-devel, James Hogan, linux-kernel,
	Mark Rutland, Paul Burton, Petar Jovanovic, Raghu Gandham,
	Rob Herring

From: Aleksandar Markovic <aleksandar.markovic@mips.com>

Add documentation for DT binding of Goldfish FB driver. The compatible
string used by OS for binding the driver is "google,goldfish-fb".

Signed-off-by: Miodrag Dinic <miodrag.dinic@mips.com>
Signed-off-by: Goran Ferenc <goran.ferenc@mips.com>
Signed-off-by: Aleksandar Markovic <aleksandar.markovic@mips.com>
---
 .../devicetree/bindings/display/google,goldfish-fb.txt | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/google,goldfish-fb.txt

diff --git a/Documentation/devicetree/bindings/display/google,goldfish-fb.txt b/Documentation/devicetree/bindings/display/google,goldfish-fb.txt
new file mode 100644
index 0000000..9ce0615
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/google,goldfish-fb.txt
@@ -0,0 +1,18 @@
+Android Goldfish framebuffer
+
+Android Goldfish framebuffer device used by Android emulator.
+
+Required properties:
+
+- compatible : should contain "google,goldfish-fb"
+- reg        : <registers mapping>
+- interrupts : <interrupt mapping>
+
+Example:
+
+	goldfish_fb@1f008000 {
+		compatible = "google,goldfish-fb";
+		interrupts = <0x10>;
+		reg = <0x1f008000 0x0 0x100>;
+		compatible = "google,goldfish-fb";
+	};
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v5 1/5] Documentation: Add device tree binding for Goldfish PIC driver
  2017-10-20 14:33 ` [PATCH v5 1/5] Documentation: Add device tree binding for Goldfish PIC driver Aleksandar Markovic
@ 2017-10-27  3:08   ` Rob Herring
  0 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2017-10-27  3:08 UTC (permalink / raw)
  To: Aleksandar Markovic
  Cc: linux-mips, Miodrag Dinic, Goran Ferenc, Aleksandar Markovic,
	David S. Miller, devicetree, Douglas Leung, Greg Kroah-Hartman,
	James Hogan, Jason Cooper, linux-kernel, Marc Zyngier,
	Mark Rutland, Mauro Carvalho Chehab, Paul Burton, Petar Jovanovic,
	Raghu Gandham, Randy Dunlap, Thomas Gleixner

On Fri, Oct 20, 2017 at 04:33:34PM +0200, Aleksandar Markovic wrote:
> From: Miodrag Dinic <miodrag.dinic@mips.com>
> 
> Add documentation for DT binding of Goldfish PIC driver. The compatible
> string used by OS for binding the driver is "google,goldfish-pic".
> 
> Signed-off-by: Miodrag Dinic <miodrag.dinic@mips.com>
> Signed-off-by: Goran Ferenc <goran.ferenc@mips.com>
> Signed-off-by: Aleksandar Markovic <aleksandar.markovic@mips.com>
> ---
>  .../interrupt-controller/google,goldfish-pic.txt   | 30 ++++++++++++++++++++++
>  MAINTAINERS                                        |  5 ++++
>  2 files changed, 35 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/google,goldfish-pic.txt
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/google,goldfish-pic.txt b/Documentation/devicetree/bindings/interrupt-controller/google,goldfish-pic.txt
> new file mode 100644
> index 0000000..295bf97
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/google,goldfish-pic.txt
> @@ -0,0 +1,30 @@
> +Android Goldfish PIC
> +
> +Android Goldfish programmable interrupt device used by Android
> +emulator.
> +
> +Required properties:
> +
> +- compatible : should contain "google,goldfish-pic"
> +- reg        : <registers mapping>
> +- interrupts : <interrupt mapping>
> +
> +Example for mips when used in cascade mode:
> +
> +        cpuintc {
> +                #interrupt-cells = <0x1>;
> +                #address-cells = <0>;
> +                interrupt-controller;
> +                compatible = "mti,cpu-interrupt-controller";
> +        };
> +
> +        goldfish_pic@1f000000 {

interrupt-controller@...

With that,

Acked-by: Rob Herring <robh@kernel.org>

> +                compatible = "google,goldfish-pic";
> +                reg = <0x1f000000 0x0 0x1000>;
> +
> +                interrupt-controller;
> +                #interrupt-cells = <0x1>;
> +
> +                interrupt-parent = <&cpuintc>;
> +                interrupts = <0x2>;
> +        };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4a3de82..4d5108f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -872,6 +872,11 @@ S:	Supported
>  F:	drivers/android/
>  F:	drivers/staging/android/
>  
> +ANDROID GOLDFISH PIC DRIVER
> +M:	Miodrag Dinic <miodrag.dinic@mips.com>
> +S:	Supported
> +F:	Documentation/devicetree/bindings/interrupt-controller/google,goldfish-pic.txt
> +
>  ANDROID GOLDFISH RTC DRIVER
>  M:	Miodrag Dinic <miodrag.dinic@mips.com>
>  S:	Supported
> -- 
> 2.7.4
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v5 3/5] Documentation: Add device tree binding for Goldfish FB driver
  2017-10-20 14:33 ` [PATCH v5 3/5] Documentation: Add device tree binding for Goldfish FB driver Aleksandar Markovic
@ 2017-10-27  3:10   ` Rob Herring
  0 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2017-10-27  3:10 UTC (permalink / raw)
  To: Aleksandar Markovic
  Cc: Mark Rutland, linux-mips, Raghu Gandham, Aleksandar Markovic,
	devicetree, Goran Ferenc, dri-devel, linux-kernel, Paul Burton,
	Petar Jovanovic, Miodrag Dinic, James Hogan, Douglas Leung

On Fri, Oct 20, 2017 at 04:33:36PM +0200, Aleksandar Markovic wrote:
> From: Aleksandar Markovic <aleksandar.markovic@mips.com>
> 
> Add documentation for DT binding of Goldfish FB driver. The compatible
> string used by OS for binding the driver is "google,goldfish-fb".
> 
> Signed-off-by: Miodrag Dinic <miodrag.dinic@mips.com>
> Signed-off-by: Goran Ferenc <goran.ferenc@mips.com>
> Signed-off-by: Aleksandar Markovic <aleksandar.markovic@mips.com>
> ---
>  .../devicetree/bindings/display/google,goldfish-fb.txt | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/google,goldfish-fb.txt
> 
> diff --git a/Documentation/devicetree/bindings/display/google,goldfish-fb.txt b/Documentation/devicetree/bindings/display/google,goldfish-fb.txt
> new file mode 100644
> index 0000000..9ce0615
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/google,goldfish-fb.txt
> @@ -0,0 +1,18 @@
> +Android Goldfish framebuffer
> +
> +Android Goldfish framebuffer device used by Android emulator.
> +
> +Required properties:
> +
> +- compatible : should contain "google,goldfish-fb"
> +- reg        : <registers mapping>
> +- interrupts : <interrupt mapping>
> +
> +Example:
> +
> +	goldfish_fb@1f008000 {

Use generic node names:

display-controller@...

With that,

Acked-by: Rob Herring <robh@kernel.org>


> +		compatible = "google,goldfish-fb";
> +		interrupts = <0x10>;
> +		reg = <0x1f008000 0x0 0x100>;

An address of one cell and size of 2 cells is strange...

> +		compatible = "google,goldfish-fb";
> +	};
> -- 
> 2.7.4
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-10-27  3:10 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1508510055-6167-1-git-send-email-aleksandar.markovic@rt-rk.com>
2017-10-20 14:33 ` [PATCH v5 1/5] Documentation: Add device tree binding for Goldfish PIC driver Aleksandar Markovic
2017-10-27  3:08   ` Rob Herring
2017-10-20 14:33 ` [PATCH v5 3/5] Documentation: Add device tree binding for Goldfish FB driver Aleksandar Markovic
2017-10-27  3:10   ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox