From: Sergey Matyukevich <geomatsi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
Cc: Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-arm-kernel
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH 1/2] arm64: dts: orange-pi-zero-plus2: fix sdcard detect
Date: Sat, 4 Nov 2017 19:22:06 +0300 [thread overview]
Message-ID: <20171104162206.gowih7h7og3fk7rk@speedy.hunter> (raw)
In-Reply-To: <CAMty3ZCxXUaBf3t=3d7D+RU6rp83oJw8BHADU3TYDeM4Vx_k-w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
> > > The sdcard detect pin on orange-pi-zero-plus2 is pulled up.
> > > Fix cd-gpio description to enable sdcard detect.
> > >
> > > Signed-off-by: Sergey Matyukevich <geomatsi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > > ---
> > > arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus2.dts | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus2.dts
> b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus2.dts
> > > index b6b7a561df8c..a42fd79a62a3 100644
> > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus2.dts
> > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus2.dts
> > > @@ -71,7 +71,7 @@
> > > pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin>;
> > > vmmc-supply = <®_vcc3v3>;
> > > bus-width = <4>;
> > > - cd-gpios = <&pio 5 6 GPIO_ACTIVE_HIGH>;
> > > + cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>;
> >
> > Was able to detect and do mount with existing dts
>
> Did you try to boot from sdcard ? I am not able to boot my board from
> sd-card without this change. As I mentioned earlier in my email
> to buildroot mailing list, with mmc debug enabled I see that mmc
> tries to init sd-card when I remove it from the slot.
>
> Maybe there is a minor differences between h/w versions or batches ?
> What is you board version ? I tested on board v1.0.
>
>
> I'm using same v1.0
Ok, lets skip this patch for now.
I will double check v1.0 schematics and my board behavior.
Though I see that mmc0 dts fragment in u-boot for this board
also differs from the current kernel one: it uses 'cd-inverted' property.
Regards,
Sergey
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-11-04 16:22 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 19:58 [PATCH 0/2] arm64: dts: orange-pi-zero-plus2 mmc and wifi Sergey Matyukevich
[not found] ` <20171103195855.15283-1-geomatsi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-11-03 19:58 ` [PATCH 1/2] arm64: dts: orange-pi-zero-plus2: fix sdcard detect Sergey Matyukevich
[not found] ` <20171103195855.15283-2-geomatsi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-11-04 12:03 ` Jagan Teki
2017-11-04 15:39 ` Sergey Matyukevich
[not found] ` <CAMty3ZCs8kq1vUGLOi0ZghY7n0iXgUQ1E=ngBO6Y4wm7wMLF7Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-11-04 15:42 ` Sergey Matyukevich
2017-11-04 15:47 ` Jagan Teki
[not found] ` <CAMty3ZCxXUaBf3t=3d7D+RU6rp83oJw8BHADU3TYDeM4Vx_k-w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-11-04 16:22 ` Sergey Matyukevich [this message]
[not found] ` <20171104162206.gowih7h7og3fk7rk-tVm4GcgtBpsfMUw/CLfKLg@public.gmane.org>
2017-11-06 10:28 ` Jagan Teki
[not found] ` <CAMty3ZBi1pscPLQyc4S075pvzyh-2wsSPnqqEuQgDFQ_c5oyFg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-11-06 11:25 ` Sergey Matyukevich
[not found] ` <20171104154221.ao7kkcwqhnja3cxe-tVm4GcgtBpsfMUw/CLfKLg@public.gmane.org>
2017-11-06 12:26 ` Maxime Ripard
2017-11-06 16:13 ` Sergey Matyukevich
[not found] ` <20171106161306.tq6yeq6bq36ridj3-tVm4GcgtBpsfMUw/CLfKLg@public.gmane.org>
2017-11-07 7:42 ` Jagan Teki
[not found] ` <CAMty3ZCYQx0MfiJnOZPtO4nSAtOrGicOzw_x_AznTiEW8h2sLg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-11-07 17:17 ` Jagan Teki
[not found] ` <CAMty3ZANhL7cHqYw4VY2Sj_JUZGyqFZ+7pLssc1tniN3BdupOA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-11-07 20:12 ` Sergey Matyukevich
[not found] ` <20171107201245.gptgfli54o6eqmrj-tVm4GcgtBpsfMUw/CLfKLg@public.gmane.org>
2017-11-08 11:25 ` Jagan Teki
[not found] ` <CAMty3ZB3aXCsd9VkibjxPdA=BXvXr3nMbGJJvtZN_z2SGVUAXA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-11-13 19:24 ` Sergey Matyukevich
[not found] ` <20171113192411.kmohcthzickk4n5v-tVm4GcgtBpsfMUw/CLfKLg@public.gmane.org>
2017-11-14 14:39 ` Maxime Ripard
[not found] ` <20171114143941.3qgdlqn4xfarfhql-ZC1Zs529Oq4@public.gmane.org>
2017-11-14 18:53 ` Sergey Matyukevich
[not found] ` <20171114185315.gwyacchfct4zvyif-tVm4GcgtBpsfMUw/CLfKLg@public.gmane.org>
2017-11-21 13:41 ` Jagan Teki
[not found] ` <CAMty3ZDQqaiZ0RxtngWdX9PCW2+tzXLVB64heHLjRBeVF2-FCQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-12-03 20:13 ` Sergey Matyukevich
2017-12-05 9:15 ` Maxime Ripard
2017-11-03 19:58 ` [PATCH 2/2] arm64: dts: orange-pi-zero-plus2: enable AP6212a WiFi/BT combo Sergey Matyukevich
[not found] ` <20171103195855.15283-3-geomatsi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-11-12 20:22 ` Sergey Matyukevich
2017-11-13 9:25 ` Maxime Ripard
2017-11-29 13:53 ` Jagan Teki
[not found] ` <CAMty3ZAiDvAG-P-c0J7vKaDyRWQ2CQobLA_xycRva5B20W6SOg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-11-29 14:22 ` Chen-Yu Tsai
[not found] ` <CAGb2v66mNeUL0Pk60aB2s98GK2WiSdhk2_QiZJuMz0Rt=NmEyg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-11-29 18:09 ` Jagan Teki
[not found] ` <CAMty3ZDkM7apyoJESQm0zU1t-pNFdj8ynrZJoTstvgs98Aw6ZQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-11-29 18:21 ` Sergey Matyukevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171104162206.gowih7h7og3fk7rk@speedy.hunter \
--to=geomatsi-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=wens-jdAy2FN1RRM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox