Re: [PATCH 1/2] arm64: dts: orange-pi-zero-plus2: fix sdcard detect

[Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1709 bytes --]

On Sat, Nov 04, 2017 at 06:42:21PM +0300, Sergey Matyukevich wrote:
> > > The sdcard detect pin on orange-pi-zero-plus2 is pulled up.
> > > Fix cd-gpio description to enable sdcard detect.
> > >
> > > Signed-off-by: Sergey Matyukevich <geomatsi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > > ---
> > >  arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus2.dts | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus2.dts
> > > index b6b7a561df8c..a42fd79a62a3 100644
> > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus2.dts
> > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus2.dts
> > > @@ -71,7 +71,7 @@
> > >         pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin>;
> > >         vmmc-supply = <&reg_vcc3v3>;
> > >         bus-width = <4>;
> > > -       cd-gpios = <&pio 5 6 GPIO_ACTIVE_HIGH>;
> > > +       cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>;
> > 
> > Was able to detect and do mount with existing dts
> 
> Did you try to boot from sdcard ? I am not able to boot my board from
> sd-card without this change. As I mentioned earlier in my email
> to buildroot mailing list, with mmc debug enabled I see that mmc
> tries to init sd-card when I remove it from the slot.
> 
> Maybe there is a minor differences between h/w versions or batches ?
> What is you board version ? I tested on board v1.0.

Looking at the schematics, it definitely looks like it's active low.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]