* [bug report] of/irq: Break out msi-map lookup (again)
@ 2017-11-15 12:23 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2017-11-15 12:23 UTC (permalink / raw)
To: robin.murphy-5wv7dgnIgG8; +Cc: devicetree-u79uwXL29TY76Z2rM5mHXA
Hello Robin Murphy,
The patch 987068fcbdb7: "of/irq: Break out msi-map lookup (again)"
from Sep 12, 2016, leads to the following static checker warning:
drivers/of/of_pci.c:375 of_pci_map_rid()
error: we previously assumed 'id_out' could be null (see line 372)
drivers/of/of_pci.c
371
372 if (id_out)
^^^^^^
Check for NULL
373 *id_out = masked_rid - rid_base + out_base;
374
375 pr_debug("%pOF: %s, using mask %08x, rid-base: %08x, out-base: %08x, length: %08x, rid: %08x -> %08x\n",
376 np, map_name, map_mask, rid_base, out_base,
377 rid_len, rid, *id_out);
^^^^^^
Unchecked dereference
378 return 0;
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-11-15 12:23 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-15 12:23 [bug report] of/irq: Break out msi-map lookup (again) Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox