* Re: [RESEND PATCH v5 2/5] dt-bindings: pwm-backlight: add PWM delay proprieties.
[not found] ` <20180219111136.jpv4wtcm6h2hfwac@oak.lan>
@ 2018-03-09 10:14 ` Enric Balletbo Serra
2018-03-12 9:10 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Enric Balletbo Serra @ 2018-03-09 10:14 UTC (permalink / raw)
To: Daniel Thompson
Cc: Enric Balletbo i Serra, Lee Jones, Jingoo Han, Rob Herring,
Pavel Machek, Heiko Stuebner, Thierry Reding,
Bartlomiej Zolnierkiewicz, Richard Purdie, Jacek Anaszewski,
Linux PWM List, linux-fbdev, linux-kernel, Guenter Roeck,
open list:ARM/Rockchip SoC..., kernel, devicetree@vger.kernel.org,
Mark Rutland
Hi Rob,
oh, devicetree mailing list is not added, sorry, so cc'ing ...
2018-02-19 12:11 GMT+01:00 Daniel Thompson <daniel.thompson@linaro.org>:
> On Fri, Feb 16, 2018 at 06:40:31PM +0100, Enric Balletbo i Serra wrote:
>> Hardware needs a delay between setting an initial (non-zero) PWM and
>> enabling the backlight using GPIO. The post-pwm-on-delay-ms specifies
>> this delay in milli seconds. Hardware also needs a delay between disabing
>> the backlight using GPIO and setting PWM value to 0. The pwm-off-delay-ms
>> is this delay in milli seconds.
>>
>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>> Acked-by: Pavel Machek <pavel@ucw.cz>
>
> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
>
Lee, I guess that after Daniel ack the only ack missing here is one
from Rob Herring?
Rob, if you have a chance to look at this I'd appreciate.
Thanks,
Enric
>> ---
>> Based on the original Huang Lin <hl@rock-chips.com> work.
>>
>> Changes since v4:
>> - Rebase on top of mainline.
>> Changes since v3:
>> - Replace us for ms.
>> - Add Acked-by: Pavel Machek <pavel@ucw.cz>
>> Changes since v2:
>> - Use separate properties (Rob Herring)
>> Changes since v1:
>> - As suggested by Daniel Thompson
>> - Do not assume power-on delay and power-off delay will be the same
>>
>> Documentation/devicetree/bindings/leds/backlight/pwm-backlight.txt | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.txt b/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.txt
>> index 764db86d441a..310810906613 100644
>> --- a/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.txt
>> +++ b/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.txt
>> @@ -17,6 +17,10 @@ Optional properties:
>> "pwms" property (see PWM binding[0])
>> - enable-gpios: contains a single GPIO specifier for the GPIO which enables
>> and disables the backlight (see GPIO binding[1])
>> + - post-pwm-on-delay-ms: Delay in ms between setting an initial (non-zero) PWM
>> + and enabling the backlight using GPIO.
>> + - pwm-off-delay-ms: Delay in ms between disabling the backlight using GPIO
>> + and setting PWM value to 0.
>>
>> [0]: Documentation/devicetree/bindings/pwm/pwm.txt
>> [1]: Documentation/devicetree/bindings/gpio/gpio.txt
>> @@ -32,4 +36,6 @@ Example:
>>
>> power-supply = <&vdd_bl_reg>;
>> enable-gpios = <&gpio 58 0>;
>> + post-pwm-on-delay-ms = <10>;
>> + pwm-off-delay-ms = <10>;
>> };
>> --
>> 2.15.1
>>
^ permalink raw reply [flat|nested] 2+ messages in thread