Re: [PATCH V2 02/11] PM / OPP: dt-bindings: Make "opp-hz" optional for power domains

Re: [PATCH V2 02/11] PM / OPP: dt-bindings: Make "opp-hz" optional for power domains

[Viresh Kumar]

On 09-04-18, 17:13, Viresh Kumar wrote:
> The "opp-hz" property is not relevant across all the devices that use
> the OPP tables now. For example, for a power domain a frequency value
> wouldn't mean anything. Though they must have another property, which
> may be implementation defined, which uniquely identifies the OPP nodes.
> 
> Make "opp-hz" optional for such devices.
> 
> Cc: Rob Herring <robh@kernel.org>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
>  Documentation/devicetree/bindings/opp/opp.txt | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/opp/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt
> index 788052d66c9d..c396c4c0af92 100644
> --- a/Documentation/devicetree/bindings/opp/opp.txt
> +++ b/Documentation/devicetree/bindings/opp/opp.txt
> @@ -82,7 +82,10 @@ This defines voltage-current-frequency combinations along with other related
>  properties.
>  
>  Required properties:
> -- opp-hz: Frequency in Hz, expressed as a 64-bit big-endian integer.
> +- opp-hz: Frequency in Hz, expressed as a 64-bit big-endian integer. This is a
> +  required property for all device nodes but devices like power domains. The
> +  power domain nodes must have another (implementation dependent) property which
> +  uniquely identifies the OPP nodes.
>  
>  Optional properties:
>  - opp-microvolt: voltage in micro Volts.

Hi Rob,

Can you please review/Ack this patch as well? I can then pick this
series for 4.18 branch.

-- 
viresh

[PATCH V2 resend] PM / OPP: dt-bindings: Make "opp-hz" optional for power domains

[Viresh Kumar]

The "opp-hz" property is not relevant across all the devices that use
the OPP tables now. For example, for a power domain a frequency value
wouldn't mean anything. Though they must have another property, which
may be implementation defined, which uniquely identifies the OPP nodes.

Make "opp-hz" optional for such devices.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
---
Resending to get Ack from Rob.

 Documentation/devicetree/bindings/opp/opp.txt | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/opp/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt
index 788052d66c9d..c396c4c0af92 100644
--- a/Documentation/devicetree/bindings/opp/opp.txt
+++ b/Documentation/devicetree/bindings/opp/opp.txt
@@ -82,7 +82,10 @@ This defines voltage-current-frequency combinations along with other related
 properties.
 
 Required properties:
-- opp-hz: Frequency in Hz, expressed as a 64-bit big-endian integer.
+- opp-hz: Frequency in Hz, expressed as a 64-bit big-endian integer. This is a
+  required property for all device nodes but devices like power domains. The
+  power domain nodes must have another (implementation dependent) property which
+  uniquely identifies the OPP nodes.
 
 Optional properties:
 - opp-microvolt: voltage in micro Volts.
-- 
2.15.0.194.g9af6a3dea062

Re: [PATCH V2 resend] PM / OPP: dt-bindings: Make "opp-hz" optional for power domains

[Rob Herring]

On Tue, May 08, 2018 at 09:04:42AM +0530, Viresh Kumar wrote:
> The "opp-hz" property is not relevant across all the devices that use
> the OPP tables now. For example, for a power domain a frequency value
> wouldn't mean anything. Though they must have another property, which
> may be implementation defined, which uniquely identifies the OPP nodes.
> 
> Make "opp-hz" optional for such devices.
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
> Resending to get Ack from Rob.
> 
>  Documentation/devicetree/bindings/opp/opp.txt | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Reviewed-by: Rob Herring <robh@kernel.org>