public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Mark Rutland <mark.rutland@arm.com>, Andrew Lunn <andrew@lunn.ch>,
	Jason Cooper <jason@lakedaemon.net>,
	Nadav Haklai <nadavh@marvell.com>,
	devicetree@vger.kernel.org,
	Antoine Tenart <antoine.tenart@bootlin.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Gregory Clement <gregory.clement@bootlin.com>,
	linux-pm@vger.kernel.org, Will Deacon <will.deacon@arm.com>,
	Maxime Chevallier <maxime.chevallier@bootlin.com>,
	Eduardo Valentin <edubezval@gmail.com>,
	David Sniatkiwicz <davidsn@marvell.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Zhang Rui <rui.zhang@intel.com>,
	linux-arm-kernel@lists.infradead.org,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH v2 19/23] arm64: dts: marvell: rename ap806 syscon node
Date: Tue, 3 Jul 2018 15:33:39 -0600	[thread overview]
Message-ID: <20180703213339.GA29809@rob-hp-laptop> (raw)
In-Reply-To: <20180625151239.20976-20-miquel.raynal@bootlin.com>

On Mon, Jun 25, 2018 at 05:12:35PM +0200, Miquel Raynal wrote:
> In CP files, the syscons are called CP110_LABEL(syscon<x>) in case of
> future additions. Use the same logic here to prepare the addition of a
> second syscon to access both the thermal IP, the DFX server registers
> and later probably other registers within this same memory area.

You are renaming labels, not nodes.

The example is just an example. Drop that change as it is not necessary.

> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>  .../devicetree/bindings/arm/marvell/ap806-system-controller.txt         | 2 +-
>  arch/arm64/boot/dts/marvell/armada-ap806.dtsi                           | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt b/Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt
> index a265f1628f36..108e8da600e4 100644
> --- a/Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt
> +++ b/Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt
> @@ -79,7 +79,7 @@ Required properties:
>  - offset: offset address inside the syscon block
>  
>  Example:
> -ap_syscon: system-controller@6f4000 {
> +ap_syscon0: system-controller@6f4000 {
>  	compatible = "syscon", "simple-mfd";
>  	reg = <0x6f4000 0x1000>;
>  
> diff --git a/arch/arm64/boot/dts/marvell/armada-ap806.dtsi b/arch/arm64/boot/dts/marvell/armada-ap806.dtsi
> index 4f2a704615b0..550f03b8c96f 100644
> --- a/arch/arm64/boot/dts/marvell/armada-ap806.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-ap806.dtsi
> @@ -230,7 +230,7 @@
>  				status = "disabled";
>  			};
>  
> -			ap_syscon: system-controller@6f4000 {
> +			ap_syscon0: system-controller@6f4000 {
>  				compatible = "syscon", "simple-mfd";
>  				reg = <0x6f4000 0x2000>;
>  
> -- 
> 2.14.1
> 

  reply	other threads:[~2018-07-03 21:33 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-25 15:12 [PATCH v2 00/23] Add multi-channel support to Armada thermal driver Miquel Raynal
2018-06-25 15:12 ` [PATCH v2 01/23] thermal: armada: remove useless register accesses Miquel Raynal
2018-06-25 15:12 ` [PATCH v2 02/23] thermal: armada: remove misleading comments Miquel Raynal
2018-06-25 15:12 ` [PATCH v2 03/23] thermal: armada: rename the initialization routine Miquel Raynal
2018-06-25 15:12 ` [PATCH v2 04/23] thermal: armada: dissociate a380 and cp110 ->init() hooks Miquel Raynal
2018-06-25 15:12 ` [PATCH v2 05/23] thermal: armada: average over samples to avoid glitches Miquel Raynal
2018-06-25 15:12 ` [PATCH v2 06/23] thermal: armada: convert driver to syscon register accesses Miquel Raynal
2018-06-26  3:37   ` Baruch Siach
2018-06-26  7:29     ` Miquel Raynal
2018-07-02 17:29       ` Eduardo Valentin
2018-07-05 12:43         ` Miquel Raynal
2018-07-05 15:53           ` Miquel Raynal
2018-06-25 15:12 ` [PATCH v2 07/23] thermal: armada: use the resource managed registration helper alternative Miquel Raynal
2018-06-25 15:12 ` [PATCH v2 08/23] thermal: armada: add multi-channel sensors support Miquel Raynal
2018-06-25 15:12 ` [PATCH v2 09/23] thermal: armada: remove sensors validity from the IP initialization Miquel Raynal
2018-06-25 15:12 ` [PATCH v2 10/23] thermal: armada: move validity check out of the read function Miquel Raynal
2018-06-25 15:12 ` [PATCH v2 11/23] thermal: armada: get rid of the ->is_valid() pointer Miquel Raynal
2018-06-25 15:12 ` [PATCH v2 12/23] dt-bindings: cp110: rename cp110 syscon file Miquel Raynal
2018-06-25 15:12 ` [PATCH v2 13/23] dt-bindings: ap806: prepare the syscon file to list other syscons nodes Miquel Raynal
2018-07-03 21:07   ` Rob Herring
2018-06-25 15:12 ` [PATCH v2 14/23] dt-bindings: cp110: " Miquel Raynal
2018-06-26  3:35   ` Baruch Siach
2018-06-26  7:34     ` Miquel Raynal
2018-07-03 21:07   ` Rob Herring
2018-06-25 15:12 ` [PATCH v2 15/23] dt-bindings: ap806: add the thermal node in the syscon file Miquel Raynal
2018-07-03 21:13   ` Rob Herring
2018-06-25 15:12 ` [PATCH v2 16/23] dt-bindings: cp110: update documentation since DT de-duplication Miquel Raynal
2018-06-25 15:12 ` [PATCH v2 17/23] dt-bindings: cp110: add the thermal node in the syscon file Miquel Raynal
2018-07-03 21:14   ` Rob Herring
2018-06-25 15:12 ` [PATCH v2 18/23] dt-bindings: thermal: armada: add reference to new bindings Miquel Raynal
2018-07-03 21:30   ` Rob Herring
2018-07-05 10:05     ` Miquel Raynal
2018-07-05 18:03       ` Rob Herring
2018-07-06  6:54         ` Miquel Raynal
2018-07-06 17:51           ` Rob Herring
2018-07-06  7:49         ` Miquel Raynal
2018-07-06 17:56           ` Rob Herring
2018-07-16 14:32             ` Miquel Raynal
2018-06-25 15:12 ` [PATCH v2 19/23] arm64: dts: marvell: rename ap806 syscon node Miquel Raynal
2018-07-03 21:33   ` Rob Herring [this message]
2018-06-25 15:12 ` [PATCH v2 20/23] arm64: dts: marvell: move AP806/CP110 thermal nodes into a new syscon Miquel Raynal
2018-06-25 15:12 ` [PATCH v2 21/23] arm64: dts: marvell: add thermal-zone node in ap806 DTSI file Miquel Raynal
2018-06-25 15:12 ` [PATCH v2 22/23] arm64: dts: marvell: add macro to make distinction between node names Miquel Raynal
2018-06-25 15:12 ` [PATCH v2 23/23] arm64: dts: marvell: add thermal-zone node in cp110 DTSI file Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180703213339.GA29809@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=antoine.tenart@bootlin.com \
    --cc=catalin.marinas@arm.com \
    --cc=davidsn@marvell.com \
    --cc=devicetree@vger.kernel.org \
    --cc=edubezval@gmail.com \
    --cc=gregory.clement@bootlin.com \
    --cc=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maxime.chevallier@bootlin.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=nadavh@marvell.com \
    --cc=rui.zhang@intel.com \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox