From: Vinod <vkoul@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Todor Tomov <todor.tomov@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Linux I2C <linux-i2c@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: i2c: Add binding for Qualcomm CCI I2C controller
Date: Wed, 8 Aug 2018 21:37:45 +0530 [thread overview]
Message-ID: <20180808160745.GM2395@vkoul-mobl> (raw)
In-Reply-To: <CAL_JsqLu9Au37Fz5-GS9NoJkAXwH+jjPTqUZCzxhd7pZKTLgXw@mail.gmail.com>
On 08-08-18, 08:48, Rob Herring wrote:
> On Wed, Aug 8, 2018 at 8:03 AM Todor Tomov <todor.tomov@linaro.org> wrote:
> > >>>> So this should either be:
> > >>>>
> > >>>> - "qcom,cci-v1.0.8"
> > >
> > > This is supposed to be 1.1.0 for 8916...
> >
> > There is conflicting information about this in the documentation.
> > However the version read from the hw version register is 1.0.8 and
> > this matches the value listed in the SWI too so I believe 1.0.8 is
> > correct for 8916.
>
> And this is why we don't use version numbers. Unless you have access
> to the RTL repositories with version tags then it is just error prone.
Yeah we have a HW_VERSION register too, but someone might forget to
populate it, so lets go ahead and use the soc numbers as discussed.
Thanks
--
~Vinod
next prev parent reply other threads:[~2018-08-08 16:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-06 11:04 [PATCH v3 0/2] i2c: Add support for Qcom CCI I2C controller Vinod Koul
2018-08-06 11:04 ` [PATCH v3 1/2] dt-bindings: i2c: Add binding for Qualcomm " Vinod Koul
2018-08-06 18:03 ` Bjorn Andersson
2018-08-07 4:18 ` Vinod
2018-08-07 17:39 ` Rob Herring
2018-08-07 18:07 ` Bjorn Andersson
2018-08-08 14:03 ` Todor Tomov
2018-08-08 14:48 ` Rob Herring
2018-08-08 16:07 ` Vinod [this message]
2018-08-06 11:04 ` [PATCH v3 2/2] i2c: Add Qualcomm CCI I2C driver Vinod Koul
2018-08-06 18:45 ` Bjorn Andersson
2018-08-07 4:30 ` Vinod
2018-08-07 5:11 ` Bjorn Andersson
2018-08-17 12:41 ` Vinod
2018-08-17 18:33 ` Bjorn Andersson
2018-08-18 4:45 ` Vinod
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180808160745.GM2395@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=robh@kernel.org \
--cc=todor.tomov@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox