From: Simon Horman <horms@verge.net.au>
To: Biju Das <biju.das@bp.renesas.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Magnus Damm <magnus.damm@gmail.com>,
linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Subject: Re: [PATCH RESEND] ARM: dts: iwg23s-sbc: Add pinctl support for EtherAVB
Date: Thu, 4 Oct 2018 12:13:45 +0200 [thread overview]
Message-ID: <20181004101344.ppufmao3fhtips4i@verge.net.au> (raw)
In-Reply-To: <1538555523-19644-1-git-send-email-biju.das@bp.renesas.com>
On Wed, Oct 03, 2018 at 09:32:03AM +0100, Biju Das wrote:
> Adding pinctrl support for EtherAVB interface.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Hi Simon,
>
> As per the below discussion,I need to resend this patch for V.21
>
> https://patchwork.kernel.org/patch/10558315/
>
> Are you happy to take this patch?
>
> This patch is tested against renesas-dev branch
Hi Biju,
As I understand it this patch has dependencies which should be included
in v4.20-rc1. If that understanding is correct then I would prefer
to wait until v4.20-rc1 is released before I accept this patch
so that I can accept it into a branch based on v4.20-rc1 which will
have the dependency present.
> ---
> arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
> index 22da819..4ceff9c 100644
> --- a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
> +++ b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
> @@ -28,6 +28,9 @@
> };
>
> &avb {
> + pinctrl-0 = <&avb_pins>;
> + pinctrl-names = "default";
> +
> phy-handle = <&phy3>;
> phy-mode = "gmii";
> renesas,no-ether-link;
> @@ -46,6 +49,11 @@
> };
>
> &pfc {
> + avb_pins: avb {
> + groups = "avb_mdio", "avb_gmii_tx_rx";
> + function = "avb";
> + };
> +
> scif1_pins: scif1 {
> groups = "scif1_data_b";
> function = "scif1";
> --
> 2.7.4
>
next prev parent reply other threads:[~2018-10-04 10:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 8:32 [PATCH RESEND] ARM: dts: iwg23s-sbc: Add pinctl support for EtherAVB Biju Das
2018-10-04 10:13 ` Simon Horman [this message]
2018-10-04 10:16 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181004101344.ppufmao3fhtips4i@verge.net.au \
--to=horms@verge.net.au \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrizio.castro@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox