[PATCH RESEND] ARM: dts: iwg23s-sbc: Add pinctl support for EtherAVB

[PATCH RESEND] ARM: dts: iwg23s-sbc: Add pinctl support for EtherAVB

[Biju Das]

Adding pinctrl support for EtherAVB interface.

Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Hi Simon,

As per the below discussion,I need to resend this patch for V.21

https://patchwork.kernel.org/patch/10558315/

Are you happy to take this patch?

This patch is tested against renesas-dev branch
---
 arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
index 22da819..4ceff9c 100644
--- a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
+++ b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
@@ -28,6 +28,9 @@
 };
 
 &avb {
+	pinctrl-0 = <&avb_pins>;
+	pinctrl-names = "default";
+
 	phy-handle = <&phy3>;
 	phy-mode = "gmii";
 	renesas,no-ether-link;
@@ -46,6 +49,11 @@
 };
 
 &pfc {
+	avb_pins: avb {
+		groups = "avb_mdio", "avb_gmii_tx_rx";
+		function = "avb";
+	};
+
 	scif1_pins: scif1 {
 		groups = "scif1_data_b";
 		function = "scif1";
-- 
2.7.4

Re: [PATCH RESEND] ARM: dts: iwg23s-sbc: Add pinctl support for EtherAVB

[Simon Horman]

On Wed, Oct 03, 2018 at 09:32:03AM +0100, Biju Das wrote:
> Adding pinctrl support for EtherAVB interface.
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Hi Simon,
> 
> As per the below discussion,I need to resend this patch for V.21
> 
> https://patchwork.kernel.org/patch/10558315/
> 
> Are you happy to take this patch?
> 
> This patch is tested against renesas-dev branch

Hi Biju,

As I understand it this patch has dependencies which should be included
in v4.20-rc1. If that understanding is correct then I would prefer
to wait until v4.20-rc1 is released before I accept this patch
so that I can accept it into a branch based on v4.20-rc1 which will
have the dependency present.

> ---
>  arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
> index 22da819..4ceff9c 100644
> --- a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
> +++ b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
> @@ -28,6 +28,9 @@
>  };
>  
>  &avb {
> +	pinctrl-0 = <&avb_pins>;
> +	pinctrl-names = "default";
> +
>  	phy-handle = <&phy3>;
>  	phy-mode = "gmii";
>  	renesas,no-ether-link;
> @@ -46,6 +49,11 @@
>  };
>  
>  &pfc {
> +	avb_pins: avb {
> +		groups = "avb_mdio", "avb_gmii_tx_rx";
> +		function = "avb";
> +	};
> +
>  	scif1_pins: scif1 {
>  		groups = "scif1_data_b";
>  		function = "scif1";
> -- 
> 2.7.4
> 

RE: [PATCH RESEND] ARM: dts: iwg23s-sbc: Add pinctl support for EtherAVB

[Biju Das]

Hi Simon,

Thanks for the feedback.

> Subject: Re: [PATCH RESEND] ARM: dts: iwg23s-sbc: Add pinctl support for
> EtherAVB
>
> On Wed, Oct 03, 2018 at 09:32:03AM +0100, Biju Das wrote:
> > Adding pinctrl support for EtherAVB interface.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > Hi Simon,
> >
> > As per the below discussion,I need to resend this patch for V.21
> >
> > https://patchwork.kernel.org/patch/10558315/
> >
> > Are you happy to take this patch?
> >
> > This patch is tested against renesas-dev branch
>
> Hi Biju,
>
> As I understand it this patch has dependencies which should be included in
> v4.20-rc1. If that understanding is correct then I would prefer to wait until
> v4.20-rc1 is released before I accept this patch so that I can accept it into a
> branch based on v4.20-rc1 which will have the dependency present.

OK.

Regards,
Biju



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.