public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Jeffrey Hugo <jhugo@codeaurora.org>
Cc: andy.gross@linaro.org, david.brown@linaro.org,
	robh+dt@kernel.org, mark.rutland@arm.com,
	linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] arm64: dts: qcom: msm8998: Add SDCC2
Date: Thu, 15 Nov 2018 10:26:56 -0800	[thread overview]
Message-ID: <20181115182656.GJ10915@tuxbook-pro> (raw)
In-Reply-To: <1542302291-6864-3-git-send-email-jhugo@codeaurora.org>

On Thu 15 Nov 09:18 PST 2018, Jeffrey Hugo wrote:

> SDCC2 is typically used as the controller for an external SD card slot.
> 
> Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
> ---

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Regards,
Bjorn

>  arch/arm64/boot/dts/qcom/msm8998.dtsi | 19 ++++++++++++++++++-
>  1 file changed, 18 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
> index a948d4b..09deee0 100644
> --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
> @@ -53,7 +53,7 @@
>  	};
>  
>  	clocks {
> -		xo {
> +		xo: xo {
>  			compatible = "fixed-clock";
>  			#clock-cells = <0>;
>  			clock-frequency = <19200000>;
> @@ -605,6 +605,23 @@
>  			#mbox-cells = <1>;
>  		};
>  
> +		sdhc2: sdhci@c0a4900 {
> +			compatible = "qcom,sdhci-msm-v4";
> +			reg = <0xc0a4900 0x314>, <0xc0a4000 0x800>;
> +			reg-names = "hc_mem", "core_mem";
> +
> +			interrupts = <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 221 IRQ_TYPE_LEVEL_HIGH>;
> +			interrupt-names = "hc_irq", "pwr_irq";
> +
> +			clock-names = "iface", "core", "xo";
> +			clocks = <&gcc GCC_SDCC2_AHB_CLK>,
> +				 <&gcc GCC_SDCC2_APPS_CLK>,
> +				 <&xo>;
> +			bus-width = <4>;
> +			status = "disabled";
> +		};
> +
>  		blsp2_uart1: serial@c1b0000 {
>  			compatible = "qcom,msm-uartdm-v1.4", "qcom,msm-uartdm";
>  			reg = <0xc1b0000 0x1000>;
> -- 
> Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc.
> Qualcomm Technologies, Inc. is a member of the
> Code Aurora Forum, a Linux Foundation Collaborative Project.
> 

  reply	other threads:[~2018-11-15 18:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-15 17:18 [PATCH 0/4] Enable SD crd slot on msm8998 MTP Jeffrey Hugo
2018-11-15 17:18 ` [PATCH 1/4] arm64: dts: qcom: msm8998: correct xo clock name Jeffrey Hugo
2018-11-15 18:26   ` Bjorn Andersson
2018-11-15 17:18 ` [PATCH 2/4] arm64: dts: qcom: msm8998: Add SDCC2 Jeffrey Hugo
2018-11-15 18:26   ` Bjorn Andersson [this message]
2018-11-15 17:18 ` [PATCH 3/4] arm64: dts: qcom: msm8998: Add SDC2 control pins Jeffrey Hugo
2018-11-15 19:16   ` Bjorn Andersson
2018-11-15 20:15     ` Jeffrey Hugo
2018-11-15 17:18 ` [PATCH 4/4] arm64: dts: qcom: msm8998-mtp: Add external SD Jeffrey Hugo
2018-11-15 19:05   ` Andy Gross
2018-11-15 20:11     ` Jeffrey Hugo
2018-11-15 19:20   ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181115182656.GJ10915@tuxbook-pro \
    --to=bjorn.andersson@linaro.org \
    --cc=andy.gross@linaro.org \
    --cc=david.brown@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jhugo@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox