From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Jeffrey Hugo <jhugo@codeaurora.org>
Cc: andy.gross@linaro.org, david.brown@linaro.org,
robh+dt@kernel.org, mark.rutland@arm.com,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] arm64: dts: qcom: msm8998: Add SDC2 control pins
Date: Thu, 15 Nov 2018 11:16:23 -0800 [thread overview]
Message-ID: <20181115191623.GK10915@tuxbook-pro> (raw)
In-Reply-To: <1542302291-6864-4-git-send-email-jhugo@codeaurora.org>
On Thu 15 Nov 09:18 PST 2018, Jeffrey Hugo wrote:
> The SDC2 control pins are typically used to manage sleep.
>
> Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
> ---
> arch/arm64/boot/dts/qcom/msm8998-pins.dtsi | 78 ++++++++++++++++++++++++++++++
Rather than adding a -pins file, add the pinctrl states the individual
dts(i) directly.
> arch/arm64/boot/dts/qcom/msm8998.dtsi | 2 +
> 2 files changed, 80 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/msm8998-pins.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8998-pins.dtsi b/arch/arm64/boot/dts/qcom/msm8998-pins.dtsi
> new file mode 100644
> index 0000000..a22abf9
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/msm8998-pins.dtsi
> @@ -0,0 +1,78 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/* Copyright (c) 2018, The Linux Foundation. All rights reserved. */
> +
> +&tlmm {
> + sdc2_clk_on: sdc2_clk_on {
Use _ in labels, - in node names.
> + config {
You don't have to put the pinctrl state properties in an additional
subnode anymore, so feel free to remove the extra subnode level.
> + pins = "sdc2_clk";
> + bias-disable; /* NO pull */
> + drive-strength = <16>; /* 16 MA */
Please push electrical properties to the board dts instead of the
platform one, as they might be board specific.
> + };
> + };
Apart from this the patch loogs good.
Regards,
Bjorn
next prev parent reply other threads:[~2018-11-15 19:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 17:18 [PATCH 0/4] Enable SD crd slot on msm8998 MTP Jeffrey Hugo
2018-11-15 17:18 ` [PATCH 1/4] arm64: dts: qcom: msm8998: correct xo clock name Jeffrey Hugo
2018-11-15 18:26 ` Bjorn Andersson
2018-11-15 17:18 ` [PATCH 2/4] arm64: dts: qcom: msm8998: Add SDCC2 Jeffrey Hugo
2018-11-15 18:26 ` Bjorn Andersson
2018-11-15 17:18 ` [PATCH 3/4] arm64: dts: qcom: msm8998: Add SDC2 control pins Jeffrey Hugo
2018-11-15 19:16 ` Bjorn Andersson [this message]
2018-11-15 20:15 ` Jeffrey Hugo
2018-11-15 17:18 ` [PATCH 4/4] arm64: dts: qcom: msm8998-mtp: Add external SD Jeffrey Hugo
2018-11-15 19:05 ` Andy Gross
2018-11-15 20:11 ` Jeffrey Hugo
2018-11-15 19:20 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181115191623.GK10915@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox