From: Carlo Caione <ccaione@baylibre.com>
To: andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com,
robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, fabio.estevam@nxp.com, linux-imx@nxp.com,
mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, aisheng.dong@nxp.com,
abailon@baylibre.com
Cc: Carlo Caione <ccaione@baylibre.com>
Subject: [PATCH 1/3] net: phy: at803x: Introduce quirk to disable SmartEEE
Date: Fri, 25 Jan 2019 12:55:11 +0000 [thread overview]
Message-ID: <20190125125513.23656-2-ccaione@baylibre.com> (raw)
In-Reply-To: <20190125125513.23656-1-ccaione@baylibre.com>
The proprietary SmartEEE mode makes the PHY entering a sleep mode after
a configurable idle time. It does this without LPI signals coming from
MAC.
Since this is a configurable behavior and it is known to cause issues
add a way to disable it using a custom quirk.
Signed-off-by: Carlo Caione <ccaione@baylibre.com>
---
drivers/net/phy/at803x.c | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
index f9432d053a22..509cd7a4f7eb 100644
--- a/drivers/net/phy/at803x.c
+++ b/drivers/net/phy/at803x.c
@@ -38,12 +38,14 @@
#define AT803X_DEVICE_ADDR 0x03
#define AT803X_LOC_MAC_ADDR_0_15_OFFSET 0x804C
#define AT803X_LOC_MAC_ADDR_16_31_OFFSET 0x804B
+#define AT803X_SMARTEEE_CTL3_OFFSET 0x805D
#define AT803X_LOC_MAC_ADDR_32_47_OFFSET 0x804A
#define AT803X_MMD_ACCESS_CONTROL 0x0D
#define AT803X_MMD_ACCESS_CONTROL_DATA 0x0E
#define AT803X_FUNC_DATA 0x4003
#define AT803X_REG_CHIP_CONFIG 0x1f
#define AT803X_BT_BX_REG_SEL 0x8000
+#define AT803X_SMARTEEE_DISABLED_VAL 0x1000
#define AT803X_DEBUG_ADDR 0x1D
#define AT803X_DEBUG_DATA 0x1E
@@ -65,12 +67,15 @@
#define ATH8035_PHY_ID 0x004dd072
#define AT803X_PHY_ID_MASK 0xffffffef
+#define AT803X_SMARTEEE_FEATURE_DISABLE BIT(1)
+
MODULE_DESCRIPTION("Atheros 803x PHY driver");
MODULE_AUTHOR("Matus Ujhelyi");
MODULE_LICENSE("GPL");
struct at803x_priv {
bool phy_reset:1;
+ u32 quirks;
};
struct at803x_context {
@@ -210,6 +215,13 @@ static void at803x_get_wol(struct phy_device *phydev,
wol->wolopts |= WAKE_MAGIC;
}
+static int at803x_disable_smarteee(struct phy_device *phydev)
+{
+ return phy_write_mmd(phydev, AT803X_DEVICE_ADDR,
+ AT803X_SMARTEEE_CTL3_OFFSET,
+ AT803X_SMARTEEE_DISABLED_VAL);
+}
+
static int at803x_suspend(struct phy_device *phydev)
{
int value;
@@ -242,6 +254,9 @@ static int at803x_probe(struct phy_device *phydev)
if (!priv)
return -ENOMEM;
+ if (of_property_read_bool(dev->of_node, "at803x,smarteee-disabled"))
+ priv->quirks |= AT803X_SMARTEEE_FEATURE_DISABLE;
+
phydev->priv = priv;
return 0;
@@ -249,6 +264,7 @@ static int at803x_probe(struct phy_device *phydev)
static int at803x_config_init(struct phy_device *phydev)
{
+ struct at803x_priv *priv = phydev->priv;
int ret;
ret = genphy_config_init(phydev);
@@ -269,6 +285,12 @@ static int at803x_config_init(struct phy_device *phydev)
return ret;
}
+ if (priv->quirks & AT803X_SMARTEEE_FEATURE_DISABLE) {
+ ret = at803x_disable_smarteee(phydev);
+ if (ret < 0)
+ return ret;
+ }
+
return 0;
}
--
2.19.1
next prev parent reply other threads:[~2019-01-25 12:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 12:55 [PATCH 0/3] at803x: Add quirk to disable SmartEEE Carlo Caione
2019-01-25 12:55 ` Carlo Caione [this message]
2019-01-25 12:55 ` [PATCH 2/3] dt-bindings: net: at803x: Document at803x, smarteee-disabled property Carlo Caione
2019-01-25 18:42 ` [PATCH 2/3] dt-bindings: net: at803x: Document at803x,smarteee-disabled property Florian Fainelli
2019-01-25 12:55 ` [PATCH 3/3] arm64: dts: imx8mq-evk: Disable SmartEEE Carlo Caione
2019-01-25 13:06 ` [PATCH 0/3] at803x: Add quirk to disable SmartEEE Russell King - ARM Linux admin
2019-01-25 18:15 ` Heiner Kallweit
2019-01-25 18:48 ` Carlo Caione
2019-01-25 19:07 ` Heiner Kallweit
2019-01-25 19:19 ` Russell King - ARM Linux admin
2019-01-25 19:27 ` Heiner Kallweit
2019-01-28 10:46 ` Carlo Caione
2019-01-28 15:57 ` Russell King - ARM Linux admin
2019-01-28 18:23 ` Heiner Kallweit
2019-01-28 19:04 ` Russell King - ARM Linux admin
2019-01-30 10:16 ` Carlo Caione
2019-01-30 10:47 ` Russell King - ARM Linux admin
2019-04-12 0:25 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190125125513.23656-2-ccaione@baylibre.com \
--to=ccaione@baylibre.com \
--cc=abailon@baylibre.com \
--cc=aisheng.dong@nxp.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=fabio.estevam@nxp.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox