From: Heiner Kallweit <hkallweit1@gmail.com>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>,
Carlo Caione <ccaione@baylibre.com>
Cc: mark.rutland@arm.com, andrew@lunn.ch, f.fainelli@gmail.com,
devicetree@vger.kernel.org, s.hauer@pengutronix.de,
robh+dt@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de,
fabio.estevam@nxp.com, shawnguo@kernel.org, aisheng.dong@nxp.com,
linux-arm-kernel@lists.infradead.org, abailon@baylibre.com
Subject: Re: [PATCH 0/3] at803x: Add quirk to disable SmartEEE
Date: Fri, 25 Jan 2019 19:15:47 +0100 [thread overview]
Message-ID: <7d43e158-bfbe-4b30-4298-426ea9f71bb3@gmail.com> (raw)
In-Reply-To: <20190125130612.npknjuzjmny4yohg@e5254000004ec.dyn.armlinux.org.uk>
On 25.01.2019 14:06, Russell King - ARM Linux admin wrote:
> On Fri, Jan 25, 2019 at 12:55:10PM +0000, Carlo Caione wrote:
>> SmartEEE, compatible with IEEE802.3az standard, is designed to include
>> legacy MAC without EEE capability into the power saving system. SmartEEE
>> is enabled by default configuration on AR8031 after power-on or hardware
>> reset.
>>
>> Unfortunately this is proved causing issues for certain hw
>> configurations. We add a quirk to optionally disable SmartEEE.
>
> It may be a good idea to detail what "certain hw configurations" are
> and/or what the "issues" are, so it's easier to find this if/when
> others encounter the same issue.
>
Question would also be whether the issue with SmartEEE occurs also
if EEE isn't advertized and therefore not active.
Then we could use the existing DT properties to flag broken EEE
modes, see of_set_phy_eee_broken().
>>
>> PATCH 3/3 depends on https://patchwork.kernel.org/patch/10781297/
>>
>>
>> Carlo Caione (3):
>> net: phy: at803x: Introduce quirk to disable SmartEEE
>> dt-bindings: net: at803x: Document at803x,smarteee-disabled property
>> arm64: dts: imx8mq-evk: Disable SmartEEE
>>
>> .../devicetree/bindings/net/at803x.txt | 18 +++++++++++++++
>> arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 1 +
>> drivers/net/phy/at803x.c | 22 +++++++++++++++++++
>> 3 files changed, 41 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/net/at803x.txt
>>
>> --
>> 2.19.1
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>
>
next prev parent reply other threads:[~2019-01-25 18:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 12:55 [PATCH 0/3] at803x: Add quirk to disable SmartEEE Carlo Caione
2019-01-25 12:55 ` [PATCH 1/3] net: phy: at803x: Introduce " Carlo Caione
2019-01-25 12:55 ` [PATCH 2/3] dt-bindings: net: at803x: Document at803x, smarteee-disabled property Carlo Caione
2019-01-25 18:42 ` [PATCH 2/3] dt-bindings: net: at803x: Document at803x,smarteee-disabled property Florian Fainelli
2019-01-25 12:55 ` [PATCH 3/3] arm64: dts: imx8mq-evk: Disable SmartEEE Carlo Caione
2019-01-25 13:06 ` [PATCH 0/3] at803x: Add quirk to disable SmartEEE Russell King - ARM Linux admin
2019-01-25 18:15 ` Heiner Kallweit [this message]
2019-01-25 18:48 ` Carlo Caione
2019-01-25 19:07 ` Heiner Kallweit
2019-01-25 19:19 ` Russell King - ARM Linux admin
2019-01-25 19:27 ` Heiner Kallweit
2019-01-28 10:46 ` Carlo Caione
2019-01-28 15:57 ` Russell King - ARM Linux admin
2019-01-28 18:23 ` Heiner Kallweit
2019-01-28 19:04 ` Russell King - ARM Linux admin
2019-01-30 10:16 ` Carlo Caione
2019-01-30 10:47 ` Russell King - ARM Linux admin
2019-04-12 0:25 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d43e158-bfbe-4b30-4298-426ea9f71bb3@gmail.com \
--to=hkallweit1@gmail.com \
--cc=abailon@baylibre.com \
--cc=aisheng.dong@nxp.com \
--cc=andrew@lunn.ch \
--cc=ccaione@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox