* [PATCH v4 3/3] dt-bindings: power: supply: Add bindings for Microchip UCS1002 [not found] <20190430064557.28469-1-andrew.smirnov@gmail.com> @ 2019-04-30 6:45 ` Andrey Smirnov 2019-04-30 16:15 ` Guenter Roeck 0 siblings, 1 reply; 4+ messages in thread From: Andrey Smirnov @ 2019-04-30 6:45 UTC (permalink / raw) To: linux-pm Cc: Andrey Smirnov, Enric Balletbo Serra, Chris Healy, Lucas Stach, Fabio Estevam, Guenter Roeck, Rob Herring, devicetree, Sebastian Reichel, linux-kernel Add bindings for Microchip UCS1002 Programmable USB Port Power Controller with Charger Emulation. Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> Cc: Enric Balletbo Serra <enric.balletbo@collabora.com> Cc: Chris Healy <cphealy@gmail.com> Cc: Lucas Stach <l.stach@pengutronix.de> Cc: Fabio Estevam <fabio.estevam@nxp.com> Cc: Guenter Roeck <linux@roeck-us.net> Cc: Rob Herring <robh+dt@kernel.org> Cc: devicetree@vger.kernel.org Cc: Sebastian Reichel <sre@kernel.org> Cc: linux-kernel@vger.kernel.org Cc: linux-pm@vger.kernel.org --- .../power/supply/microchip,ucs1002.txt | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/supply/microchip,ucs1002.txt diff --git a/Documentation/devicetree/bindings/power/supply/microchip,ucs1002.txt b/Documentation/devicetree/bindings/power/supply/microchip,ucs1002.txt new file mode 100644 index 000000000000..021fd7aba75e --- /dev/null +++ b/Documentation/devicetree/bindings/power/supply/microchip,ucs1002.txt @@ -0,0 +1,27 @@ +Microchip UCS1002 USB Port Power Controller + +Required properties: +- compatible : Should be "microchip,ucs1002"; +- reg : I2C slave address + +Optional properties: +- interrupts-extended : A list of interrupts lines present (could be either + corresponding to A_DET# pin, ALERT# pin, or both) +- interrupt-names : A list of interrupt names. Should contain (if + present): + - "a_det" for line connected to A_DET# pin + - "alert" for line connected to ALERT# pin + Both are expected to be IRQ_TYPE_EDGE_BOTH +Example: + +&i2c3 { + charger@32 { + compatible = "microchip,ucs1002"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_ucs1002_pins>; + reg = <0x32>; + interrupts-extended = <&gpio5 2 IRQ_TYPE_EDGE_BOTH>, + <&gpio3 21 IRQ_TYPE_EDGE_BOTH>; + interrupt-names = "a_det", "alert"; + }; +}; -- 2.20.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v4 3/3] dt-bindings: power: supply: Add bindings for Microchip UCS1002 2019-04-30 6:45 ` [PATCH v4 3/3] dt-bindings: power: supply: Add bindings for Microchip UCS1002 Andrey Smirnov @ 2019-04-30 16:15 ` Guenter Roeck 2019-04-30 22:32 ` Rob Herring 0 siblings, 1 reply; 4+ messages in thread From: Guenter Roeck @ 2019-04-30 16:15 UTC (permalink / raw) To: Andrey Smirnov Cc: linux-pm, Enric Balletbo Serra, Chris Healy, Lucas Stach, Fabio Estevam, Rob Herring, devicetree, Sebastian Reichel, linux-kernel On Mon, Apr 29, 2019 at 11:45:57PM -0700, Andrey Smirnov wrote: > Add bindings for Microchip UCS1002 Programmable USB Port Power > Controller with Charger Emulation. > > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> > Cc: Enric Balletbo Serra <enric.balletbo@collabora.com> > Cc: Chris Healy <cphealy@gmail.com> > Cc: Lucas Stach <l.stach@pengutronix.de> > Cc: Fabio Estevam <fabio.estevam@nxp.com> > Cc: Guenter Roeck <linux@roeck-us.net> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: devicetree@vger.kernel.org > Cc: Sebastian Reichel <sre@kernel.org> > Cc: linux-kernel@vger.kernel.org > Cc: linux-pm@vger.kernel.org > --- > .../power/supply/microchip,ucs1002.txt | 27 +++++++++++++++++++ > 1 file changed, 27 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/supply/microchip,ucs1002.txt > > diff --git a/Documentation/devicetree/bindings/power/supply/microchip,ucs1002.txt b/Documentation/devicetree/bindings/power/supply/microchip,ucs1002.txt > new file mode 100644 > index 000000000000..021fd7aba75e > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/supply/microchip,ucs1002.txt > @@ -0,0 +1,27 @@ > +Microchip UCS1002 USB Port Power Controller > + > +Required properties: > +- compatible : Should be "microchip,ucs1002"; > +- reg : I2C slave address > + > +Optional properties: > +- interrupts-extended : A list of interrupts lines present (could be either > + corresponding to A_DET# pin, ALERT# pin, or both) > +- interrupt-names : A list of interrupt names. Should contain (if > + present): > + - "a_det" for line connected to A_DET# pin > + - "alert" for line connected to ALERT# pin > + Both are expected to be IRQ_TYPE_EDGE_BOTH > +Example: > + > +&i2c3 { > + charger@32 { > + compatible = "microchip,ucs1002"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_ucs1002_pins>; Document the above ? Or is that optional ? [ I am not a DT expert, so feel free to ignore. ] Guenter > + reg = <0x32>; > + interrupts-extended = <&gpio5 2 IRQ_TYPE_EDGE_BOTH>, > + <&gpio3 21 IRQ_TYPE_EDGE_BOTH>; > + interrupt-names = "a_det", "alert"; > + }; > +}; > -- > 2.20.1 > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v4 3/3] dt-bindings: power: supply: Add bindings for Microchip UCS1002 2019-04-30 16:15 ` Guenter Roeck @ 2019-04-30 22:32 ` Rob Herring 2019-04-30 23:28 ` Guenter Roeck 0 siblings, 1 reply; 4+ messages in thread From: Rob Herring @ 2019-04-30 22:32 UTC (permalink / raw) To: Guenter Roeck Cc: Andrey Smirnov, linux-pm, Enric Balletbo Serra, Chris Healy, Lucas Stach, Fabio Estevam, devicetree, Sebastian Reichel, linux-kernel On Tue, Apr 30, 2019 at 09:15:42AM -0700, Guenter Roeck wrote: > On Mon, Apr 29, 2019 at 11:45:57PM -0700, Andrey Smirnov wrote: > > Add bindings for Microchip UCS1002 Programmable USB Port Power > > Controller with Charger Emulation. > > > > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> > > Cc: Enric Balletbo Serra <enric.balletbo@collabora.com> > > Cc: Chris Healy <cphealy@gmail.com> > > Cc: Lucas Stach <l.stach@pengutronix.de> > > Cc: Fabio Estevam <fabio.estevam@nxp.com> > > Cc: Guenter Roeck <linux@roeck-us.net> > > Cc: Rob Herring <robh+dt@kernel.org> > > Cc: devicetree@vger.kernel.org > > Cc: Sebastian Reichel <sre@kernel.org> > > Cc: linux-kernel@vger.kernel.org > > Cc: linux-pm@vger.kernel.org > > --- > > .../power/supply/microchip,ucs1002.txt | 27 +++++++++++++++++++ > > 1 file changed, 27 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/power/supply/microchip,ucs1002.txt > > > > diff --git a/Documentation/devicetree/bindings/power/supply/microchip,ucs1002.txt b/Documentation/devicetree/bindings/power/supply/microchip,ucs1002.txt > > new file mode 100644 > > index 000000000000..021fd7aba75e > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/power/supply/microchip,ucs1002.txt > > @@ -0,0 +1,27 @@ > > +Microchip UCS1002 USB Port Power Controller > > + > > +Required properties: > > +- compatible : Should be "microchip,ucs1002"; > > +- reg : I2C slave address > > + > > +Optional properties: > > +- interrupts-extended : A list of interrupts lines present (could be either > > + corresponding to A_DET# pin, ALERT# pin, or both) Just make this 'interrupts'. Support for 'interrupts-extended' is implied. With that, Reviewed-by: Rob Herring <robh@kernel.org> > > +- interrupt-names : A list of interrupt names. Should contain (if > > + present): > > + - "a_det" for line connected to A_DET# pin > > + - "alert" for line connected to ALERT# pin > > + Both are expected to be IRQ_TYPE_EDGE_BOTH > > +Example: > > + > > +&i2c3 { > > + charger@32 { > > + compatible = "microchip,ucs1002"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_ucs1002_pins>; > > Document the above ? Or is that optional ? I would have said to document this, but recently we had some discussion about allowing this to be implied when there's only a 'default' entry. We'll add it automatically for schemas. Rob ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v4 3/3] dt-bindings: power: supply: Add bindings for Microchip UCS1002 2019-04-30 22:32 ` Rob Herring @ 2019-04-30 23:28 ` Guenter Roeck 0 siblings, 0 replies; 4+ messages in thread From: Guenter Roeck @ 2019-04-30 23:28 UTC (permalink / raw) To: Rob Herring Cc: Andrey Smirnov, linux-pm, Enric Balletbo Serra, Chris Healy, Lucas Stach, Fabio Estevam, devicetree, Sebastian Reichel, linux-kernel On 4/30/19 3:32 PM, Rob Herring wrote: > On Tue, Apr 30, 2019 at 09:15:42AM -0700, Guenter Roeck wrote: >> On Mon, Apr 29, 2019 at 11:45:57PM -0700, Andrey Smirnov wrote: >>> Add bindings for Microchip UCS1002 Programmable USB Port Power >>> Controller with Charger Emulation. >>> >>> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> >>> Cc: Enric Balletbo Serra <enric.balletbo@collabora.com> >>> Cc: Chris Healy <cphealy@gmail.com> >>> Cc: Lucas Stach <l.stach@pengutronix.de> >>> Cc: Fabio Estevam <fabio.estevam@nxp.com> >>> Cc: Guenter Roeck <linux@roeck-us.net> >>> Cc: Rob Herring <robh+dt@kernel.org> >>> Cc: devicetree@vger.kernel.org >>> Cc: Sebastian Reichel <sre@kernel.org> >>> Cc: linux-kernel@vger.kernel.org >>> Cc: linux-pm@vger.kernel.org >>> --- >>> .../power/supply/microchip,ucs1002.txt | 27 +++++++++++++++++++ >>> 1 file changed, 27 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/power/supply/microchip,ucs1002.txt >>> >>> diff --git a/Documentation/devicetree/bindings/power/supply/microchip,ucs1002.txt b/Documentation/devicetree/bindings/power/supply/microchip,ucs1002.txt >>> new file mode 100644 >>> index 000000000000..021fd7aba75e >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/power/supply/microchip,ucs1002.txt >>> @@ -0,0 +1,27 @@ >>> +Microchip UCS1002 USB Port Power Controller >>> + >>> +Required properties: >>> +- compatible : Should be "microchip,ucs1002"; >>> +- reg : I2C slave address >>> + >>> +Optional properties: >>> +- interrupts-extended : A list of interrupts lines present (could be either >>> + corresponding to A_DET# pin, ALERT# pin, or both) > > Just make this 'interrupts'. Support for 'interrupts-extended' is > implied. > > With that, > > Reviewed-by: Rob Herring <robh@kernel.org> > >>> +- interrupt-names : A list of interrupt names. Should contain (if >>> + present): >>> + - "a_det" for line connected to A_DET# pin >>> + - "alert" for line connected to ALERT# pin >>> + Both are expected to be IRQ_TYPE_EDGE_BOTH >>> +Example: >>> + >>> +&i2c3 { >>> + charger@32 { >>> + compatible = "microchip,ucs1002"; >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&pinctrl_ucs1002_pins>; >> >> Document the above ? Or is that optional ? > > I would have said to document this, but recently we had some discussion > about allowing this to be implied when there's only a 'default' entry. > We'll add it automatically for schemas. > Good to know. Thanks for the information! Guenter ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-30 23:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190430064557.28469-1-andrew.smirnov@gmail.com>
2019-04-30 6:45 ` [PATCH v4 3/3] dt-bindings: power: supply: Add bindings for Microchip UCS1002 Andrey Smirnov
2019-04-30 16:15 ` Guenter Roeck
2019-04-30 22:32 ` Rob Herring
2019-04-30 23:28 ` Guenter Roeck
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox