Device Tree nodes ending with -supply

Device Tree nodes ending with -supply

[Maxime Ripard]

Hi Rob,

I've noticed that you recently added support to validate the *-supply
properties in the dt-schema tools.

However, we have a family of PMIC that are exposing a bunch of power
supplies (battery, AC, USB, etc) to know what is currently powering
the board.

All these various supplies are exposed as children nodes of the PMIC
itself, and they are named *-power-supply. For an example, you can
look at:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/axp209.dtsi#n56

Now, those are obviously not properties, and yet the current dt-schema
schemas are trying to validate them.

I'm not really sure how to fix that. Changing the node names seems
like an obvious solution, but they seem to be what they should be. Can
we reduce the scope of the validation to only match properties (ie
arrays?) and not the nodes (objects?)

Thanks!
Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: Device Tree nodes ending with -supply

[Rob Herring]

On Mon, May 20, 2019 at 10:51 AM Maxime Ripard
<maxime.ripard@bootlin.com> wrote:
>
> Hi Rob,
>
> I've noticed that you recently added support to validate the *-supply
> properties in the dt-schema tools.
>
> However, we have a family of PMIC that are exposing a bunch of power
> supplies (battery, AC, USB, etc) to know what is currently powering
> the board.
>
> All these various supplies are exposed as children nodes of the PMIC
> itself, and they are named *-power-supply. For an example, you can
> look at:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/axp209.dtsi#n56
>
> Now, those are obviously not properties, and yet the current dt-schema
> schemas are trying to validate them.
>
> I'm not really sure how to fix that. Changing the node names seems
> like an obvious solution, but they seem to be what they should be. Can
> we reduce the scope of the validation to only match properties (ie
> arrays?) and not the nodes (objects?)

While I'd prefer to avoid that node name, I fixed it with the fancy
new if/then schema:

  ".*-supply$":
    if:
      not: { type: object }
    then:
      $ref: "types.yaml#/definitions/phandle"

I'll push it out shortly.

Rob

Re: Device Tree nodes ending with -supply

[Maxime Ripard]

[-- Attachment #1.1: Type: text/plain, Size: 1450 bytes --]

On Mon, May 20, 2019 at 02:46:11PM -0500, Rob Herring wrote:
> On Mon, May 20, 2019 at 10:51 AM Maxime Ripard
> <maxime.ripard@bootlin.com> wrote:
> >
> > Hi Rob,
> >
> > I've noticed that you recently added support to validate the *-supply
> > properties in the dt-schema tools.
> >
> > However, we have a family of PMIC that are exposing a bunch of power
> > supplies (battery, AC, USB, etc) to know what is currently powering
> > the board.
> >
> > All these various supplies are exposed as children nodes of the PMIC
> > itself, and they are named *-power-supply. For an example, you can
> > look at:
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/axp209.dtsi#n56
> >
> > Now, those are obviously not properties, and yet the current dt-schema
> > schemas are trying to validate them.
> >
> > I'm not really sure how to fix that. Changing the node names seems
> > like an obvious solution, but they seem to be what they should be. Can
> > we reduce the scope of the validation to only match properties (ie
> > arrays?) and not the nodes (objects?)
>
> While I'd prefer to avoid that node name, I fixed it with the fancy
> new if/then schema:
>
>   ".*-supply$":
>     if:
>       not: { type: object }
>     then:
>       $ref: "types.yaml#/definitions/phandle"
>
> I'll push it out shortly.

Great, thanks!
Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel