* [PATCH v8 2/3] dt-bindings: serial: Add reg-io-width compatible [not found] ` <20200420013300.17249-1-hyunki00.koo@samsung.com> @ 2020-04-20 1:32 ` Hyunki Koo 2020-04-30 15:12 ` Rob Herring 2020-04-20 23:35 ` [PATCH v8 0/3] 32-bit access for TX/RX hold registers for samsung_tty driver Hyunki Koo 1 sibling, 1 reply; 6+ messages in thread From: Hyunki Koo @ 2020-04-20 1:32 UTC (permalink / raw) To: Greg Kroah-Hartman, Rob Herring, linux-serial, devicetree, linux-kernel Cc: hyunki00.koo Add a description for reg-io-width options for the samsung serial UART peripheral. Signed-off-by: Hyunki Koo <hyunki00.koo@samsung.com> --- Documentation/devicetree/bindings/serial/samsung_uart.yaml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/serial/samsung_uart.yaml b/Documentation/devicetree/bindings/serial/samsung_uart.yaml index 9d2ce347875b..a57b1233c691 100644 --- a/Documentation/devicetree/bindings/serial/samsung_uart.yaml +++ b/Documentation/devicetree/bindings/serial/samsung_uart.yaml @@ -29,6 +29,14 @@ properties: reg: maxItems: 1 + reg-io-width: + description: | + The size (in bytes) of the IO accesses that should be performed + on the device. + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32 + - enum: [ 1, 4 ] + clocks: minItems: 2 maxItems: 5 -- 2.15.0.rc1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v8 2/3] dt-bindings: serial: Add reg-io-width compatible 2020-04-20 1:32 ` [PATCH v8 2/3] dt-bindings: serial: Add reg-io-width compatible Hyunki Koo @ 2020-04-30 15:12 ` Rob Herring 0 siblings, 0 replies; 6+ messages in thread From: Rob Herring @ 2020-04-30 15:12 UTC (permalink / raw) To: Hyunki Koo Cc: Greg Kroah-Hartman, Rob Herring, linux-serial, devicetree, linux-kernel, hyunki00.koo On Mon, 20 Apr 2020 10:32:57 +0900, Hyunki Koo wrote: > Add a description for reg-io-width options for the samsung serial > UART peripheral. > > Signed-off-by: Hyunki Koo <hyunki00.koo@samsung.com> > --- > Documentation/devicetree/bindings/serial/samsung_uart.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v8 0/3] 32-bit access for TX/RX hold registers for samsung_tty driver [not found] ` <20200420013300.17249-1-hyunki00.koo@samsung.com> 2020-04-20 1:32 ` [PATCH v8 2/3] dt-bindings: serial: Add reg-io-width compatible Hyunki Koo @ 2020-04-20 23:35 ` Hyunki Koo 2020-04-24 0:40 ` Hyunki Koo 1 sibling, 1 reply; 6+ messages in thread From: Hyunki Koo @ 2020-04-20 23:35 UTC (permalink / raw) To: gregkh, robh+dt, linux-serial, devicetree, linux-kernel; +Cc: hyunki00.koo Change in v8: - spit into 3 patch [1/3] create the new functions with no functional change to the code as-is. Replace rd_regb/wr_regb with rd_reg/wr_reg for general usage. [2/3] add the new binding reg-io-width in device tree [3/3] add the new funtinality of rd_reg / wr_reg and wr_reg_barrier to support 32-bit access for the TX/RX hold registers UTXH and URXH. Change in v7: - [1/2] correct build error on running 'make dt_binding_check' Documentation/devicetree/bindings/serial/samsung_uart.yaml: mapping values are not allowed in this context in "<unicode string>", line 36, column 13 Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/serial/samsung_uart.example.dts' failed make[1]: *** [Documentation/devicetree/bindings/serial/samsung_uart.example.dts] Error 1 make[1]: *** Waiting for unfinished jobs.... Makefile:1262: recipe for target 'dt_binding_check' failed make: *** [dt_binding_check] Error 2 - [2/2] add commit message of reviewed by and tested by in commit message Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Tested on Odroid HC1 (Exynos5422): Tested-by: Krzysztof Kozlowski <krzk@kernel.org> Change in v6: - [2/2] clean description of reg-io-width allOf is not needed. Just enum [1, 2] is enough. Changes in v5: - spit into 2 patch, newly added patch for dt-binding [1/2] newly added dt-binding and go as first patch in this series. [2/2] go as second patch in this series. Changes in v4: - correct variable types and change misleading function name Changes in v3: - line 2031: remove redundant init value for ourport->port.iotype Changes in v2: - line 954 : change rd_regl to rd_reg in for backward compatibility. - line 2031: Add init value for ourport->port.iotype to UPIO_MEM Hyunki Koo (3): serial: samsung: Replace rd_regb/wr_regb with rd_reg/wr_reg dt-bindings: serial: Add reg-io-width compatible tty: samsung_tty: 32-bit access for TX/RX hold registers .../devicetree/bindings/serial/samsung_uart.yaml | 8 +++ drivers/tty/serial/samsung_tty.c | 76 ++++++++++++++++++---- 2 files changed, 72 insertions(+), 12 deletions(-) -- 2.15.0.rc1 ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v8 0/3] 32-bit access for TX/RX hold registers for samsung_tty driver 2020-04-20 23:35 ` [PATCH v8 0/3] 32-bit access for TX/RX hold registers for samsung_tty driver Hyunki Koo @ 2020-04-24 0:40 ` Hyunki Koo 2020-04-24 5:37 ` Greg KH 0 siblings, 1 reply; 6+ messages in thread From: Hyunki Koo @ 2020-04-24 0:40 UTC (permalink / raw) To: gregkh, robh+dt, linux-serial, devicetree, linux-kernel On Sat, April 21, 2020 at 08:36:00 AM +0900, Hyunki Koo wrote: > > Change in v8: > - spit into 3 patch > [1/3] create the new functions with no functional change to the code as- > is. > Replace rd_regb/wr_regb with rd_reg/wr_reg for general usage. > [2/3] add the new binding reg-io-width in device tree > [3/3] add the new funtinality of rd_reg / wr_reg and wr_reg_barrier > to support 32-bit access for the TX/RX hold registers UTXH and URXH. > > Change in v7: > - [1/2] correct build error on running 'make dt_binding_check' > Documentation/devicetree/bindings/serial/samsung_uart.yaml: mapping > values are not allowed in this context > in "<unicode string>", line 36, column 13 > Documentation/devicetree/bindings/Makefile:12: recipe for target > 'Documentation/devicetree/bindings/serial/samsung_uart.example.dts' > failed > make[1]: *** > [Documentation/devicetree/bindings/serial/samsung_uart.example.dts] > Error 1 > make[1]: *** Waiting for unfinished jobs.... > Makefile:1262: recipe for target 'dt_binding_check' failed > make: *** [dt_binding_check] Error 2 > - [2/2] add commit message of reviewed by and tested by in commit > message > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> > Tested on Odroid HC1 (Exynos5422): > Tested-by: Krzysztof Kozlowski <krzk@kernel.org> > > Change in v6: > - [2/2] clean description of reg-io-width > allOf is not needed. Just enum [1, 2] is enough. > > Changes in v5: > - spit into 2 patch, newly added patch for dt-binding > [1/2] newly added dt-binding and go as first patch in this series. > [2/2] go as second patch in this series. > > Changes in v4: > - correct variable types and change misleading function name > > Changes in v3: > - line 2031: remove redundant init value for ourport->port.iotype > > Changes in v2: > - line 954 : change rd_regl to rd_reg in for backward compatibility. > - line 2031: Add init value for ourport->port.iotype to UPIO_MEM > > > Hyunki Koo (3): > serial: samsung: Replace rd_regb/wr_regb with rd_reg/wr_reg > dt-bindings: serial: Add reg-io-width compatible > tty: samsung_tty: 32-bit access for TX/RX hold registers > > .../devicetree/bindings/serial/samsung_uart.yaml | 8 +++ > drivers/tty/serial/samsung_tty.c | 76 ++++++++++++++++++--- > - > 2 files changed, 72 insertions(+), 12 deletions(-) > > -- > 2.15.0.rc1 Hi Greg KH Can I ask is this series patch are acceptable or not? Do you think, I have to do any further action for this patch? ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v8 0/3] 32-bit access for TX/RX hold registers for samsung_tty driver 2020-04-24 0:40 ` Hyunki Koo @ 2020-04-24 5:37 ` Greg KH 2020-04-26 23:15 ` Hyunki Koo 0 siblings, 1 reply; 6+ messages in thread From: Greg KH @ 2020-04-24 5:37 UTC (permalink / raw) To: Hyunki Koo; +Cc: robh+dt, linux-serial, devicetree, linux-kernel On Fri, Apr 24, 2020 at 09:40:18AM +0900, Hyunki Koo wrote: > On Sat, April 21, 2020 at 08:36:00 AM +0900, Hyunki Koo wrote: > > > > Change in v8: > > - spit into 3 patch > > [1/3] create the new functions with no functional change to the code as- > > is. > > Replace rd_regb/wr_regb with rd_reg/wr_reg for general usage. > > [2/3] add the new binding reg-io-width in device tree > > [3/3] add the new funtinality of rd_reg / wr_reg and wr_reg_barrier > > to support 32-bit access for the TX/RX hold registers UTXH and URXH. > > > > Change in v7: > > - [1/2] correct build error on running 'make dt_binding_check' > > Documentation/devicetree/bindings/serial/samsung_uart.yaml: mapping > > values are not allowed in this context > > in "<unicode string>", line 36, column 13 > > Documentation/devicetree/bindings/Makefile:12: recipe for target > > 'Documentation/devicetree/bindings/serial/samsung_uart.example.dts' > > failed > > make[1]: *** > > [Documentation/devicetree/bindings/serial/samsung_uart.example.dts] > > Error 1 > > make[1]: *** Waiting for unfinished jobs.... > > Makefile:1262: recipe for target 'dt_binding_check' failed > > make: *** [dt_binding_check] Error 2 > > - [2/2] add commit message of reviewed by and tested by in commit > > message > > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> > > Tested on Odroid HC1 (Exynos5422): > > Tested-by: Krzysztof Kozlowski <krzk@kernel.org> > > > > Change in v6: > > - [2/2] clean description of reg-io-width > > allOf is not needed. Just enum [1, 2] is enough. > > > > Changes in v5: > > - spit into 2 patch, newly added patch for dt-binding > > [1/2] newly added dt-binding and go as first patch in this series. > > [2/2] go as second patch in this series. > > > > Changes in v4: > > - correct variable types and change misleading function name > > > > Changes in v3: > > - line 2031: remove redundant init value for ourport->port.iotype > > > > Changes in v2: > > - line 954 : change rd_regl to rd_reg in for backward compatibility. > > - line 2031: Add init value for ourport->port.iotype to UPIO_MEM > > > > > > Hyunki Koo (3): > > serial: samsung: Replace rd_regb/wr_regb with rd_reg/wr_reg > > dt-bindings: serial: Add reg-io-width compatible > > tty: samsung_tty: 32-bit access for TX/RX hold registers > > > > .../devicetree/bindings/serial/samsung_uart.yaml | 8 +++ > > drivers/tty/serial/samsung_tty.c | 76 ++++++++++++++++++--- > > - > > 2 files changed, 72 insertions(+), 12 deletions(-) > > > > -- > > 2.15.0.rc1 > > Hi Greg KH > > Can I ask is this series patch are acceptable or not? > Do you think, I have to do any further action for this patch? > It's been 3 days, give us a chance please... Also, I need to wait for the dt patch to be reviewed first before I can take any of this, so that's up to the DT maintainers. thanks, greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v8 0/3] 32-bit access for TX/RX hold registers for samsung_tty driver 2020-04-24 5:37 ` Greg KH @ 2020-04-26 23:15 ` Hyunki Koo 0 siblings, 0 replies; 6+ messages in thread From: Hyunki Koo @ 2020-04-26 23:15 UTC (permalink / raw) To: 'Greg KH'; +Cc: robh+dt, linux-serial, devicetree, linux-kernel On Fri, Apr 24, 2020 at 02:37:18PM +0900, Greg KH wrote: > On Fri, Apr 24, 2020 at 09:40:18AM +0900, Hyunki Koo wrote: > > On Sat, April 21, 2020 at 08:36:00 AM +0900, Hyunki Koo wrote: > > > > > > Change in v8: > > > - spit into 3 patch > > > [1/3] create the new functions with no functional change to the > > > code as- is. > > > Replace rd_regb/wr_regb with rd_reg/wr_reg for general usage. > > > [2/3] add the new binding reg-io-width in device tree > > > [3/3] add the new funtinality of rd_reg / wr_reg and wr_reg_barrier > > > to support 32-bit access for the TX/RX hold registers UTXH and > URXH. > > > > > > Change in v7: > > > - [1/2] correct build error on running 'make dt_binding_check' > > > Documentation/devicetree/bindings/serial/samsung_uart.yaml: > mapping > > > values are not allowed in this context > > > in "<unicode string>", line 36, column 13 > > > Documentation/devicetree/bindings/Makefile:12: recipe for target > > > > 'Documentation/devicetree/bindings/serial/samsung_uart.example.dts' > > > failed > > > make[1]: *** > > > > [Documentation/devicetree/bindings/serial/samsung_uart.example.dts] > > > Error 1 > > > make[1]: *** Waiting for unfinished jobs.... > > > Makefile:1262: recipe for target 'dt_binding_check' failed > > > make: *** [dt_binding_check] Error 2 > > > - [2/2] add commit message of reviewed by and tested by in commit > > > message > > > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> > > > Tested on Odroid HC1 (Exynos5422): > > > Tested-by: Krzysztof Kozlowski <krzk@kernel.org> > > > > > > Change in v6: > > > - [2/2] clean description of reg-io-width > > > allOf is not needed. Just enum [1, 2] is enough. > > > > > > Changes in v5: > > > - spit into 2 patch, newly added patch for dt-binding > > > [1/2] newly added dt-binding and go as first patch in this series. > > > [2/2] go as second patch in this series. > > > > > > Changes in v4: > > > - correct variable types and change misleading function name > > > > > > Changes in v3: > > > - line 2031: remove redundant init value for ourport->port.iotype > > > > > > Changes in v2: > > > - line 954 : change rd_regl to rd_reg in for backward compatibility. > > > - line 2031: Add init value for ourport->port.iotype to UPIO_MEM > > > > > > > > > Hyunki Koo (3): > > > serial: samsung: Replace rd_regb/wr_regb with rd_reg/wr_reg > > > dt-bindings: serial: Add reg-io-width compatible > > > tty: samsung_tty: 32-bit access for TX/RX hold registers > > > > > > .../devicetree/bindings/serial/samsung_uart.yaml | 8 +++ > > > drivers/tty/serial/samsung_tty.c | 76 > ++++++++++++++++++--- > > > - > > > 2 files changed, 72 insertions(+), 12 deletions(-) > > > > > > -- > > > 2.15.0.rc1 > > > > Hi Greg KH > > > > Can I ask is this series patch are acceptable or not? > > Do you think, I have to do any further action for this patch? > > > > It's been 3 days, give us a chance please... > > Also, I need to wait for the dt patch to be reviewed first before I can take > any of this, so that's up to the DT maintainers. > > thanks, > > greg k-h Sorry to disturb you and Thank you for your answer, I will wait. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-04-30 15:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20200420013325epcas2p13f65e6bc8ba68f89c805704830144870@epcas2p1.samsung.com>
[not found] ` <20200420013300.17249-1-hyunki00.koo@samsung.com>
2020-04-20 1:32 ` [PATCH v8 2/3] dt-bindings: serial: Add reg-io-width compatible Hyunki Koo
2020-04-30 15:12 ` Rob Herring
2020-04-20 23:35 ` [PATCH v8 0/3] 32-bit access for TX/RX hold registers for samsung_tty driver Hyunki Koo
2020-04-24 0:40 ` Hyunki Koo
2020-04-24 5:37 ` Greg KH
2020-04-26 23:15 ` Hyunki Koo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox