From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Pavel Tatashin <pasha.tatashin@soleen.com>
Cc: jmorris@namei.org, sashal@kernel.org,
linux-kernel@vger.kernel.org, pmladek@suse.com,
sergey.senozhatsky@gmail.com, rostedt@goodmis.org,
keescook@chromium.org, anton@enomsg.org, ccross@android.com,
tony.luck@intel.com, robh+dt@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v1 1/3] printk: honor the max_reason field in kmsg_dumper
Date: Tue, 5 May 2020 10:02:19 +0900 [thread overview]
Message-ID: <20200505010219.GA2282345@jagdpanzerIV.localdomain> (raw)
In-Reply-To: <20200502143555.543636-2-pasha.tatashin@soleen.com>
On (20/05/02 10:35), Pavel Tatashin wrote:
[..]
> +static bool always_kmsg_dump;
> +module_param_named(always_kmsg_dump, always_kmsg_dump, bool, S_IRUGO | S_IWUSR);
>
> /**
> * kmsg_dump_register - register a kernel log dumper.
> @@ -3106,6 +3108,12 @@ int kmsg_dump_register(struct kmsg_dumper *dumper)
> spin_lock_irqsave(&dump_list_lock, flags);
> /* Don't allow registering multiple times */
> if (!dumper->registered) {
> + if (!dumper->max_reason) {
> + if (always_kmsg_dump)
> + dumper->max_reason = KMSG_DUMP_MAX;
> + else
> + dumper->max_reason = KMSG_DUMP_OOPS;
> + }
> dumper->registered = 1;
> list_add_tail_rcu(&dumper->list, &dump_list);
> err = 0;
[..]
> @@ -3157,12 +3162,9 @@ void kmsg_dump(enum kmsg_dump_reason reason)
> struct kmsg_dumper *dumper;
> unsigned long flags;
>
> - if ((reason > KMSG_DUMP_OOPS) && !always_kmsg_dump)
> - return;
> -
> rcu_read_lock();
> list_for_each_entry_rcu(dumper, &dump_list, list) {
> - if (dumper->max_reason && reason > dumper->max_reason)
> + if (reason > dumper->max_reason)
> continue;
Why always_kmsg_dump check moved from the dumper loop entry point to the
dumper registration code? What if the user change always_ksmsg_dump
dynamically via sysfs?
-ss
next prev parent reply other threads:[~2020-05-05 1:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-02 14:35 [PATCH v1 0/3] allow ramoops to collect all kmesg_dump events Pavel Tatashin
2020-05-02 14:35 ` [PATCH v1 1/3] printk: honor the max_reason field in kmsg_dumper Pavel Tatashin
2020-05-04 17:15 ` Steven Rostedt
2020-05-04 17:56 ` Pavel Tatashin
2020-05-04 18:12 ` Kees Cook
2020-05-04 18:40 ` Pavel Tatashin
2020-05-05 1:02 ` Sergey Senozhatsky [this message]
2020-05-05 2:52 ` Pavel Tatashin
2020-05-05 3:12 ` Pavel Tatashin
2020-05-05 4:21 ` Pavel Tatashin
2020-05-05 10:50 ` Sergey Senozhatsky
2020-05-02 14:35 ` [PATCH v1 2/3] pstore/ram: allow to dump kmesg during regular reboot Pavel Tatashin
2020-05-04 19:29 ` Kees Cook
2020-05-04 20:30 ` Pavel Tatashin
2020-05-04 20:54 ` Kees Cook
2020-05-02 14:35 ` [PATCH v1 3/3] ramoops: add dump_all optional field to ramoops DT node Pavel Tatashin
2020-05-04 19:29 ` Kees Cook
2020-05-04 20:00 ` Pavel Tatashin
2020-05-05 15:14 ` Pavel Tatashin
2020-05-04 18:14 ` [PATCH v1 0/3] allow ramoops to collect all kmesg_dump events Kees Cook
2020-05-04 18:47 ` Pavel Tatashin
2020-05-04 19:12 ` Kees Cook
2020-05-04 19:17 ` Pavel Tatashin
2020-05-04 19:30 ` Kees Cook
2020-05-04 20:00 ` Pavel Tatashin
2020-05-05 12:36 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200505010219.GA2282345@jagdpanzerIV.localdomain \
--to=sergey.senozhatsky@gmail.com \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=devicetree@vger.kernel.org \
--cc=jmorris@namei.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pasha.tatashin@soleen.com \
--cc=pmladek@suse.com \
--cc=robh+dt@kernel.org \
--cc=rostedt@goodmis.org \
--cc=sashal@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox