From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Pavel Tatashin <pasha.tatashin@soleen.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
James Morris <jmorris@namei.org>, Sasha Levin <sashal@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Kees Cook <keescook@chromium.org>,
anton@enomsg.org, ccross@android.com,
Tony Luck <tony.luck@intel.com>,
robh+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v1 1/3] printk: honor the max_reason field in kmsg_dumper
Date: Tue, 5 May 2020 19:50:59 +0900 [thread overview]
Message-ID: <20200505105059.GA2353374@jagdpanzerIV.localdomain> (raw)
In-Reply-To: <CA+CK2bAPhXL_p2WkDaLshw2U13KbdU5NMH6qJsy8YTq3rwZwBg@mail.gmail.com>
On (20/05/05 00:21), Pavel Tatashin wrote:
> > > I changed it to make code cleaner: for such basic operation there are
> > > too many conditions if we will keep it inside the kmsg_dump().
> > > However, if being able to set always_kmsg_dump dynamically during
> > > runtime is deemed important, I can change it back to be checked in
> > > kmsg_dump.
> >
> > If you agree that we do not have to modify this variable dynamically,
> > I will also change the permission here:
> > module_param_named(always_kmsg_dump, always_kmsg_dump, bool, S_IRUGO | S_IWUSR);
>
> Hi Sergey,
Hi Pavel,
> After thinking about this. I will move this logic back to kmsg_dump(),
> to keep the current behavior where kmsg_dump can be modified during
> runtime.
Agreed. I think that sysfs knobs and user-visible API need to preserve
their behaviour. There is a deprecation protocol, but usually it takes
many years of WARN_ON() and pr_err("this knob will be removed") before
we can change anything. E.g. sysctl has been deprecated for about a
decade IIRC before it was actually removed.
-ss
next prev parent reply other threads:[~2020-05-05 10:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-02 14:35 [PATCH v1 0/3] allow ramoops to collect all kmesg_dump events Pavel Tatashin
2020-05-02 14:35 ` [PATCH v1 1/3] printk: honor the max_reason field in kmsg_dumper Pavel Tatashin
2020-05-04 17:15 ` Steven Rostedt
2020-05-04 17:56 ` Pavel Tatashin
2020-05-04 18:12 ` Kees Cook
2020-05-04 18:40 ` Pavel Tatashin
2020-05-05 1:02 ` Sergey Senozhatsky
2020-05-05 2:52 ` Pavel Tatashin
2020-05-05 3:12 ` Pavel Tatashin
2020-05-05 4:21 ` Pavel Tatashin
2020-05-05 10:50 ` Sergey Senozhatsky [this message]
2020-05-02 14:35 ` [PATCH v1 2/3] pstore/ram: allow to dump kmesg during regular reboot Pavel Tatashin
2020-05-04 19:29 ` Kees Cook
2020-05-04 20:30 ` Pavel Tatashin
2020-05-04 20:54 ` Kees Cook
2020-05-02 14:35 ` [PATCH v1 3/3] ramoops: add dump_all optional field to ramoops DT node Pavel Tatashin
2020-05-04 19:29 ` Kees Cook
2020-05-04 20:00 ` Pavel Tatashin
2020-05-05 15:14 ` Pavel Tatashin
2020-05-04 18:14 ` [PATCH v1 0/3] allow ramoops to collect all kmesg_dump events Kees Cook
2020-05-04 18:47 ` Pavel Tatashin
2020-05-04 19:12 ` Kees Cook
2020-05-04 19:17 ` Pavel Tatashin
2020-05-04 19:30 ` Kees Cook
2020-05-04 20:00 ` Pavel Tatashin
2020-05-05 12:36 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200505105059.GA2353374@jagdpanzerIV.localdomain \
--to=sergey.senozhatsky@gmail.com \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=devicetree@vger.kernel.org \
--cc=jmorris@namei.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pasha.tatashin@soleen.com \
--cc=pmladek@suse.com \
--cc=robh+dt@kernel.org \
--cc=rostedt@goodmis.org \
--cc=sashal@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox