From: David Miller <davem@davemloft.net>
To: fugang.duan@nxp.com
Cc: andrew@lunn.ch, martin.fuzzey@flowbird.group,
s.hauer@pengutronix.de, netdev@vger.kernel.org,
robh+dt@kernel.org, shawnguo@kernel.org,
devicetree@vger.kernel.org, kuba@kernel.org
Subject: Re: [PATCH net v3 0/4] net: ethernet: fec: move GPR reigster offset and bit into DT
Date: Tue, 26 May 2020 20:22:00 -0700 (PDT) [thread overview]
Message-ID: <20200526.202200.2254002991885460192.davem@davemloft.net> (raw)
In-Reply-To: <1590424033-16906-1-git-send-email-fugang.duan@nxp.com>
From: fugang.duan@nxp.com
Date: Tue, 26 May 2020 00:27:09 +0800
> From: Fugang Duan <fugang.duan@nxp.com>
>
> The commit da722186f654 (net: fec: set GPR bit on suspend by
> DT configuration) set the GPR reigster offset and bit in driver
> for wol feature support.
>
> It brings trouble to enable wol feature on imx6sx/imx6ul/imx7d
> platforms that have multiple ethernet instances with different
> GPR bit for stop mode control. So the patch set is to move GPR
> register offset and bit define into DT, and enable imx6q/imx6dl
> imx6qp/imx6sx/imx6ul/imx7d stop mode support.
>
> Currently, below NXP i.MX boards support wol:
> - imx6q/imx6dl/imx6qp sabresd
> - imx6sx sabreauto
> - imx7d sdb
>
> imx6q/imx6dl/imx6qp sabresd board dts file miss the property
> "fsl,magic-packet;", so patch#4 is to add the property for stop
> mode support.
>
>
> v1 -> v2:
> - driver: switch back to store the quirks bitmask in driver_data
> - dt-bindings: rename 'gpr' property string to 'fsl,stop-mode'
> - imx6/7 dtsi: add imx6sx/imx6ul/imx7d ethernet stop mode property
> v2 -> v3:
> - driver: suggested by Sascha Hauer, use a struct fec_devinfo for
> abstracting differences between different hardware variants,
> it can give more freedom to describe the differences.
> - imx6/7 dtsi: correct one typo pointed out by Andrew.
>
> Thanks Martin, Andrew and Sascha Hauer for the review.
Series applied to net-next, thanks.
prev parent reply other threads:[~2020-05-27 3:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 16:27 [PATCH net v3 0/4] net: ethernet: fec: move GPR reigster offset and bit into DT fugang.duan
2020-05-25 16:27 ` [PATCH net v3 1/4] net: ethernet: fec: move GPR register " fugang.duan
2020-05-25 16:27 ` [PATCH net v3 2/4] dt-bindings: fec: update the gpr property fugang.duan
2020-05-25 16:27 ` [PATCH net v3 3/4] ARM: dts: imx: add ethernet stop mode property fugang.duan
2020-05-25 16:27 ` [PATCH net v3 4/4] ARM: dts: imx6qdl-sabresd: enable fec wake-on-lan fugang.duan
2020-05-27 3:22 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200526.202200.2254002991885460192.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=fugang.duan@nxp.com \
--cc=kuba@kernel.org \
--cc=martin.fuzzey@flowbird.group \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox