* [PATCH v2] arm64: dts: zii-ultra: update MDIO speed and preamble device
@ 2020-07-08 0:32 Chris Healy
2020-07-08 0:41 ` Fabio Estevam
0 siblings, 1 reply; 3+ messages in thread
From: Chris Healy @ 2020-07-08 0:32 UTC (permalink / raw)
To: robh+dt, shawnguo, s.hauer, festevam, linux-imx, andrew.smirnov,
l.stach, devicetree, linux-arm-kernel, linux-kernel
Cc: Chris Healy
Update MDIO configuration with zii-ultra device to fully utilize
MDIO endpoint capabilities. Device supports 12.5MHz clock and
doesn't require MDIO preamble.
Signed-off-by: Chris Healy <cphealy@gmail.com>
---
v2:
- Fix subject line to reference zii-ultra:
- Get rid of "=<1>;" from suppress-preamble lines
arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
index 6a55165bd76a..98aa67a4c040 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
@@ -132,6 +132,8 @@
#address-cells = <1>;
#size-cells = <0>;
status = "okay";
+ suppress-preamble;
+ clock-frequency = <12500000>;
switch: switch@0 {
compatible = "marvell,mv88e6085";
--
2.21.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] arm64: dts: zii-ultra: update MDIO speed and preamble device
2020-07-08 0:32 [PATCH v2] arm64: dts: zii-ultra: update MDIO speed and preamble device Chris Healy
@ 2020-07-08 0:41 ` Fabio Estevam
2020-07-08 0:42 ` Chris Healy
0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2020-07-08 0:41 UTC (permalink / raw)
To: Chris Healy
Cc: Rob Herring, Shawn Guo, Sascha Hauer, NXP Linux Team,
Andrey Smirnov, Lucas Stach,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
linux-kernel
Hi Chris,
On Tue, Jul 7, 2020 at 9:32 PM Chris Healy <cphealy@gmail.com> wrote:
> #address-cells = <1>;
> #size-cells = <0>;
> status = "okay";
> + suppress-preamble;
> + clock-frequency = <12500000>;
Sorry, I missed this in the previous review.
The recommendation is to have status = okay as the last property.
Please move suppress-preamble and clock-frequency = <12500000> prior
to status = "okay"
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] arm64: dts: zii-ultra: update MDIO speed and preamble device
2020-07-08 0:41 ` Fabio Estevam
@ 2020-07-08 0:42 ` Chris Healy
0 siblings, 0 replies; 3+ messages in thread
From: Chris Healy @ 2020-07-08 0:42 UTC (permalink / raw)
To: Fabio Estevam
Cc: Rob Herring, Shawn Guo, Sascha Hauer, NXP Linux Team,
Andrey Smirnov, Lucas Stach,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
linux-kernel
On Tue, Jul 7, 2020 at 5:41 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Chris,
>
> On Tue, Jul 7, 2020 at 9:32 PM Chris Healy <cphealy@gmail.com> wrote:
>
> > #address-cells = <1>;
> > #size-cells = <0>;
> > status = "okay";
> > + suppress-preamble;
> > + clock-frequency = <12500000>;
>
> Sorry, I missed this in the previous review.
>
> The recommendation is to have status = okay as the last property.
>
> Please move suppress-preamble and clock-frequency = <12500000> prior
> to status = "okay"
Will do in the next version.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-08 0:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-08 0:32 [PATCH v2] arm64: dts: zii-ultra: update MDIO speed and preamble device Chris Healy
2020-07-08 0:41 ` Fabio Estevam
2020-07-08 0:42 ` Chris Healy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox