* [PATCH v2 4/4] soundwire: qcom: add v1.5.1 compatible
2020-09-05 17:39 [PATCH v2 0/4] soundwire: qcom: add support for mmio soundwire master Jonathan Marek
@ 2020-09-05 17:39 ` Jonathan Marek
2020-09-07 8:17 ` [PATCH v2 0/4] soundwire: qcom: add support for mmio soundwire master Srinivas Kandagatla
2020-09-07 14:17 ` Vinod Koul
2 siblings, 0 replies; 4+ messages in thread
From: Jonathan Marek @ 2020-09-05 17:39 UTC (permalink / raw)
To: linux-arm-msm
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Vinod Koul, Bard Liao,
Pierre-Louis Bossart, Sanyog Kale,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, moderated list:SOUNDWIRE SUBSYSTEM
Add a compatible string for HW version v1.5.1 on sm8250 SoCs.
Signed-off-by: Jonathan Marek <jonathan@marek.ca>
---
Documentation/devicetree/bindings/soundwire/qcom,sdw.txt | 1 +
drivers/soundwire/qcom.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/soundwire/qcom,sdw.txt b/Documentation/devicetree/bindings/soundwire/qcom,sdw.txt
index 436547f3b155..b104be131235 100644
--- a/Documentation/devicetree/bindings/soundwire/qcom,sdw.txt
+++ b/Documentation/devicetree/bindings/soundwire/qcom,sdw.txt
@@ -11,6 +11,7 @@ board specific bus parameters.
Example:
"qcom,soundwire-v1.3.0"
"qcom,soundwire-v1.5.0"
+ "qcom,soundwire-v1.5.1"
"qcom,soundwire-v1.6.0"
- reg:
Usage: required
diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
index ff28794868ca..41dda3b85413 100644
--- a/drivers/soundwire/qcom.c
+++ b/drivers/soundwire/qcom.c
@@ -888,6 +888,7 @@ static int qcom_swrm_remove(struct platform_device *pdev)
static const struct of_device_id qcom_swrm_of_match[] = {
{ .compatible = "qcom,soundwire-v1.3.0", },
+ { .compatible = "qcom,soundwire-v1.5.1", },
{/* sentinel */},
};
--
2.26.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2 0/4] soundwire: qcom: add support for mmio soundwire master
2020-09-05 17:39 [PATCH v2 0/4] soundwire: qcom: add support for mmio soundwire master Jonathan Marek
2020-09-05 17:39 ` [PATCH v2 4/4] soundwire: qcom: add v1.5.1 compatible Jonathan Marek
@ 2020-09-07 8:17 ` Srinivas Kandagatla
2020-09-07 14:17 ` Vinod Koul
2 siblings, 0 replies; 4+ messages in thread
From: Srinivas Kandagatla @ 2020-09-07 8:17 UTC (permalink / raw)
To: Jonathan Marek, linux-arm-msm
Cc: moderated list:SOUNDWIRE SUBSYSTEM, Andy Gross, Bard Liao,
Bjorn Andersson,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, Pierre-Louis Bossart, Rob Herring, Sanyog Kale,
Vinod Koul
On 05/09/2020 18:39, Jonathan Marek wrote:
> This adds initial support for soundwire device on sm8250.
>
> Tested with the "wsa" sdw device, which is simpler than the others.
>
> v2 addresses some feedback, but I kept this series as simple as possible.
> In particular, I didn't implement CMD_NACKED from FIFO_STATUS, because
> the downstream driver doesn't define this bit, so I can't implement it.
> Soundwire works without it and It shouldn't be difficult to implement later.
>
> Jonathan Marek (4):
> soundwire: qcom: fix abh/ahb typo
> soundwire: qcom: avoid dependency on CONFIG_SLIMBUS
> soundwire: qcom: add support for mmio soundwire master devices
> soundwire: qcom: add v1.5.1 compatible
>
Hi Jonathan,
I have tested these patches on RB5 with WSA8810 and they work fine.
I can try to add support to command ignored in future, but for now these
look good to me!
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Tested-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Thanks,
srini
> .../bindings/soundwire/qcom,sdw.txt | 1 +
> drivers/soundwire/Kconfig | 2 +-
> drivers/soundwire/qcom.c | 38 +++++++++++++++++--
> 3 files changed, 36 insertions(+), 5 deletions(-)
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 0/4] soundwire: qcom: add support for mmio soundwire master
2020-09-05 17:39 [PATCH v2 0/4] soundwire: qcom: add support for mmio soundwire master Jonathan Marek
2020-09-05 17:39 ` [PATCH v2 4/4] soundwire: qcom: add v1.5.1 compatible Jonathan Marek
2020-09-07 8:17 ` [PATCH v2 0/4] soundwire: qcom: add support for mmio soundwire master Srinivas Kandagatla
@ 2020-09-07 14:17 ` Vinod Koul
2 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2020-09-07 14:17 UTC (permalink / raw)
To: Jonathan Marek
Cc: linux-arm-msm, moderated list:SOUNDWIRE SUBSYSTEM, Andy Gross,
Bard Liao, Bjorn Andersson,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, Pierre-Louis Bossart, Rob Herring, Sanyog Kale
On 05-09-20, 13:39, Jonathan Marek wrote:
> This adds initial support for soundwire device on sm8250.
>
> Tested with the "wsa" sdw device, which is simpler than the others.
>
> v2 addresses some feedback, but I kept this series as simple as possible.
> In particular, I didn't implement CMD_NACKED from FIFO_STATUS, because
> the downstream driver doesn't define this bit, so I can't implement it.
> Soundwire works without it and It shouldn't be difficult to implement later.
Applied all, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread