public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	"Andrew Lunn" <andrew@lunn.ch>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Andreas Färber" <afaerber@suse.de>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] net: ethernet: actions: Add Actions Semi Owl Ethernet MAC driver
Date: Mon, 22 Mar 2021 10:44:20 +0200	[thread overview]
Message-ID: <20210322084420.GA1503756@BV030612LT> (raw)
In-Reply-To: <17876c6e-4688-59e6-216f-445f91a8b884@gmail.com>

Hi Florian,

On Sun, Mar 21, 2021 at 08:30:07PM -0700, Florian Fainelli wrote:
> Hi Christian,
> 
> On 3/21/2021 4:29 PM, Cristian Ciocaltea wrote:
> > Add new driver for the Ethernet MAC used on the Actions Semi Owl
> > family of SoCs.
> > 
> > Currently this has been tested only on the Actions Semi S500 SoC
> > variant.
> > 
> > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
> 
> [snip]
> 
> Do you know the story behind this Ethernet controller? 

I just happened to get a board based on the S500 SoC, so I took this
opportunity to help improving the mainline kernel support, but other
than that I do not really know much about the hardware history.

> The various
> receive/transmit descriptor definitions are 99% those defined in
> drivers/net/ethernet/stmmicro/stmmac/descs.h for the normal descriptor.

That's an interesting observation. I could only assume the vendor did
not want to reinvent the wheel here, but I cannot say if this is a
common design scheme or is something specific to STMicroelectronics
only.

> The register layout of the MAC looks completely different from a
> dwmac100 or dwmac1000 however.

Most probably this is Actions specific.. 

> -- 
> Florian

  reply	other threads:[~2021-03-22  8:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-21 23:29 [PATCH v3 0/3] Add support for Actions Semi Owl Ethernet MAC Cristian Ciocaltea
2021-03-21 23:29 ` [PATCH v3 1/3] dt-bindings: net: Add Actions Semi Owl Ethernet MAC binding Cristian Ciocaltea
2021-03-21 23:29 ` [PATCH v3 2/3] net: ethernet: actions: Add Actions Semi Owl Ethernet MAC driver Cristian Ciocaltea
2021-03-22  3:30   ` Florian Fainelli
2021-03-22  8:44     ` Cristian Ciocaltea [this message]
2021-06-28  8:25       ` Amit Tomer
2021-06-28  9:57         ` Cristian Ciocaltea
2021-03-22 23:38   ` Andrew Lunn
2021-03-23  8:34     ` Cristian Ciocaltea
2021-03-21 23:29 ` [PATCH v3 3/3] MAINTAINERS: Add entries for Actions Semi Owl Ethernet MAC Cristian Ciocaltea
2021-03-22 20:00 ` [PATCH v3 0/3] Add support " patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210322084420.GA1503756@BV030612LT \
    --to=cristian.ciocaltea@gmail.com \
    --cc=afaerber@suse.de \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-actions@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox