public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
To: Amit Tomer <amittomer25@gmail.com>
Cc: "Florian Fainelli" <f.fainelli@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Andrew Lunn" <andrew@lunn.ch>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Andreas Färber" <afaerber@suse.de>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] net: ethernet: actions: Add Actions Semi Owl Ethernet MAC driver
Date: Mon, 28 Jun 2021 12:57:42 +0300	[thread overview]
Message-ID: <20210628095742.GA2261718@BV030612LT> (raw)
In-Reply-To: <CABHD4K_r_ixtBXH_v82S62onYr-=fbh8cHJsdz0oo6MN-i5tVg@mail.gmail.com>

Hi Amit,

On Mon, Jun 28, 2021 at 01:55:40PM +0530, Amit Tomer wrote:
> Hi,
> 
> > > Do you know the story behind this Ethernet controller?
> >
> > I just happened to get a board based on the S500 SoC, so I took this
> > opportunity to help improving the mainline kernel support, but other
> > than that I do not really know much about the hardware history.
> >
> > > The various
> > > receive/transmit descriptor definitions are 99% those defined in
> > > drivers/net/ethernet/stmmicro/stmmac/descs.h for the normal descriptor.
> >
> > That's an interesting observation. I could only assume the vendor did
> > not want to reinvent the wheel here, but I cannot say if this is a
> > common design scheme or is something specific to STMicroelectronics
> > only.
> 
> I am not entirely sure about it but it looks like it *may* only need
> to have a glue driver to
> connect to DWMAC.

From the RX/TX descriptors perspective, this looks like a Synopsys IP,
but the MAC register layout is not similar at all.

Thanks to Mani, a request for clarification has been also sent to Actions,
but they could not confirm. Hence, at the moment, we do not have clear
evidences that it is based on Designware.

> For instance, on the U-boot[1] side (S700 is one of 64bit OWL SoC from
> actions), we kind of re-uses already
> existing DWMAC and provide a glue code, and on the Linux side as well
> have some similar implementation (locally).

The S700 SoC provides Gigabit ethernet capabilities and I assume the
controller is quite different from the 10/100 variant present on S500.
As a matter of fact, Actions has confirmed that in the case of S700, the
licensing was obtained from a third party IP company, although they were
not certain if the provider had previous agreements with Synopsys.

Regards,
Cristi

> Thanks
> -Amit.
> 
> [1]: https://source.denx.de/u-boot/u-boot/-/blob/master/drivers/net/dwmac_s700.c

  reply	other threads:[~2021-06-28  9:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-21 23:29 [PATCH v3 0/3] Add support for Actions Semi Owl Ethernet MAC Cristian Ciocaltea
2021-03-21 23:29 ` [PATCH v3 1/3] dt-bindings: net: Add Actions Semi Owl Ethernet MAC binding Cristian Ciocaltea
2021-03-21 23:29 ` [PATCH v3 2/3] net: ethernet: actions: Add Actions Semi Owl Ethernet MAC driver Cristian Ciocaltea
2021-03-22  3:30   ` Florian Fainelli
2021-03-22  8:44     ` Cristian Ciocaltea
2021-06-28  8:25       ` Amit Tomer
2021-06-28  9:57         ` Cristian Ciocaltea [this message]
2021-03-22 23:38   ` Andrew Lunn
2021-03-23  8:34     ` Cristian Ciocaltea
2021-03-21 23:29 ` [PATCH v3 3/3] MAINTAINERS: Add entries for Actions Semi Owl Ethernet MAC Cristian Ciocaltea
2021-03-22 20:00 ` [PATCH v3 0/3] Add support " patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210628095742.GA2261718@BV030612LT \
    --to=cristian.ciocaltea@gmail.com \
    --cc=afaerber@suse.de \
    --cc=amittomer25@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-actions@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox