* Re: [PATCH v2 1/5] arm64: dts: mediatek: Correct uart clock of MT8192
[not found] ` <20220106032420.11544-2-allen-kh.cheng@mediatek.com>
@ 2022-01-11 19:15 ` Nícolas F. R. A. Prado
0 siblings, 0 replies; only message in thread
From: Nícolas F. R. A. Prado @ 2022-01-11 19:15 UTC (permalink / raw)
To: allen-kh.cheng
Cc: Matthias Brugger, Rob Herring,
Project_Global_Chrome_Upstream_Group, chun-jie.chen, devicetree,
drinkcat, linux-arm-kernel, linux-kernel, linux-mediatek,
srv_heupstream
Hi Allen,
thank you for improving the commit message! However, please see my comment
below.
On Thu, Jan 06, 2022 at 11:24:16AM +0800, allen-kh.cheng wrote:
> From: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com>
>
> When the initial devicetree for mt8192 was added in 48489980e27e ("arm64:
> dts: Add Mediatek SoC MT8192 and evaluation board dts and Makefile"), the
> clock driver for mt8192 was not yet upstream, so the clock property nodes
> were set to the clk26m clock as a placeholder.
>
> Given that the clock driver has since been added through 710573dee31b ("clk:
> mediatek: Add MT8192 basic clocks support"), as well as its dt-bindings
> through f35f1a23e0e1 ("clk: mediatek: Add dt-bindings of MT8192 clocks") and
> devicetree nodes through 5d2b897bc6f5 ("arm64: dts: mediatek: Add mt8192
> clock controllers"), fix the uart clock property to point to the actual
This sentence is incomplete. It is missing "clock." at the end. Could you please
add it?
Same thing for all other patches in this series.
After fixing that typo in the commit message of all patches, please add my
reviewed-by in all patches:
Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Thanks,
Nícolas
^ permalink raw reply [flat|nested] only message in thread