From: Jonathan Cameron <jic23@kernel.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Gwendal Grignou <gwendal@chromium.org>,
robh+dt@kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/7] dt-bindings: iio: sx9324: Add precharge resistor setting
Date: Sun, 20 Mar 2022 12:07:25 +0000 [thread overview]
Message-ID: <20220320120725.13317345@jic23-huawei> (raw)
In-Reply-To: <CAE-0n52Lp9-F_DxHrb1aMQaiSU2qpuW6jKCp6qQ8FXyJ87WApg@mail.gmail.com>
On Tue, 15 Mar 2022 13:05:38 -0700
Stephen Boyd <swboyd@chromium.org> wrote:
> Quoting Gwendal Grignou (2022-03-15 10:30:37)
> > Allow configure the resistance used during precharge.
> >
> > Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
> > ---
> > .../bindings/iio/proximity/semtech,sx9324.yaml | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml b/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml
> > index b8a6ee16854ff..cd8ed50f2882a 100644
> > --- a/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml
> > +++ b/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml
> > @@ -126,6 +126,14 @@ properties:
> > UINT_MAX (4294967295) represents infinite. Other values
> > represent 1-1/N.
> >
> > + semtech,input-precharge-resistor:
>
> It is clearer when the units are in the name of the property.
>
> semtech,input-precharge-resistor-kohms
Added bonus is that you won't need the ref if the units chosen
match one of the ones in
https://github.com/robherring/dt-schema/blob/master/schemas/property-units.yaml
Note kohms isn't there so unless we have an issue representing this in ohms,
please use that instead.
Jonathan
next prev parent reply other threads:[~2022-03-20 12:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 17:30 [PATCH 0/7] Add settings for precharge and internal resistor Gwendal Grignou
2022-03-15 17:30 ` [PATCH 1/7] iio: sx9324: Fix register field spelling Gwendal Grignou
2022-03-15 18:19 ` Stephen Boyd
2022-03-16 21:38 ` Gwendal Grignou
2022-03-15 17:30 ` [PATCH 2/7] dt-bindings: iio: sx9324: Add precharge resistor setting Gwendal Grignou
2022-03-15 20:05 ` Stephen Boyd
2022-03-20 12:07 ` Jonathan Cameron [this message]
2022-03-15 17:30 ` [PATCH 3/7] iio: sx9324: Add precharge internal resistance setting Gwendal Grignou
2022-03-15 20:07 ` Stephen Boyd
2022-03-15 17:30 ` [PATCH 4/7] dt-bindings: iio: sx9324: Add internal compensation resistor setting Gwendal Grignou
2022-03-20 12:44 ` Jonathan Cameron
2022-03-15 17:30 ` [PATCH 5/7] iio: sx9324: Add Setting for internal compensation resistor Gwendal Grignou
2022-03-15 20:08 ` Stephen Boyd
2022-03-15 17:30 ` [PATCH 6/7] dt-bindings: iio: sx9360: Add precharge resistor setting Gwendal Grignou
2022-03-20 12:45 ` Jonathan Cameron
2022-03-15 17:30 ` [PATCH 7/7] iio: sx9360: Add pre-charge " Gwendal Grignou
2022-03-15 20:10 ` Stephen Boyd
2022-03-20 12:48 ` [PATCH 0/7] Add settings for precharge and internal resistor Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220320120725.13317345@jic23-huawei \
--to=jic23@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gwendal@chromium.org \
--cc=linux-iio@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox