From: Bjorn Helgaas <helgaas@kernel.org>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: jingoohan1@gmail.com, mani@kernel.org,
gustavo.pimentel@synopsys.com, fancer.lancer@gmail.com,
lpieralisi@kernel.org, robh+dt@kernel.org, kw@linux.com,
bhelgaas@google.com, kishon@kernel.org,
marek.vasut+renesas@gmail.com, linux-pci@vger.kernel.org,
devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v12 03/19] PCI: Add PCI_HEADER_TYPE_MULTI_FUNC
Date: Fri, 14 Apr 2023 13:58:12 -0500 [thread overview]
Message-ID: <20230414185812.GA212427@bhelgaas> (raw)
In-Reply-To: <20230414061622.2930995-4-yoshihiro.shimoda.uh@renesas.com>
On Fri, Apr 14, 2023 at 03:16:06PM +0900, Yoshihiro Shimoda wrote:
> Add PCI_HEADER_TYPE_MULTI_FUNC macro which is "Multi-Function Device"
> of Header Type Register.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> include/uapi/linux/pci_regs.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_regs.h
> index 5d48413ac28f..a302b67d2834 100644
> --- a/include/uapi/linux/pci_regs.h
> +++ b/include/uapi/linux/pci_regs.h
> @@ -80,6 +80,7 @@
> #define PCI_HEADER_TYPE_NORMAL 0
> #define PCI_HEADER_TYPE_BRIDGE 1
> #define PCI_HEADER_TYPE_CARDBUS 2
> +#define PCI_HEADER_TYPE_MULTI_FUNC 0x80
We test this a few places already; if we add this new macro, shouldn't
we update those places to use it?
> #define PCI_BIST 0x0f /* 8 bits */
> #define PCI_BIST_CODE_MASK 0x0f /* Return result */
> --
> 2.25.1
>
next prev parent reply other threads:[~2023-04-14 18:58 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 6:16 [PATCH v12 00/19] PCI: rcar-gen4: Add R-Car Gen4 PCIe support Yoshihiro Shimoda
2023-04-14 6:16 ` [PATCH v12 01/19] PCI: Add PCI_EXP_LNKCAP_MLW macros Yoshihiro Shimoda
2023-04-14 6:16 ` [PATCH v12 02/19] PCI: Add INtx Mechanism Messages macros Yoshihiro Shimoda
2023-04-14 18:59 ` Bjorn Helgaas
2023-04-17 5:05 ` Yoshihiro Shimoda
2023-04-14 6:16 ` [PATCH v12 03/19] PCI: Add PCI_HEADER_TYPE_MULTI_FUNC Yoshihiro Shimoda
2023-04-14 18:58 ` Bjorn Helgaas [this message]
2023-04-17 4:51 ` Yoshihiro Shimoda
2023-04-14 6:16 ` [PATCH v12 04/19] PCI: dwc: Add dw_pcie_link_set_max_link_width() Yoshihiro Shimoda
2023-04-14 6:16 ` [PATCH v12 05/19] PCI: dwc: Add dw_pcie_link_set_max_width() Yoshihiro Shimoda
2023-04-14 6:16 ` [PATCH v12 06/19] PCI: dwc: Add dw_pcie_link_set_max_cap_width() Yoshihiro Shimoda
2023-04-14 6:16 ` [PATCH v12 07/19] PCI: dwc: Expose dw_pcie_ep_exit() to module Yoshihiro Shimoda
2023-04-14 6:16 ` [PATCH v12 08/19] PCI: dwc: Introduce struct dw_pcie_outbound_atu Yoshihiro Shimoda
2023-04-14 6:16 ` [PATCH v12 09/19] PCI: dwc: Add members into " Yoshihiro Shimoda
2023-04-14 6:16 ` [PATCH v12 10/19] PCI: dwc: Change arguments of dw_pcie_prog_ep_outbound_atu() Yoshihiro Shimoda
2023-04-14 6:16 ` [PATCH v12 11/19] PCI: dwc: Add support for triggering legacy IRQs Yoshihiro Shimoda
2023-04-14 19:42 ` Bjorn Helgaas
2023-04-17 8:09 ` Yoshihiro Shimoda
2023-04-14 6:16 ` [PATCH v12 12/19] PCI: dwc: Add EDMA_UNROLL capability flag Yoshihiro Shimoda
2023-04-14 6:16 ` [PATCH v12 13/19] PCI: dwc: Introduce .ep_pre_init() and .ep_deinit() Yoshihiro Shimoda
2023-04-14 6:16 ` [PATCH v12 14/19] dt-bindings: PCI: renesas: Add R-Car Gen4 PCIe Host Yoshihiro Shimoda
2023-04-14 12:37 ` Rob Herring
2023-04-17 1:10 ` Yoshihiro Shimoda
2023-04-14 6:16 ` [PATCH v12 15/19] dt-bindings: PCI: renesas: Add R-Car Gen4 PCIe Endpoint Yoshihiro Shimoda
2023-04-14 12:37 ` Rob Herring
2023-04-17 1:11 ` Yoshihiro Shimoda
2023-04-14 6:16 ` [PATCH v12 16/19] PCI: rcar-gen4: Add R-Car Gen4 PCIe Host support Yoshihiro Shimoda
2023-04-14 6:16 ` [PATCH v12 17/19] PCI: rcar-gen4-ep: Add R-Car Gen4 PCIe Endpoint support Yoshihiro Shimoda
2023-04-14 6:16 ` [PATCH v12 18/19] MAINTAINERS: Update PCI DRIVER FOR RENESAS R-CAR for R-Car Gen4 Yoshihiro Shimoda
2023-04-14 6:16 ` [PATCH v12 19/19] misc: pci_endpoint_test: Add Device ID for R-Car S4-8 PCIe controller Yoshihiro Shimoda
2023-04-20 20:41 ` [PATCH v12 00/19] PCI: rcar-gen4: Add R-Car Gen4 PCIe support Serge Semin
2023-04-20 20:45 ` Serge Semin
2023-04-25 11:33 ` Yoshihiro Shimoda
2023-04-25 12:50 ` Serge Semin
2023-04-25 23:42 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230414185812.GA212427@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=robh+dt@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox