Re: [PATCH v12 00/19] PCI: rcar-gen4: Add R-Car Gen4 PCIe support

[Serge Semin <fancer.lancer@gmail.com>]

On Thu, Apr 20, 2023 at 11:41:32PM +0300, Serge Semin wrote:
> Hi Yoshihiro
> 
> On Fri, Apr 14, 2023 at 03:16:03PM +0900, Yoshihiro Shimoda wrote:
> > Add R-Car S4-8 (R-Car Gen4) PCIe Host and Endpoint support.
> > To support them, modify PCIe DesignWare common codes.
> 
> Thanks for the updates. I'll have a look at the series on the next
> week.

Oh, I see there is v13 already submitted. I'll send my comments there
then.

-Serge(y)

> 
> -Serge(y)
> 
> > 
> > Changes from v11:
> > https://lore.kernel.org/linux-pci/20230310123510.675685-1-yoshihiro.shimoda.uh@renesas.com/
> >  - Based on next-20230413
> >  - Based on the following cleanups patches:
> >    [PATCH v4 00/14] PCI: dwc: Relatively simple fixes and cleanups
> >    https://lore.kernel.org/linux-pci/20230414021832.13167-1-Sergey.Semin@baikalelectronics.ru/
> >  - Drop a fixed patch of pci-epf-test because I have submitted it independently.
> >  - Split patches about adding dw_pcie_link_set_max_* functions.
> >  - Split patches about modify __dw_pcie_prog_outbound_atu().
> >  - Add description about num lanes into the commit log.
> >  - Add some macros into pci_regs.h and pci.h.
> >  - Add comment about disabling bars in pcie-rcar-gen4-host.c.
> >  - Set MAX_MSI_IRQS to num_vectors for handling 32 MSIs.
> >  - Add .ep_deinit().
> >  - Add retrain link handling of PCIe Host mode for detecting PCIe Gen4.
> >  - Modify some minor things.
> > 
> > Changes from v10:
> > https://lore.kernel.org/linux-pci/20230308082352.491561-1-yoshihiro.shimoda.uh@renesas.com/
> >  - Fix dt-bindings doc for endpoint (reported by Rob's bot).
> >  - Add reg and reg-names to the dt-bindings doc of host.
> >  - Fix examples in the dt-bindings docs of both host and endpoint.
> >  - Add R-Car S4-8 device ID into the pci_test_endpoint driver.
> > 
> > Changes from v9:
> > https://lore.kernel.org/linux-pci/20230210134917.2909314-1-yoshihiro.shimoda.uh@renesas.com/
> >  - Based on next-20230306
> >  - Add bug fix patches into this patch series.
> >    https://lore.kernel.org/linux-pci/20230216092012.3256440-1-yoshihiro.shimoda.uh@renesas.com/
> >    https://lore.kernel.org/linux-pci/20230222015327.3585691-1-yoshihiro.shimoda.uh@renesas.com/
> >  - Add maximum for max-link-speed and num-lanes to dt-bindings of both host and endpoint.
> >  - Add max-functions to dt-bindings of endpoint.
> >  - Use reg-names "app" on endpoint.
> >  - Remove unnecessary linkup and wait process in rcar_gen4_pcie_host_init().
> >  - Remove unnecessary macros in pcie-rcar-gen4.h.
> >  - Use dbi2 to write BAR mask registers.
> >  - Remove no_msix and intx_by_atu flags.
> >  - Reduce __dw_pcie_prog_outbound_atu() arguments.
> >  - Add dw_pcie_num_lanes_setup() to setup num_lanes.
> >  - Refactor dw_pcie_setup() to avoid PCIE_PORT_LINK_CONTROL writing twice.
> > 
> > Yoshihiro Shimoda (19):
> >   PCI: Add PCI_EXP_LNKCAP_MLW macros
> >   PCI: Add INtx Mechanism Messages macros
> >   PCI: Add PCI_HEADER_TYPE_MULTI_FUNC
> >   PCI: dwc: Add dw_pcie_link_set_max_link_width()
> >   PCI: dwc: Add dw_pcie_link_set_max_width()
> >   PCI: dwc: Add dw_pcie_link_set_max_cap_width()
> >   PCI: dwc: Expose dw_pcie_ep_exit() to module
> >   PCI: dwc: Introduce struct dw_pcie_outbound_atu
> >   PCI: dwc: Add members into struct dw_pcie_outbound_atu
> >   PCI: dwc: Change arguments of dw_pcie_prog_ep_outbound_atu()
> >   PCI: dwc: Add support for triggering legacy IRQs
> >   PCI: dwc: Add EDMA_UNROLL capability flag
> >   PCI: dwc: Introduce .ep_pre_init() and .ep_deinit()
> >   dt-bindings: PCI: renesas: Add R-Car Gen4 PCIe Host
> >   dt-bindings: PCI: renesas: Add R-Car Gen4 PCIe Endpoint
> >   PCI: rcar-gen4: Add R-Car Gen4 PCIe Host support
> >   PCI: rcar-gen4-ep: Add R-Car Gen4 PCIe Endpoint support
> >   MAINTAINERS: Update PCI DRIVER FOR RENESAS R-CAR for R-Car Gen4
> >   misc: pci_endpoint_test: Add Device ID for R-Car S4-8 PCIe controller
> > 
> >  .../bindings/pci/rcar-gen4-pci-ep.yaml        |  98 +++++++++
> >  .../bindings/pci/rcar-gen4-pci-host.yaml      | 109 ++++++++++
> >  MAINTAINERS                                   |   1 +
> >  drivers/misc/pci_endpoint_test.c              |   4 +
> >  drivers/pci/controller/dwc/Kconfig            |  18 ++
> >  drivers/pci/controller/dwc/Makefile           |   4 +
> >  .../pci/controller/dwc/pcie-designware-ep.c   |  93 ++++++--
> >  drivers/pci/controller/dwc/pcie-designware.c  | 201 +++++++++++-------
> >  drivers/pci/controller/dwc/pcie-designware.h  |  27 ++-
> >  .../pci/controller/dwc/pcie-rcar-gen4-ep.c    | 166 +++++++++++++++
> >  .../pci/controller/dwc/pcie-rcar-gen4-host.c  | 134 ++++++++++++
> >  drivers/pci/controller/dwc/pcie-rcar-gen4.c   | 187 ++++++++++++++++
> >  drivers/pci/controller/dwc/pcie-rcar-gen4.h   |  49 +++++
> >  include/linux/pci.h                           |  18 ++
> >  include/uapi/linux/pci_regs.h                 |   7 +
> >  15 files changed, 1020 insertions(+), 96 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/pci/rcar-gen4-pci-ep.yaml
> >  create mode 100644 Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml
> >  create mode 100644 drivers/pci/controller/dwc/pcie-rcar-gen4-ep.c
> >  create mode 100644 drivers/pci/controller/dwc/pcie-rcar-gen4-host.c
> >  create mode 100644 drivers/pci/controller/dwc/pcie-rcar-gen4.c
> >  create mode 100644 drivers/pci/controller/dwc/pcie-rcar-gen4.h
> > 
> > -- 
> > 2.25.1
> >