From: Jonathan Cameron <jic23@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [dt-schema PATCH] schemas: iio: add label
Date: Sat, 13 May 2023 19:12:08 +0100 [thread overview]
Message-ID: <20230513191208.10ec3cf2@jic23-huawei> (raw)
In-Reply-To: <20230507171219.232216-1-krzk@kernel.org>
On Sun, 7 May 2023 19:12:19 +0200
Krzysztof Kozlowski <krzk@kernel.org> wrote:
> Linux IIO core code parses label property which is already used in
> several IIO devices.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> dtschema/schemas/iio/iio.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/dtschema/schemas/iio/iio.yaml b/dtschema/schemas/iio/iio.yaml
> index 5ce5e147aef1..727ca0f9afec 100644
> --- a/dtschema/schemas/iio/iio.yaml
> +++ b/dtschema/schemas/iio/iio.yaml
> @@ -30,6 +30,10 @@ properties:
> with a single IIO output and 1 for nodes with multiple IIO outputs.
> A few unusual devices have a 2 level mapping.
>
> + label:
> + description:
> + Unique name to identify which IIO channel or device this is.
Ah. I thought this as covered by the entry in dt-core.yaml
If not fair enough, though is this flexible enough to cover that it can
exist at device level and in a channel node?
If so lgtm
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> +
> mount-matrix:
> $ref: /schemas/types.yaml#/definitions/non-unique-string-array
> minItems: 9
next prev parent reply other threads:[~2023-05-13 17:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-07 17:12 [dt-schema PATCH] schemas: iio: add label Krzysztof Kozlowski
2023-05-13 18:12 ` Jonathan Cameron [this message]
2023-06-08 18:13 ` Rob Herring
2023-06-10 17:42 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230513191208.10ec3cf2@jic23-huawei \
--to=jic23@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox