From: Jonathan Cameron <jic23@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [dt-schema PATCH] schemas: iio: add label
Date: Sat, 10 Jun 2023 18:42:06 +0100 [thread overview]
Message-ID: <20230610184206.4a4c3da8@jic23-huawei> (raw)
In-Reply-To: <168624795645.3178290.5235314768802159315.robh@kernel.org>
On Thu, 8 Jun 2023 12:13:55 -0600
Rob Herring <robh@kernel.org> wrote:
> On Sun, 07 May 2023 19:12:19 +0200, Krzysztof Kozlowski wrote:
> > Linux IIO core code parses label property which is already used in
> > several IIO devices.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> > dtschema/schemas/iio/iio.yaml | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
>
> Applied, thanks!
>
I'm guessing you already know this but I hit it during testing.
dtschema/main + ruamel.yaml 0.17.24 and later seem to be broken. It installs
fine but...
AttributeError: module 'ruamel.yaml' has no attribute 'YAML'
$ /usr/bin/dt-doc-validate
Traceback (most recent call last):
File "/usr/bin/dt-doc-validate", line 4, in <module>
__import__('pkg_resources').run_script('dtschema==2023.5.dev6+g4ddf315.d20230610', 'dt-doc-validate')
File "/usr/lib/python3.11/site-packages/pkg_resources/__init__.py", line 720, in run_script
self.require(requires)[0].run_script(script_name, ns)
File "/usr/lib/python3.11/site-packages/pkg_resources/__init__.py", line 1559, in run_script
exec(code, namespace, namespace)
File "/usr/lib/python3.11/site-packages/dtschema-2023.5.dev6+g4ddf315.d20230610-py3.11.egg/EGG-INFO/scripts/dt-doc-validate", line 16, in <module>
import dtschema
File "/usr/lib/python3.11/site-packages/dtschema-2023.5.dev6+g4ddf315.d20230610-py3.11.egg/dtschema/__init__.py", line 1, in <module>
from dtschema.lib import (
File "/usr/lib/python3.11/site-packages/dtschema-2023.5.dev6+g4ddf315.d20230610-py3.11.egg/dtschema/lib.py", line 35, in <module>
rtyaml = ruamel.yaml.YAML(typ='rt')
I've worked around this by setting a max version at 0.17.
Only change in ruamel.yaml between those is:
https://sourceforge.net/p/ruamel-yaml/code/ci/4309006902d2453399588f4ddccfb3fc460e1eba/
My python is terrible so I'm not looking into this further.
Jonathan
prev parent reply other threads:[~2023-06-10 17:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-07 17:12 [dt-schema PATCH] schemas: iio: add label Krzysztof Kozlowski
2023-05-13 18:12 ` Jonathan Cameron
2023-06-08 18:13 ` Rob Herring
2023-06-10 17:42 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230610184206.4a4c3da8@jic23-huawei \
--to=jic23@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox