public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Pratyush Yadav <pratyush@kernel.org>,
	Michael Walle <michael@walle.cc>,
	linux-mtd@lists.infradead.org, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	devicetree@vger.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH 1/2] dt-bindings: mtd: spi-nor: Document sst26vf0xxb flash series
Date: Thu, 15 Jun 2023 16:42:33 +0200	[thread overview]
Message-ID: <20230615164233.51a87cbd@xps-13> (raw)
In-Reply-To: <d816499e-baab-6200-0780-17a8205b252e@linaro.org>

Hi Tudor,

tudor.ambarus@linaro.org wrote on Mon, 12 Jun 2023 11:00:03 +0100:

> On 6/9/23 15:43, Miquel Raynal wrote:
> > Add compatibles for the sst26vf0{40,80,16,32,64}b flash devices.
> > 
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > ---
> >  Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> > index 7149784a36ac..5a788a429b0d 100644
> > --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> > +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> > @@ -25,7 +25,7 @@ properties:
> >                (mxicy|macronix),mx25l(4005a|1606e|6405d|8005|12805d|25635e)|\
> >                (mxicy|macronix),mx25u(4033|4035)|\
> >                (spansion,)?s25fl(128s|256s1|512s|008k|064k|164k)|\
> > -              (sst|microchip),sst25vf(016b|032b|040b)|\
> > +              (sst|microchip),sst(25|26)vf(008|016|032|040|064)b|\  
> 
> We don't add new compatibles to this list, one should instead use the
> generic jedec,spi-nor compatible. Please drop this patch.

Sure. I'll propose a patch to clarify this point in the bindings to
help future-myself.

> 
> >                (sst,)?sst26wf016b|\
> >                (sst,)?sst25wf(040b|080)|\
> >                winbond,w25x(80|32)|\  


Thanks,
Miquèl

  reply	other threads:[~2023-06-15 14:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-09 14:43 [PATCH 0/2] mtd: spi-nor: Support for another sst flash Miquel Raynal
2023-06-09 14:43 ` [PATCH 1/2] dt-bindings: mtd: spi-nor: Document sst26vf0xxb flash series Miquel Raynal
2023-06-12 10:00   ` Tudor Ambarus
2023-06-15 14:42     ` Miquel Raynal [this message]
2023-06-09 14:43 ` [PATCH 2/2] mtd: spi-nor: Add support for sst26vf032b flash Miquel Raynal
2023-06-12  9:57   ` Tudor Ambarus
2023-06-13 13:34   ` Michael Walle
2023-06-14  6:56     ` Tudor Ambarus
2023-06-14  7:04       ` Michael Walle
2023-06-14  7:13         ` Tudor Ambarus
2023-06-14  7:25           ` Michael Walle
2023-06-12 10:03 ` [PATCH 0/2] mtd: spi-nor: Support for another sst flash Tudor Ambarus
2023-06-12 17:06   ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230615164233.51a87cbd@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=michael@walle.cc \
    --cc=pratyush@kernel.org \
    --cc=richard@nod.at \
    --cc=robh+dt@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=tudor.ambarus@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox