Re: [PATCH 0/2] mtd: spi-nor: Support for another sst flash

[Miquel Raynal <miquel.raynal@bootlin.com>]

Hi Tudor,

tudor.ambarus@linaro.org wrote on Mon, 12 Jun 2023 11:03:55 +0100:

> On 6/9/23 15:43, Miquel Raynal wrote:
> > Hello Tudor,  
> 
> Hi, Miquel!
> 
> > 
> > Here are a couple of patches adding support for the sst26vf032b spi-nor,
> > nothing specific here. I hope I ran all the required tests correctly,
> > otherwise let me know.  
> 
> The tests are fine, thanks. I think it's debatable whether we include
> the output of the tests in the commit message or in the comments section
> below the --- line, but I'm fine either way.

I have a slight preference to have them in the commit log, this way
they are part of the git history and easier to find. But I agree, since
we now have well tracked mailing lists, my concerns might slowly go
away.

> I had some comments for the patches, I'll let you read them.

Yep, I'll make additional tests and see what I can come up with.

> Cheers,
> ta
> > 
> > Cheers,
> > Miquèl
> > 
> > Miquel Raynal (2):
> >   dt-bindings: mtd: spi-nor: Document sst26vf0xxb flash series
> >   mtd: spi-nor: Add support for sst26vf032b flash
> > 
> >  Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 2 +-
> >  drivers/mtd/spi-nor/sst.c                                | 4 ++++
> >  2 files changed, 5 insertions(+), 1 deletion(-)
> >   


Thanks,
Miquèl