[PATCH 0/2] mtd: spi-nor: Support for another sst flash

[PATCH 0/2] mtd: spi-nor: Support for another sst flash

[Miquel Raynal]

Hello Tudor,

Here are a couple of patches adding support for the sst26vf032b spi-nor,
nothing specific here. I hope I ran all the required tests correctly,
otherwise let me know.

Cheers,
Miquèl

Miquel Raynal (2):
  dt-bindings: mtd: spi-nor: Document sst26vf0xxb flash series
  mtd: spi-nor: Add support for sst26vf032b flash

 Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 2 +-
 drivers/mtd/spi-nor/sst.c                                | 4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)

-- 
2.34.1

[PATCH 1/2] dt-bindings: mtd: spi-nor: Document sst26vf0xxb flash series

[Miquel Raynal]

Add compatibles for the sst26vf0{40,80,16,32,64}b flash devices.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
 Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
index 7149784a36ac..5a788a429b0d 100644
--- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
+++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
@@ -25,7 +25,7 @@ properties:
               (mxicy|macronix),mx25l(4005a|1606e|6405d|8005|12805d|25635e)|\
               (mxicy|macronix),mx25u(4033|4035)|\
               (spansion,)?s25fl(128s|256s1|512s|008k|064k|164k)|\
-              (sst|microchip),sst25vf(016b|032b|040b)|\
+              (sst|microchip),sst(25|26)vf(008|016|032|040|064)b|\
               (sst,)?sst26wf016b|\
               (sst,)?sst25wf(040b|080)|\
               winbond,w25x(80|32)|\
-- 
2.34.1

Re: [PATCH 1/2] dt-bindings: mtd: spi-nor: Document sst26vf0xxb flash series

[Tudor Ambarus]

On 6/9/23 15:43, Miquel Raynal wrote:
> Add compatibles for the sst26vf0{40,80,16,32,64}b flash devices.
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>  Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> index 7149784a36ac..5a788a429b0d 100644
> --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> @@ -25,7 +25,7 @@ properties:
>                (mxicy|macronix),mx25l(4005a|1606e|6405d|8005|12805d|25635e)|\
>                (mxicy|macronix),mx25u(4033|4035)|\
>                (spansion,)?s25fl(128s|256s1|512s|008k|064k|164k)|\
> -              (sst|microchip),sst25vf(016b|032b|040b)|\
> +              (sst|microchip),sst(25|26)vf(008|016|032|040|064)b|\

We don't add new compatibles to this list, one should instead use the
generic jedec,spi-nor compatible. Please drop this patch.

>                (sst,)?sst26wf016b|\
>                (sst,)?sst25wf(040b|080)|\
>                winbond,w25x(80|32)|\

Re: [PATCH 1/2] dt-bindings: mtd: spi-nor: Document sst26vf0xxb flash series

[Miquel Raynal]

Hi Tudor,

tudor.ambarus@linaro.org wrote on Mon, 12 Jun 2023 11:00:03 +0100:

> On 6/9/23 15:43, Miquel Raynal wrote:
> > Add compatibles for the sst26vf0{40,80,16,32,64}b flash devices.
> > 
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > ---
> >  Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> > index 7149784a36ac..5a788a429b0d 100644
> > --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> > +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> > @@ -25,7 +25,7 @@ properties:
> >                (mxicy|macronix),mx25l(4005a|1606e|6405d|8005|12805d|25635e)|\
> >                (mxicy|macronix),mx25u(4033|4035)|\
> >                (spansion,)?s25fl(128s|256s1|512s|008k|064k|164k)|\
> > -              (sst|microchip),sst25vf(016b|032b|040b)|\
> > +              (sst|microchip),sst(25|26)vf(008|016|032|040|064)b|\  
> 
> We don't add new compatibles to this list, one should instead use the
> generic jedec,spi-nor compatible. Please drop this patch.

Sure. I'll propose a patch to clarify this point in the bindings to
help future-myself.

> 
> >                (sst,)?sst26wf016b|\
> >                (sst,)?sst25wf(040b|080)|\
> >                winbond,w25x(80|32)|\  


Thanks,
Miquèl

[PATCH 2/2] mtd: spi-nor: Add support for sst26vf032b flash

[Miquel Raynal]

Describe this new part. I simply copy/pasted the entry for its cousins
with twice more/less storage capacity. The datasheet is public:
https://ww1.microchip.com/downloads/aemDocuments/documents/MPD/ProductDocuments/DataSheets/SST26VF032B-SST26VF032BA-2.5V-3.0V-32-Mbit-Serial-Quad-IO-%28SQI%29-Flash-Memory-20005218K.pdf
Without the NO_SFDP_FLAGs only partial erasures happen so I believe the
4K sector flag is needed. I cannot test dual/quad reads, so I kept these
to mimic the other entries, just in case.

Here are the sfdp tables plus base testing to show it works.

$ cat /sys/bus/spi/devices/spi0.0/spi-nor/partname
sst26vf032b
$ cat /sys/bus/spi/devices/spi0.0/spi-nor/jedec_id
bf2642
$ cat /sys/bus/spi/devices/spi0.0/spi-nor/manufacturer
sst
$ xxd -p /sys/bus/spi/devices/spi0.0/spi-nor/sfdp
53464450060102ff00060110300000ff81000106000100ffbf0001180002
0001fffffffffffffffffffffffffffffffffd20f1ffffffff0144eb086b
083b80bbfeffffffffff00ffffff440b0c200dd80fd810d820914824806f
1d81ed0f773830b030b0f7ffffff29c25cfff030c080ffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffff0004fff37f0000f57f0000f9ff
3d00f57f0000f37f0000ffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffbf2642ffb95ffdff30f260f332ff0a122346ff0f19320f1919ffffff
ffffffff00669938ff05013506040232b03072428de89888a585c09faf5a
ffff06ec060c0003080bffffffffff07ffff0202ff060300fdfd040600fc
0300fefe0202070e
$ md5sum /sys/bus/spi/devices/spi0.0/spi-nor/sfdp
e7efddddb3d5ee89ca37bf6b6e789645  /sys/bus/spi/devices/spi0.0/spi-nor/sfdp

$ dd if=/dev/urandom of=./qspi_test bs=1M count=1
1+0 records in
1+0 records out
$ mtd_debug write /dev/mtd0 0 1048576 qspi_test
Copied 1048576 bytes from qspi_test to address 0x00000000 in flash
$ mtd_debug erase /dev/mtd0 0 1048576
Erased 1048576 bytes from address 0x00000000 in flash
$ mtd_debug read /dev/mtd0 0 1048576 qspi_read
Copied 1048576 bytes from address 0x00000000 in flash to qspi_read
$ hexdump qspi_read
0000000 ffff ffff ffff ffff ffff ffff ffff ffff
*
0100000
$ mtd_debug write /dev/mtd0 0 1048576 qspi_test
Copied 1048576 bytes from qspi_test to address 0x00000000 in flash
$ mtd_debug read /dev/mtd0 0 1048576 qspi_read
Copied 1048576 bytes from address 0x00000000 in flash to qspi_read
$ sha1sum qspi_test qspi_read
2f2f191c7a937eca5db21a1c39e79e7327587cc1  qspi_test
2f2f191c7a937eca5db21a1c39e79e7327587cc1  qspi_read

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
 drivers/mtd/spi-nor/sst.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/mtd/spi-nor/sst.c b/drivers/mtd/spi-nor/sst.c
index 99c8a19493f5..43f37d66f73a 100644
--- a/drivers/mtd/spi-nor/sst.c
+++ b/drivers/mtd/spi-nor/sst.c
@@ -113,6 +113,10 @@ static const struct flash_info sst_nor_parts[] = {
 		FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE)
 		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ)
 		.fixups = &sst26vf_nor_fixups },
+	{ "sst26vf032b", INFO(0xbf2642, 0, 64 * 1024, 64)
+		FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE)
+		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ)
+		.fixups = &sst26vf_nor_fixups },
 	{ "sst26vf064b", INFO(0xbf2643, 0, 64 * 1024, 128)
 		FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE)
 		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ)
-- 
2.34.1

Re: [PATCH 2/2] mtd: spi-nor: Add support for sst26vf032b flash

[Tudor Ambarus]

On 6/9/23 15:43, Miquel Raynal wrote:
> Describe this new part. I simply copy/pasted the entry for its cousins
> with twice more/less storage capacity. The datasheet is public:

All the cousins should be updated to use PARSE_SFDP instead.

> https://ww1.microchip.com/downloads/aemDocuments/documents/MPD/ProductDocuments/DataSheets/SST26VF032B-SST26VF032BA-2.5V-3.0V-32-Mbit-Serial-Quad-IO-%28SQI%29-Flash-Memory-20005218K.pdf
> Without the NO_SFDP_FLAGs only partial erasures happen so I believe the

What do you mean by "partial erasures happen"?

> 4K sector flag is needed. I cannot test dual/quad reads, so I kept these
> to mimic the other entries, just in case.

The flash seems to have the SFDP tables (you dumped them below), so I
would expect the 4k erase size to be discovered at SFDP parsing time.
> 
> Here are the sfdp tables plus base testing to show it works.
> 
> $ cat /sys/bus/spi/devices/spi0.0/spi-nor/partname
> sst26vf032b
> $ cat /sys/bus/spi/devices/spi0.0/spi-nor/jedec_id
> bf2642
> $ cat /sys/bus/spi/devices/spi0.0/spi-nor/manufacturer
> sst
> $ xxd -p /sys/bus/spi/devices/spi0.0/spi-nor/sfdp
> 53464450060102ff00060110300000ff81000106000100ffbf0001180002
> 0001fffffffffffffffffffffffffffffffffd20f1ffffffff0144eb086b
> 083b80bbfeffffffffff00ffffff440b0c200dd80fd810d820914824806f
> 1d81ed0f773830b030b0f7ffffff29c25cfff030c080ffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffff0004fff37f0000f57f0000f9ff
> 3d00f57f0000f37f0000ffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffbf2642ffb95ffdff30f260f332ff0a122346ff0f19320f1919ffffff
> ffffffff00669938ff05013506040232b03072428de89888a585c09faf5a
> ffff06ec060c0003080bffffffffff07ffff0202ff060300fdfd040600fc
> 0300fefe0202070e
> $ md5sum /sys/bus/spi/devices/spi0.0/spi-nor/sfdp
> e7efddddb3d5ee89ca37bf6b6e789645  /sys/bus/spi/devices/spi0.0/spi-nor/sfdp
> 
> $ dd if=/dev/urandom of=./qspi_test bs=1M count=1
> 1+0 records in
> 1+0 records out
> $ mtd_debug write /dev/mtd0 0 1048576 qspi_test
> Copied 1048576 bytes from qspi_test to address 0x00000000 in flash
> $ mtd_debug erase /dev/mtd0 0 1048576
> Erased 1048576 bytes from address 0x00000000 in flash
> $ mtd_debug read /dev/mtd0 0 1048576 qspi_read
> Copied 1048576 bytes from address 0x00000000 in flash to qspi_read
> $ hexdump qspi_read
> 0000000 ffff ffff ffff ffff ffff ffff ffff ffff
> *
> 0100000
> $ mtd_debug write /dev/mtd0 0 1048576 qspi_test
> Copied 1048576 bytes from qspi_test to address 0x00000000 in flash
> $ mtd_debug read /dev/mtd0 0 1048576 qspi_read
> Copied 1048576 bytes from address 0x00000000 in flash to qspi_read
> $ sha1sum qspi_test qspi_read
> 2f2f191c7a937eca5db21a1c39e79e7327587cc1  qspi_test
> 2f2f191c7a937eca5db21a1c39e79e7327587cc1  qspi_read
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>  drivers/mtd/spi-nor/sst.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/sst.c b/drivers/mtd/spi-nor/sst.c
> index 99c8a19493f5..43f37d66f73a 100644
> --- a/drivers/mtd/spi-nor/sst.c
> +++ b/drivers/mtd/spi-nor/sst.c
> @@ -113,6 +113,10 @@ static const struct flash_info sst_nor_parts[] = {
>  		FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE)
>  		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ)
>  		.fixups = &sst26vf_nor_fixups },
> +	{ "sst26vf032b", INFO(0xbf2642, 0, 64 * 1024, 64)
> +		FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE)
> +		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ)

If you replace the NO_SFDP_FLAGS line with PARSE_SFDP, is the flash
working correctly?

> +		.fixups = &sst26vf_nor_fixups },
>  	{ "sst26vf064b", INFO(0xbf2643, 0, 64 * 1024, 128)
>  		FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE)
>  		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ)

Re: [PATCH 2/2] mtd: spi-nor: Add support for sst26vf032b flash

[Michael Walle]

Hi,

Am 2023-06-09 16:43, schrieb Miquel Raynal:
> Describe this new part. I simply copy/pasted the entry for its cousins
> with twice more/less storage capacity. The datasheet is public:
> https://ww1.microchip.com/downloads/aemDocuments/documents/MPD/ProductDocuments/DataSheets/SST26VF032B-SST26VF032BA-2.5V-3.0V-32-Mbit-Serial-Quad-IO-%28SQI%29-Flash-Memory-20005218K.pdf

As Link: tag please

> Without the NO_SFDP_FLAGs only partial erasures happen so I believe the
> 4K sector flag is needed. I cannot test dual/quad reads, so I kept 
> these
> to mimic the other entries, just in case.

I'd prefer to have proper SFDP parsing, even if you cannot confirm that
dual/quad reads are working. That could always be a fixup later.

> Here are the sfdp tables plus base testing to show it works.
> 
> $ cat /sys/bus/spi/devices/spi0.0/spi-nor/partname
> sst26vf032b
> $ cat /sys/bus/spi/devices/spi0.0/spi-nor/jedec_id
> bf2642
> $ cat /sys/bus/spi/devices/spi0.0/spi-nor/manufacturer
> sst
> $ xxd -p /sys/bus/spi/devices/spi0.0/spi-nor/sfdp
> 53464450060102ff00060110300000ff81000106000100ffbf0001180002
> 0001fffffffffffffffffffffffffffffffffd20f1ffffffff0144eb086b
> 083b80bbfeffffffffff00ffffff440b0c200dd80fd810d820914824806f
> 1d81ed0f773830b030b0f7ffffff29c25cfff030c080ffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffff0004fff37f0000f57f0000f9ff
> 3d00f57f0000f37f0000ffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffbf2642ffb95ffdff30f260f332ff0a122346ff0f19320f1919ffffff
> ffffffff00669938ff05013506040232b03072428de89888a585c09faf5a
> ffff06ec060c0003080bffffffffff07ffff0202ff060300fdfd040600fc
> 0300fefe0202070e
> $ md5sum /sys/bus/spi/devices/spi0.0/spi-nor/sfdp
> e7efddddb3d5ee89ca37bf6b6e789645  
> /sys/bus/spi/devices/spi0.0/spi-nor/sfdp

Thanks!

> $ dd if=/dev/urandom of=./qspi_test bs=1M count=1
> 1+0 records in
> 1+0 records out
> $ mtd_debug write /dev/mtd0 0 1048576 qspi_test
> Copied 1048576 bytes from qspi_test to address 0x00000000 in flash
> $ mtd_debug erase /dev/mtd0 0 1048576
> Erased 1048576 bytes from address 0x00000000 in flash
> $ mtd_debug read /dev/mtd0 0 1048576 qspi_read
> Copied 1048576 bytes from address 0x00000000 in flash to qspi_read
> $ hexdump qspi_read
> 0000000 ffff ffff ffff ffff ffff ffff ffff ffff
> *
> 0100000
> $ mtd_debug write /dev/mtd0 0 1048576 qspi_test
> Copied 1048576 bytes from qspi_test to address 0x00000000 in flash
> $ mtd_debug read /dev/mtd0 0 1048576 qspi_read
> Copied 1048576 bytes from address 0x00000000 in flash to qspi_read
> $ sha1sum qspi_test qspi_read
> 2f2f191c7a937eca5db21a1c39e79e7327587cc1  qspi_test
> 2f2f191c7a937eca5db21a1c39e79e7327587cc1  qspi_read
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>  drivers/mtd/spi-nor/sst.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/sst.c b/drivers/mtd/spi-nor/sst.c
> index 99c8a19493f5..43f37d66f73a 100644
> --- a/drivers/mtd/spi-nor/sst.c
> +++ b/drivers/mtd/spi-nor/sst.c
> @@ -113,6 +113,10 @@ static const struct flash_info sst_nor_parts[] = {
>  		FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE)
>  		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ)
>  		.fixups = &sst26vf_nor_fixups },
> +	{ "sst26vf032b", INFO(0xbf2642, 0, 64 * 1024, 64)

Please try with INFO(0xbf2642, 0, 0, 0). You can also have a look
at the debugfs and compare it to your current flags to check that
nothing has changed.

-michael

> +		FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE)
> +		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ)
> +		.fixups = &sst26vf_nor_fixups },
>  	{ "sst26vf064b", INFO(0xbf2643, 0, 64 * 1024, 128)
>  		FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE)
>  		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ)

Re: [PATCH 2/2] mtd: spi-nor: Add support for sst26vf032b flash

[Tudor Ambarus]

Hi, Michael,

On 6/13/23 14:34, Michael Walle wrote:
>> +    { "sst26vf032b", INFO(0xbf2642, 0, 64 * 1024, 64)
> 
> Please try with INFO(0xbf2642, 0, 0, 0). You can also have a look

Oh, yes, I forgot about this. Will you send a new version of
https://patchwork.ozlabs.org/project/linux-mtd/patch/20220510140232.3519184-2-michael@walle.cc/
or you'd like someone else to take over?

Cheers,
ta

Re: [PATCH 2/2] mtd: spi-nor: Add support for sst26vf032b flash

[Michael Walle]

Am 2023-06-14 08:56, schrieb Tudor Ambarus:
> Hi, Michael,
> 
> On 6/13/23 14:34, Michael Walle wrote:
>>> +    { "sst26vf032b", INFO(0xbf2642, 0, 64 * 1024, 64)
>> 
>> Please try with INFO(0xbf2642, 0, 0, 0). You can also have a look
> 
> Oh, yes, I forgot about this. Will you send a new version of
> https://patchwork.ozlabs.org/project/linux-mtd/patch/20220510140232.3519184-2-michael@walle.cc/
> or you'd like someone else to take over?

Now that I'm back from vacation, I'll get back to it soon :)

-michael

Re: [PATCH 2/2] mtd: spi-nor: Add support for sst26vf032b flash

[Tudor Ambarus]

On 6/14/23 08:04, Michael Walle wrote:
> Am 2023-06-14 08:56, schrieb Tudor Ambarus:
>> Hi, Michael,
>>
>> On 6/13/23 14:34, Michael Walle wrote:
>>>> +    { "sst26vf032b", INFO(0xbf2642, 0, 64 * 1024, 64)
>>>
>>> Please try with INFO(0xbf2642, 0, 0, 0). You can also have a look
>>
>> Oh, yes, I forgot about this. Will you send a new version of
>> https://patchwork.ozlabs.org/project/linux-mtd/patch/20220510140232.3519184-2-michael@walle.cc/
>> or you'd like someone else to take over?
> 
> Now that I'm back from vacation, I'll get back to it soon :)
> 

Welcome back! Ok, thanks, we will all benefit of it. Specifying zeroes
is a non-sense, but it helps us when we transition to SFDP_ID macro
(or whatever it will be called).

Re: [PATCH 2/2] mtd: spi-nor: Add support for sst26vf032b flash

[Michael Walle]

>>>>> +    { "sst26vf032b", INFO(0xbf2642, 0, 64 * 1024, 64)
>>>> 
>>>> Please try with INFO(0xbf2642, 0, 0, 0). You can also have a look
>>> 
>>> Oh, yes, I forgot about this. Will you send a new version of
>>> https://patchwork.ozlabs.org/project/linux-mtd/patch/20220510140232.3519184-2-michael@walle.cc/
>>> or you'd like someone else to take over?
>> 
>> Now that I'm back from vacation, I'll get back to it soon :)
>> 
> 
> Welcome back! Ok, thanks, we will all benefit of it. Specifying zeroes
> is a non-sense, but it helps us when we transition to SFDP_ID macro
> (or whatever it will be called).

Sure, that was always the plan. I just want to make sure, no new flashes
are added with this unneeded information and thus it would require
retesting when moving to the new macro.

-michael

Re: [PATCH 0/2] mtd: spi-nor: Support for another sst flash

[Tudor Ambarus]

On 6/9/23 15:43, Miquel Raynal wrote:
> Hello Tudor,

Hi, Miquel!

> 
> Here are a couple of patches adding support for the sst26vf032b spi-nor,
> nothing specific here. I hope I ran all the required tests correctly,
> otherwise let me know.

The tests are fine, thanks. I think it's debatable whether we include
the output of the tests in the commit message or in the comments section
below the --- line, but I'm fine either way.

I had some comments for the patches, I'll let you read them.
Cheers,
ta
> 
> Cheers,
> Miquèl
> 
> Miquel Raynal (2):
>   dt-bindings: mtd: spi-nor: Document sst26vf0xxb flash series
>   mtd: spi-nor: Add support for sst26vf032b flash
> 
>  Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 2 +-
>  drivers/mtd/spi-nor/sst.c                                | 4 ++++
>  2 files changed, 5 insertions(+), 1 deletion(-)
> 

Re: [PATCH 0/2] mtd: spi-nor: Support for another sst flash

[Miquel Raynal]

Hi Tudor,

tudor.ambarus@linaro.org wrote on Mon, 12 Jun 2023 11:03:55 +0100:

> On 6/9/23 15:43, Miquel Raynal wrote:
> > Hello Tudor,  
> 
> Hi, Miquel!
> 
> > 
> > Here are a couple of patches adding support for the sst26vf032b spi-nor,
> > nothing specific here. I hope I ran all the required tests correctly,
> > otherwise let me know.  
> 
> The tests are fine, thanks. I think it's debatable whether we include
> the output of the tests in the commit message or in the comments section
> below the --- line, but I'm fine either way.

I have a slight preference to have them in the commit log, this way
they are part of the git history and easier to find. But I agree, since
we now have well tracked mailing lists, my concerns might slowly go
away.

> I had some comments for the patches, I'll let you read them.

Yep, I'll make additional tests and see what I can come up with.

> Cheers,
> ta
> > 
> > Cheers,
> > Miquèl
> > 
> > Miquel Raynal (2):
> >   dt-bindings: mtd: spi-nor: Document sst26vf0xxb flash series
> >   mtd: spi-nor: Add support for sst26vf032b flash
> > 
> >  Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 2 +-
> >  drivers/mtd/spi-nor/sst.c                                | 4 ++++
> >  2 files changed, 5 insertions(+), 1 deletion(-)
> >   


Thanks,
Miquèl